bhovhannes / redux-profiler Goto Github PK

This issue provides visibility into Renovate updates and their statuses. Learn more

This repository currently has no open or pending branches.

• Check this box to trigger a request for Renovate to run again on this repository

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

The following calling path will trigger a Failed to execute 'measure' on 'Performance': The mark 'xxx:0:start' does not exist error in redux-profiler. I create a example to show this bug in https://codesandbox.io/s/quiet-leaf-35b88 :

1. Click "bugAdd" and trigger a thunk action asyncAdd
2. asyncAdd trigger action syncAdd
3. The change in store made by syncAdd trigger a effect in Helper.jsx
4. Effect in Helper.jsx trigger syncAdd
5. Error shows

Thank you for your redux profiler that looks really interesting.

I do not understand how to look at the results though.
Is it the React Dev Tool or in another location?

Thank you a lot!

Despite having a good adoption by the current browsers, sometimes performance.mark is still unavailable in some environments.

In my case, it is not available in my test environment leading to a crash of some of my units tests. It looks like it is due to the fake timers of Jest that remove the performance.mark function. (I wanted to create a codesandbox to show the problem but we cannot use the jest fake timers in codesandbox).

It would be nice to check if performance.mark really exists before calling it and therefore avoid raising an error.

For example, here's the error I get:

Test suite failed to run

    TypeError: performance.mark is not a function

      40 | epicMiddleware.run(rootEpic);
      41 |
    > 42 | store.dispatch(initAction());
         |       ^
      43 |
      44 | export default store;
      45 |

      at performProfiledOperation (node_modules/redux-profiler/dist/redux-profiler.umd.js:145:21)
      at Object.dispatch (node_modules/redux-profiler/dist/redux-profiler.umd.js:203:21)
      at Object.<anonymous> (src/store/index.ts:42:7)
      at Object.<anonymous> (src/components/XanonymizationX.test.tsx:6:1)

What do you think? (if needed, I can send a PR)