Description:

PsychroLib.dll is currently missing in BHoM/Assemblies folder causing the following problem in GH:

Steps to reproduce:

Expected behaviour:

Test file(s):

Psychrometrics_Toolkit-PsychrometricsTestScript.zip

For SaturatedVapourPressureWater.

Description:

I understand that BHoM works in base SI units, but it would be great it we could make this clear in excel functions, especially where the more common units are kJ, kPa, etc for the specific metric.

e.g add J/kg to the end like so: "Calculates enthalpy from dry-bulb temperature and humidity ratio (J/kg)"

Description:

Methods like DensityHumidityRatio, DensityRelativeHumidity and DensityWetBulbTemperature can be combined into a single method called Density, that has functionality to compute density from some given values. The Density method would take in these values and decide which calculation to do, then do the calculation and return the correct value. In the case where there is not enough information to compute, it will throw an error that accurately describes what is missing. If the user inputs more information and multiple methods can be used, it will select a method to use, and also output a message to the user that describes the inputs used to make the calculation.

The AssemblyFileVersion attribute should now be updated to read 4.1.0.0 for all AssemblyInfo.cs files within this repository for the 4.1 milestone.

Definition of the test :

It would be great to automate the testing of the Psychometrics Toolkit by creating the unit tests.

The AssemblyFileVersion attribute should now be updated to read 4.2.0.0 for all AssemblyInfo.cs files within this repository for the 4.2 milestone.

Description:

Add the following methods from Climate toolkit into Psychrometrics, following discussion on https://github.com/BuroHappoldEngineering/Climate_Toolkit/issues/204

• DensityWater
• SpecificHeatCapacityWater
• SaturatedVapourPressureWater

Either replace with code previously in climate toolkit or with respective Psychrolib methods.

Ensure documentation and QA/QC is complete and up-to-date for the methods.

The AssemblyFileVersion attribute should now be updated to read 4.1.0.0 for all AssemblyInfo.cs files within this repository for the 4.1 milestone.

The following errors have been reported on unit tests in this repository.

BHoM/Psychrometrics_Toolkit.ci\Datasets\Compute\PartialVapourPressure.json
Unit test set: PartialVapourPressure. Author: Karolina Prusicka
One or more of the UnitTests failed.
Inner results:
UnitTest: Method: PartialVapourPressure(Double dryBulbTemperature).
The UnitTest did not pass.
Inner results:
TestData: index: 0
Failed to run unit test. Errors given:
Failed to run with the given inputs

BHoM/Psychrometrics_Toolkit.ci\Datasets\Compute\TemperatureAtAltitude.json
Unit test set: TemperatureAtAltitude. Author: Karolina Prusicka
One or more of the UnitTests failed.
Inner results:
UnitTest: Method: TemperatureAtAltitude(Double altitude).
The UnitTest did not pass.
Inner results:
TestData: index: 0
Execution of the method did not return the expected outputs.
Inner results:
07/09/2023 04:20:37
Data returned for output 0 is different than expected.
Expected value: 15, returned value from execution: 288.15.

Definition of the test :

The three newest methods: FromHumidityRatio, FromRelativeHumidity and FromWetBulbTemperature require data driven unit tests to align with the other methods in the toolkit.

For input values:

• Temperatures between 173.15 and 473.15
• Humidity Ratios between 0 and 1
• Relative Humidity between 0 and 100
• Pressure between 0 and 200,000

These will be recorded with low confidence.

Notes :

• At pressures below 8739 Pa, HumidityRatio cannot be 0, and RelativeHumidity cannot be below 100%

The following errors have been reported on unit tests in this repository.

BHoM/Psychrometrics_Toolkit.ci\Datasets\Compute\PartialVapourPressure.json
Unit test set: PartialVapourPressure. Author: Karolina Prusicka
One or more of the UnitTests failed.
Inner results:
UnitTest: Method: PartialVapourPressure(Double dryBulbTemperature).
The UnitTest did not pass.
Inner results:
TestData: index: 0
Failed to run unit test. Errors given:
Failed to run with the given inputs

BHoM/Psychrometrics_Toolkit.ci\Datasets\Compute\TemperatureAtAltitude.json
Unit test set: TemperatureAtAltitude. Author: Karolina Prusicka
One or more of the UnitTests failed.
Inner results:
UnitTest: Method: TemperatureAtAltitude(Double altitude).
The UnitTest did not pass.
Inner results:
TestData: index: 0
Execution of the method did not return the expected outputs.
Inner results:
08/09/2023 04:12:24
Data returned for output 0 is different than expected.
Expected value: 15, returned value from execution: 288.15.

The AssemblyFileVersion attribute should now be updated to read 3.3.0.0 for all AssemblyInfo.cs files within this repository for the start of the 3.3 milestone

All BHoM .cs files need to contain the current BHoM copyright statement as their header.

For more information see Code Compliance - HasValidCopyright

Broken rules:

The base SI unit for temperature in the BHoM is Kelvin per:
https://github.com/BHoM/BHoM/blob/aeb89ef53b6183e8a3865f413e2016404e8a823f/Quantities_oM/Attributes/Temperature.cs#L27-L38

Suggestions to restore compliance:

Modify all methods that use temperature as an input or output, modify to the correct unit, K.

Broken rules:

Suggestions to restore compliance:

The AssemblyFileVersion attribute should now be updated to read 4.1.0.0 for all AssemblyInfo.cs files within this repository for the 4.1 milestone.

The AssemblyFileVersion attribute should now be updated to read 4.0.0.0 for all AssemblyInfo.cs files within this repository for the 4.0 milestone.

The AssemblyVersion should also be updated to read 4.0.0.0 for all AssemblyInfo.cs files within this repository for the 4.0 series.

The AssemblyFileVersion attribute should now be updated to read 4.1.0.0 for all AssemblyInfo.cs files within this repository for the 4.1 milestone.

In line with other toolkits close to the core and are engine based.

Add the code to perform the calculations.

Per title

Description:

API - psychrolib.GetDryAirDensity

This is helpful for CFD calculation