Comments (8)
Modifying typeMap
directly would also change functionality for other packages that use typechecker
which could cause problems.
However, getType
accepts a second parameter that can be a type map, so you could do the following:
// custom-typechecker.js
const typechecker = require('typechecker')
const customTypeChecker = Object.assign({}, typechecker)
const customTypeMap = {
array: typechecker.isArray,
boolean: typechecker.isBoolean,
date: typechecker.isDate,
error: typechecker.isError,
class: typechecker.isClass,
function: typechecker.isFunction,
null: typechecker.isNull,
number: typechecker.isNumber,
regexp: typechecker.isRegExp,
string: typechecker.isString,
'undefined': typechecker.isUndefined,
buffer: Buffer.isBuffer, // must be before isObject, as otherwise isObject will catch it
map: typechecker.isMap,
weakmap: typechecker.isWeakMap,
object: typechecker.isObject
}
customTypeChecker.getType = function customGetType (value, _typeMap) {
return typechecker.getType(value, _typeMap || customTypeMap)
}
module.exports = customTypeChecker
// app.js
var result = require('./custom-typechecker.js').getType(Buffer.from(''))
console.log(result) // buffer
from typechecker.
That didn't work as written. customTypeMap is neither exported nor passed into the new getType. I tried a few variations on this to no avail.
Did you mean this??
customTypeChecker.typeMap = {
would just overwrite the frozen type map and then nothing need be done to getTypes.
I tried that and that still fails. Got time to get this working for yourself first? I'll write a pr for the readme once it's working.
it('Should include custom types', function () {
expect(u.isBuffer(Buffer.from('this is a test'))).to.equal(true)
expect(u.getType(Buffer.from('this is a test'))).to.equal('buffer')
})
1) Variable Types Library - Should include custom types:
AssertionError: expected 'object' to equal 'buffer'
+ expected - actual
-object
+buffer
from typechecker.
Update previous example, should work.
from typechecker.
@dkebler okay, my updated code should work, but there is a bug in typechecker, so I'll update the code
from typechecker.
@dkebler okay, v4.4.1 is fixed, which makes the above work
from typechecker.
the customTypeMap definition could also be done like so:
// Add our custom types
const customTypeMap = {
buffer: Buffer.isBuffer
}
// Add original types
Object.keys(typechecker.typeMap).forEach(function (key) {
customTypeMap[key] = customTypeMap[key] || typechecker.typeMap[key]
})
from typechecker.
@balupton thanks! Now I can all add my classes as types :-).
I definitely preferred merging the maps (cleaner) but your object.keys statement above wasn't doing it. So here is the final working module. I'll do a PR for the readme and add this with some explanation.
again thx.
//mytypechecker.js
const typechecker = require('typechecker')
const customTypeChecker = Object.assign({}, typechecker)
// add custom types, a key and corresponding function for each
customTypeChecker.isBuffer = function isBuffer(obj) {
return !!obj.constructor && typeof obj.constructor.isBuffer === 'function' && obj.constructor.isBuffer(obj)
}
// Create a custom type map and make an key/property for each new type
// the key/property used will be the string returned by getType.
let customTypeMap = {
buffer: customTypeChecker.isBuffer
}
// merge base typeMap with customTypeMap
customTypeMap = Object.assign(customTypeMap, customTypeChecker.typeMap)
//overwrite getType to use customTypeMap if available
customTypeChecker.getType = function customGetType(value, _typeMap) {
return typechecker.getType(value, _typeMap || customTypeMap)
}
module.exports = customTypeChecker
from typechecker.
Glad it works :-)
I definitely preferred merging the maps (cleaner) but your object.keys statement above wasn't doing it.
Whoops fixed.
from typechecker.
Related Issues (18)
- Breaking change after version 2.0.1 with Node v0.6 HOT 6
- Strange log "export function getObjectType" from source/index.js:17 HOT 4
- IE11 compatibility problem HOT 1
- typeChecker.isPlainObject() return non boolean value HOT 2
- Pre-installations exits with non-zero status in 2.0.8 HOT 4
- Add docs to npmignore HOT 3
- async functions not recognized as functions by isFunction HOT 5
- Usage within angular6 HOT 2
- Generator Functions HOT 4
- add isSymbol
- Add support for Set
- the lib/typechecker.js isEmpty function is look like this... HOT 2
- Your .dependabot/config.yml contained invalid details HOT 1
- broke between 4.7 and 4.11, no default export HOT 1
- Add isClass value check HOT 1
- Your .dependabot/config.yml contained invalid details HOT 1
- Add YUIDocs HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typechecker.