`deleteOrphaned` Option Doesn't Delete Hidden Files about repo-file-sync-action HOT 9 CLOSED

I concur. From a user of this action's perspective, the ignoring of hidden files was rather unexpected. My vote would be to have hidden files included by default unless someone has a use-case where this behavior wouldn't be desirable.

from repo-file-sync-action.

This is caused by the library used for reading files node-readfiles. By default it doesn't include hidden files in its output so this action doesn't check to see if they are orphaned.

This is a simple fix though, the question is just if we should include hidden files by default or if we add a new option to enable this behaviour like includeHidden or something similar.

My general goal is to not add any breaking changes to this action, so the second method with a configuration option to enable it seems safer. The action currently doesn't distinguish between normal and hidden files anywhere else though, so the current behaviour is more of a bug and we should just include hidden files as well. That's what I am leaning towards.

Any thoughts?

from repo-file-sync-action.

Yeah I can see why that might be unexpected. I didn't know node-readfiles excluded them by default and I guess have never had to sync hidden files or else I would have noticed.

Will implement a fix sometime this week.

from repo-file-sync-action.

Implemented a fix in #160.

@Casey-Kiewit please verify that it works by running the action with that branch:

uses: BetaHuhn/repo-file-sync-action@fix/hidden-files

Will release it to master after that.

from repo-file-sync-action.

@BetaHuhn That branch seems to exhibit the same issues we've been running into. Here's what we tried with it:

1. Changed the file sync to point to the new branch of this action. No sync PRs were created.
2. Merged in a PR that added back in the .env file it missed. Created sync PRs adding the .env file where it had been manually deleted.
3. Merged in a PR removing the .env file again. No sync files were updated.

from repo-file-sync-action.

Oh no, just saw that I forgot to rebuild the action on that branch, fixed now. Sorry!

I tested it myself just now and it now works. Could you please try again @Casey-Kiewit?

from repo-file-sync-action.

@BetaHuhn Thanks for fixing that! I really appreciate it! This action has been working wonderfully for us!

I've tested and confirmed that the new build successfully removes hidden files for us as well.

from repo-file-sync-action.

Okay great, thanks for confirming!

Will merge and release it later today.

from repo-file-sync-action.

🎉 This issue has been resolved in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from repo-file-sync-action.