betahuhn / deploy-to-vercel-action Goto Github PK

Recently, we started getting this more occasionally (sometimes it works, sometimes it doesn't).

Thoughts on adding needed permissions to the readme?

After some trial and error it seems that the 'new' personal access tokens need the following permissions:

🐞 Describe the bug

I'm unable to use a PR preview domain (the PR_PREVIEW_DOMAIN option) when the project is link to a team.

Without the PR_PREVIEW_DOMAIN the project is correctly deployed:

      - name: Deploy to Vercel
        uses: BetaHuhn/deploy-to-vercel-action@v1
        with:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}
          VERCEL_ORG_ID: team_xxxxxxxxxxxxxx
          VERCEL_PROJECT_ID: xxxxxxxxxxxx
          GITHUB_DEPLOYMENT: false
          PR_LABELS: false
          DELETE_EXISTING_COMMENT: false

When I add the PR_PREVIEW_DOMAIN:

          PR_PREVIEW_DOMAIN: '{REPO}-{PR}.vercel.app'

I got this error:

Error: undefinedVercel CLI 23.1.2
Error! Failed to find deployment "ibe-ak7jds436-gogaille.vercel.app" under armandabric

armandabric is my personal vercel account. And the ibe project is a project of one of my Vercel team.

🖼️ Screenshots

⚙️ Environment

• Action version: [e.g. v1.0.0]

🐞 Describe the bug

In the docs you say that the default value for PRODUCTION is "true (false for PR deployments)", but when I use this action from a pull request, it creates a production deployment on vercel.

📚 To Reproduce

Create a pull request on a repository with an ordinary github action like this:

name: Vercel Preview Deployment

on: [push]

jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      # Check out the code
      - name: Checkout
        uses: actions/checkout@v4

      # Deploy on vercel
      - name: Deploy to Vercel
        uses: BetaHuhn/deploy-to-vercel-action@v1

💡 Expected behavior

Creates a preview deployment

🖼️ Screenshots

N/A

⚙️ Environment

I am using BetaHuhn/deploy-to-vercel-action@v1

📋 Additional context

N/A

I get the following warning on every deploy:

After starting a deployment with the basic example i receive ERROR Not Found. I have all of my secrets set on the gh repo.
Screens:

What could be the issue?

Thanks

ALIAS_DOMAINS, PR_PREVIEW_DOMAIN

Verified that if I use "ALIAS_DOMAINS" it causes the hang up during "Assigning custom domains to Vercel deployment"

PR_PREVIEW_DOMAIN seems to be fine but doesn't do anything without ALIAS_DOMAINS it seems so it does not hang.

steps:
- name: Deply to Vercel
id: DeployVercelAction
uses: BetaHuhn/[email protected]
with:
VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }} # Required
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} #Optional
VERCEL_ORG_ID: ${{ secrets.ORG_ID}} #Required
VERCEL_PROJECT_ID: ${{ secrets.PROJECT_ID}} #Required
PRODUCTION: false
GITHUB_DEPLOYMENT_ENV: Preview
ALIAS_DOMAINS: |
jung.vercel.app
{BRANCH}-jung.vercel.app
PR_PREVIEW_DOMAIN: "{BRANCH}-jung.vercel.app"

In the docs you have the FORCE option to skip vercels build cache. But when used throws the following warning:

While deploying I get the following error, do you have any ideas?

Error: Cannot read property 'login' of null

The deploy script is basically copy'n'paste from the docs:

# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
name: Deploy to Vercel CI

on:
  workflow_dispatch:
  push:
    branches: [develop]

jobs:
  deploy:
    runs-on: ubuntu-latest
    if: "!contains(github.event.head_commit.message, '[skip ci]')"
    steps:
      - name: Checkout
        uses: actions/checkout@v2

      - name: Deploy
        uses: BetaHuhn/deploy-to-vercel-action@v1
        with:
          GITHUB_TOKEN: ${{ secrets.GH_PAT }}
          VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}
          VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }}
          VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }}
          PRODUCTION: false

🐞 Describe the bug

Running a commit that contains backticks (`), cause the action to fail because the shell seems to try and run what is contained within the backticks.

📚 To Reproduce
Create a commit with e.g. the message: Switch to ESM format to remove need on dependency fsx

Deploy using this action using default config (no custom options), result:

Error: Command failed: vercel -t *** -m "githubCommitAuthorName=Selwyn" -m "githubCommitAuthorLogin=Siilwyn" -m "githubCommitMessage=Switch to ESM format to remove need on dependency `fsx`" -m "githubCommitOrg=voorhoede" -m "githubCommitRepo=life-terra-platform" -m "githubCommitRef=paginate-translations" -m "githubCommitSha=0aa1994f696737ebe462c6fab9931ce937382c5c" -m "githubOrg=voorhoede" -m "githubRepo=life-terra-platform" -m "githubDeployment=1"
/bin/sh: 1: fsx: not found

🐞 Describe the bug

Discovered this bug today the first time:

Hello, I have been using this action with no problems, and now I just did a small update since I want the build to point to a specific environment to fetch content from a CMS. When adding the BUILD_ENV option to the action, it returns the reported error when running the workflow.

Adding this to the action yml:

Generates this error:

Removing the BUILD_ENV removes the error.

🐞 Describe the bug

Action hangs indefinitely when Vercel token is expired.

📚 To Reproduce

Run action with expired token.

💡 Expected behavior

Action should fail and/or alert the user that the token is expired.

⚙️ Environment

• Action version: 1.9.10

Github announced on 2022-09-22 that Actions are required to update to use node 16 instead of 12. Please update this action to node 16 🙏

Edit: this is already being worked on at #264

Hello, since 28.0.1 is live since yesterday, and my CD with github action not working anymore since 28.0.1 I wonder the action need an update.

Do you have any idea beceause I can't use a custom version. Thanks :)

Run BetaHuhn/[email protected] Creating GitHub deployment Deployment #629186761 created Deployment #629186761 status changed to "pending" Creating deployment with Vercel CLI Setting environment variables for Vercel CLI Starting deploy with Vercel CLI Error: undefinedVercel CLI 28.0.1 Retrieving project…