besh81 / nana-extra Goto Github PK

View Code? Open in Web Editor NEW

20.0 20.0 7.0 323 KB

A collection of Nana custom controls

C++ 100.00%

nana-extra's People

Contributors

Stargazers

Watchers

Forkers

jamesbremner errorflynn 5cript susmaz xsjames qpcr4vir

nana-extra's Issues

BUG in PropertyGrid: The property value is ONLY updated when the user presses the ENTER key

i want to write the property values, after the user has set them, to a database. But I do not get the new values set by the user.

This code ( based on demo with save button added )

#include <nana/gui.hpp>
#include <nana/gui/place.hpp>
#include <nana/gui/widgets/textbox.hpp>

#include "propertygrid.h"
#include "pgitems.h"

int main()
{
    nana::form fm(0, nana::size{ 600, 500 });
    nana::place pl{ fm };
    pl.div("margin=50 gap=5 field");

    nana::propertygrid propgrid{ fm };
    pl["field"] << propgrid;

    nana::textbox txt{ fm };
    pl["field"] << txt;
    txt.editable(false);


    // append category
    auto cat = propgrid.append("Standard properties");
    // append string property
    cat.append(nana::propertygrid::pgitem_ptr(new nana::pg_string("string", "ABC")));
    // append int property
    cat.append(nana::propertygrid::pgitem_ptr(new nana::pg_string_int("int", "-100")));
    // append unsigned int property
    cat.append(nana::propertygrid::pgitem_ptr(new nana::pg_string_uint("unsigned int", "100")));
    // append string with button property
    cat.append(nana::propertygrid::pgitem_ptr(new nana::pg_string_button("string + button", "Ciao")));
    // append choice property
    auto ip = cat.append(nana::propertygrid::pgitem_ptr(new nana::pg_choice("choice")));
    auto pgchoiche = static_cast<nana::pg_choice*>(ip._m_pgitem());
    pgchoiche->push_back("One");
    pgchoiche->push_back("Two");
    pgchoiche->push_back("3");
    // append check property
    cat.append(nana::propertygrid::pgitem_ptr(new nana::pg_check("check", true)));
    // append color property
    cat.append(nana::propertygrid::pgitem_ptr(new nana::pg_color("color", "255,0,0")));
    // append color+inherited property
    ip = cat.append(nana::propertygrid::pgitem_ptr(new nana::pg_color("color + inherited", "128,128,128", true)));
    ip.value("0,255,0");

    // connect the events
    propgrid.events().property_changed([&txt](const nana::arg_propertygrid& arg)
    {
        auto ip = arg.item;
        txt.append("[cat: " + std::to_string(ip.pos().cat) + ", pos: " + std::to_string(ip.pos().item) + "] ", true);
        txt.append("   label: " + ip.label() + "\n", true);
    });

    // Save button will read the current value of the int properrty
    nana::button save(fm,nana::rectangle{5,5,40,25},true);
    save.caption("SAVE");
    save.events().click([&propgrid]()
    {
        std::string t = propgrid.find("Standard properties","int").value();
        nana::msgbox msg("Current Value of int property");
        msg << t;
        msg.show();
    });


    pl.collocate();
    fm.show();
    nana::exec();
}

Shows this result after user changes int property to 34

Question: Collapsing a category

I want to start up my application with the categories collapsed.

( There are over 100 properties, so it is overwhelming to see all of them at once )

I tried:

    cat = propgrid.append("Output Ports");
    cat.expand( false );

but expand is not a method of the cat_proxy class returned by append.

It is an attribute of the structure category_t

cat_proxy does have a private attribute that is a pointer to a category_t structure, so maybe that is what I need?

PropertyGrid feature request: nested categories.

I am requesting that categories should not only contain property items, but also child categories.

Something like this:

	// append category to top level
	auto parent_cat = propgrid.append("Parent");

       // append category under parent
       auto child_cat = propgrid.appendIn( parent_cat, "Child" );

Motivation

I was hoping to port my wxWidgets property grid application to nana. This has over 100 properties, so having just one level of category makes finding a particular property difficult for the user. Here is a screenshot of the wxWidgets app:

On startup, all categories are collapsed, hiding their children and so helping the user find what needs to be looked at in detail:

With categories expanded:

Here is a screenshot of the app built with wxWidgets, which has no vertical gap between properties.

PropertyGrid Question: Use of item_proxy::_m_pgitem()

nana-extra/propertygrid/propertygrid.h

Line 259 in a032cdb

pgitem* _m_pgitem() const; ///< Internal use

The comment on the declaration of this method suggests it is for internal use only.

Yet I seem to need to use it very often in my application code.

Creating a choice property ( this is from your demo code )

auto ip = cat.append(nana::propertygrid::pgitem_ptr(new nana::pg_choice("choice")));
auto pgchoiche = static_cast<nana::pg_choice*>(ip._m_pgitem());
pgchoiche->push_back("One");
pgchoiche->push_back("Two");
pgchoiche->push_back("3");

and also when I need to select a choice

int selected;
... set selected...
(static_cast<nana::pg_choice*>(pg.find("Output Ports","A Format")._m_pgitem()))->option( selected ));

So, my questions:

Should I be using this, or something else?
If it should be used, can you fix the comment to describe what it does?
If it should be used, maybe you could change the name to make application code easier to read?

PG: Uninitialized variable warning

nana-extra/propertygrid/propertygrid.cpp

Line 711 in a032cdb

int pos_offset_end, pos_offset = 0;

My compiler ( g++ v8.3 ) does not like this, reporting an uninitialized variable.

Probably should add

pos_offset_end = 0;

BUG PropertyGrid choice property set value fails

nana-extra/propertygrid/pgitems.cpp

Lines 414 to 423 in 0beab38

 void pg_choice::value(const std::string& value_) 

 { 

 try 

 { 

 option(std::stoul(pgitem::value())); 

 } 

 catch(...) 

 { 

 } 

 }

The intention here ( I assume - there is no documentation ) is to select a new option. It fails. Instead the current value is set again.

At a minimum, line 418 should be changed to

option(std::stoul( value_ ));

I would also change the name of the parameter - it looks like a class member.

besh81 / nana-extra Goto Github PK

nana-extra's People

Contributors

Stargazers

Watchers

Forkers

nana-extra's Issues

BUG in PropertyGrid: The property value is ONLY updated when the user presses the ENTER key

Question: Collapsing a category

PropertyGrid feature request: nested categories.

Question on PropertyGrid: Little box displayed beside every property

pgitem memory leak

Compile failure

Feature Request PropertyGrid: Vertical gap between properties

PropertyGrid Question: Use of item_proxy::_m_pgitem()

PG: Uninitialized variable warning

BUG PropertyGrid choice property set value fails

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	void pg_choice::value(const std::string& value_)
	{
	try
	{
	option(std::stoul(pgitem::value()));
	}
	catch(...)
	{
	}
	}