berend / pyiban Goto Github PK

I think get_account_number(), get_bank_code() and get_iban() are bad names and don't really reflect what those methods are doing. In my opinion the API would be much clearer with those names:

extract_account_number()
extract_bank_code()
generate_iban()

What do you think?

PyPI still serves v0.1

bban_format ={
    "AD": {
        "composition": "{04:bank_code}{04:branch_code}{012:account_number}",
        "country": "Andorra",
        "bank_code"
        "length": 24
    },
    …

evaluates to

bban_format ={
    "AD": {
        "composition": "{04:bank_code}{04:branch_code}{012:account_number}",
        "country": "Andorra",
        "bank_codelength": 24
    },
    …

Note the bank_codelength. This does not seem intended and is well hidden, because strings with the same indent level just get appended and don't throw an error like "no value for this key".