beppimenozzi / knob Goto Github PK

Hi, first of all thanks for this awesome lib.
Lib tend to crash on almost all emulators and devices below SDK 19. But working fine on latest devices.
Any idea ?...
Complete stacktrace...

E/AndroidRuntime: FATAL EXCEPTION: main
java.lang.NullPointerException
at android.widget.RelativeLayout.onMeasure(RelativeLayout.java:465)
at android.view.View.measure(View.java:15172)
at it.beppi.balloonpopuplibrary.BalloonPopup.draw(BalloonPopup.java:255)
at it.beppi.balloonpopuplibrary.BalloonPopup.show(BalloonPopup.java:213)
at it.beppi.balloonpopuplibrary.BalloonPopup.access$400(BalloonPopup.java:35)
at it.beppi.balloonpopuplibrary.BalloonPopup$Builder.show(BalloonPopup.java:541)
at it.beppi.knoblibrary.Knob.displayBalloons(Knob.java:273)
at it.beppi.knoblibrary.Knob.onDraw(Knob.java:133)
at android.view.View.draw(View.java:13458)
at android.view.View.getDisplayList(View.java:12409)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.getDisplayList(View.java:12407)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.getDisplayList(View.java:12407)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.getDisplayList(View.java:12407)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.draw(View.java:13461)
at android.view.View.getDisplayList(View.java:12409)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.getDisplayList(View.java:12407)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.getDisplayList(View.java:12407)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.draw(View.java:13461)
at android.widget.FrameLayout.draw(FrameLayout.java:467)
at android.view.View.getDisplayList(View.java:12409)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.getDisplayList(View.java:12407)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.getDisplayList(View.java:12407)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.getDisplayList(View.java:12407)
at android.view.View.getDisplayList(View.java:12453)
at android.view.View.draw(View.java:13182)
at android.view.ViewGroup.drawChild(ViewGroup.java:2929)
at android.view.ViewGroup.dispatchDraw(ViewGroup.java:2799)
at android.view.View.draw(View.java:13461)
at android.widget.FrameLayout.draw(FrameLayout.java:467)
at com.android.internal.policy.impl.PhoneWindow$DecorView.draw(PhoneWindow.java:2183)
at android.view.View.getDisplayList(View.java:12409)
at android.view.View.getDisplayList(View.java:12453)

Hello,
When the device is in RTL mode, the Knob isn't flipped horizontally. I think this can be easily fixed by checking if device is RTL, and then invert the drawing/gestures.
Thomas

is not good

Hi, it seems that knob views embedded in a ScrollView do not work properly. The ScrollView element does still receive drag events even when a swipe gesture starts on a knob view.

Hi. In the project I make for hobby, I design a screen that will set the temperature of my house.

I want the colors of the "Selectstate Marker" in the yellow box to go from blue to red.

As in the picture below.

http://stackcuriosity.com/wp-content/uploads/2017/11/^C60A62B9C6170A99654101587211D3BC878F12BF27F54699DA^pimgpsh_fullsize_distr.jpg

The new click behaviour will come in very handy for me. Unfortunately, I cannot get it working for my knob configuration. Here is the Knob style I'm using:

<style name="KnobStyle">
    <item name="kNumberOfStates">21</item>
    <item name="kSwipe">circular</item>
    <item name="kMinAngle">-120</item>
    <item name="kMaxAngle">120</item>
    <item name="kKnobColor">?attr/colorAccent</item>
    <item name="kKnobRelativeRadius">0.75</item>
    <item name="kKnobCenterRelativeRadius">0.75</item>
    <item name="kIndicatorRelativeLength">0.35</item>
    <item name="kStateMarkersAccentWidth">2dp</item>
    <item name="kStateMarkersWidth">2dp</item>
    <item name="kFreeRotation">false</item>
    <item name="kBorderWidth">0dp</item>
    <item name="kStateMarkersAccentPeriodicity">5</item>
    <item name="kStateMarkersAccentColor">?android:attr/textColorPrimary</item>
    <item name="kSelectedStateMarkerContinuous">true</item>
    <item name="kSelectedStateMarkerColor">?attr/colorAccent</item>
    <item name="kStateMarkersColor">?android:attr/textColorSecondary</item>
    <item name="kClickBehaviour">user</item>
</style>

Here is the Java code:

knob.setUserBehaviour(new Runnable() {
    @Override
    public void run() {
        Toast.makeText(getContext(), "Knob clicked!", Toast.LENGTH_SHORT).show();
    }
});

The Toast message does not show when I click the Knob. If I change kSwipe to horizontal it does work, but I really want to keep it on circular. Any suggestions?

With the following settings:
k.setDefaultState(0);
k.setBalloonValuesTimeToLive(1);
k.setAnimation(true);
k.setKnobRelativeRadius(KNOB_SIZE);
k.setFreeRotation(true);
k.setShowBalloonValues(true);
k.setNumberOfStates(10);
k.setBalloonValuesTimeToLive(0);

android:layout_width="64dp"
android:layout_height="64dp"
android:id="@+id/knob1"
app:kNumberOfStates="10"

It seems that the initial balloon for the state zero never dissapears. When the value is changed, it has both the initial and the current value balloons.

setEnable(false) should let background be grey

fow now, setEnable(false) just let the know do not swipe, user can not know it's disabled clearly.

On a volume knob with 100 values and a low kSwipeSensitivityPixels (below 20), the knob doesn't work properly with a custom .png drawable or with the pop up balloon enabled. Disabling the drawable and using flat colors for the knob parameters fixes the issues. The biggest issue it that the problem still persist when the drawable is set to app:kKnobDrawableRotates="false" which means the image is static and there is no need to redraw it.

Thanks for a nice library.

when setting kMaxAngle and kMinAngle, snapping to minAngle is OK, and when you go "before" the min angle, it tolerates quite well, but when just past the maxAngle, it snaps back to min angle with no tolerance.