bep / portable-hugo-links Goto Github PK

I was playing around with your render-link template, and came up with a somewhat simpler version of the code used to derive the final link value that you might want to use:

{{- $link := .Destination }}
{{- $url := urls.Parse $link }}
{{- $isRemote := $url.IsAbs }}
{{- if and (not $isRemote) (strings.HasSuffix $url.Path ".md") }}
  {{- $link = relref .Page $link }}
{{- end -}}

Here I'm using the parsed URL to determine whether the link is a local markdown link, and the relref function to convert that to the relative location of that page. This handles fragments for us, and generates a nice error message if the page cannot be found.

I tried to use the example here. It works great for links with anchor to another page, but if I use an anchor to this page, such as a link [like](#this), it does not work correctly.

Consider add support and some example?

I am new to hugo, and I tried to make some modifications:

{{ $link := .Destination }}
{{ $isRemote := strings.HasPrefix $link "http" }}
{{- if not $isRemote -}}
  {{ $url := urls.Parse .Destination }}
  {{ $fragment := "" }}
  {{- with $url.Fragment }}{{ $fragment = printf "#%s" . }}{{ end -}}
  {{- if $url.Path -}}{{/* ensure it referring to another page */}}
    {{- with .Page.GetPage $url.Path }}{{ $url.Path }}{{ $link = printf "%s%s" .RelPermalink $fragment }}{{.Permalink}}{{ end }}
  {{- else -}}
    {{ $link = $fragment }}
  {{ end }}
{{ end -}}
<a href="{{ $link | safeURL }}"{{ with .Title}} title="{{ . }}"{{ end }}{{ if $isRemote }} target="_blank"{{ end }}>{{ .Text | safeHTML }}</a>

I was trying use render-links example here with anchors, but that doesn't seem to work. For the regular page the relative URL works (yay), but not for those using anchors. Looking at what gets generated I see a nopPage for .relPermalink returned for the link with anchor.

I'm not sure if there may be some config that is wrong my side, or if relative links with anchors need to be specially handled.

thank you for this, because i was struggling to edit and manage tons of content via VSCode/Obsidian
and i need to keep markdown readability, so the links have to be kept in md format

but why isn't this a default behaviour? or a config enabled option?

are there any problems if i keep these links?