Giter Club home page Giter Club logo

Comments (16)

pythoneer avatar pythoneer commented on June 23, 2024

Same results here. Arch Linux 3.14.4-1 nvidia 337.19 GTX 750 Ti

from 3denginecpp.

Colt-Zero avatar Colt-Zero commented on June 23, 2024

@Zammalad

Hmm... While I have not downloaded and checked the latest commit, I can say that after having watching the latest addition to the tutorial, that I am not experiencing this problem with variance shadow mapping. Having typed out the code myself whilst following Benny's video, I am not sure about the commit itself.

This is a screenshot of my current scene, showing that I don't seem to be experiencing the problem you are.

screeny3

Cough_Yes, ponies_Cough (These are actually not my pony models/textures, but I am planning to make my own)

Anyway, because it seems important. I'm running on Windows 7 Home with nvidia GTX 650

from 3denginecpp.

pythoneer avatar pythoneer commented on June 23, 2024

@Colt-Zero what happens if you build from the latest git commit?

from 3denginecpp.

pythoneer avatar pythoneer commented on June 23, 2024

Benny merged a pullrequest "Merge pull request #7 from pseudosoftware/master
Fix a problem with Intel integrated graphic cards." which added two lines of code

glDrawBuffer(GL_NONE);
glReadBuffer(GL_NONE);

if i remove them, all seems to be working fine. In my case the code breaks at this point, can you check this @Zammalad ? The code is in texture.cpp at line 97-98

from 3denginecpp.

Colt-Zero avatar Colt-Zero commented on June 23, 2024

@pythoneer

Hmm.... Yes, there does seem to be an issue with the commit. Interesting, though. Because this commit seems to have some extra stuff in it that Benny has yet to cover in the latest video.

My code is only up to date as far as the video goes, so I'm not exactly up to date with the commit.

from 3denginecpp.

pythoneer avatar pythoneer commented on June 23, 2024

@Colt-Zero Benny added this Fix right after he committed the variance shadow code. The code is up to date with the video i guess, this fix has nothing to do with the material covered in the videos .

from 3denginecpp.

Colt-Zero avatar Colt-Zero commented on June 23, 2024

@pythoneer

I'm perhaps a little confused. Are you saying that all this extra filtering stuff that was not in the latest video not going to be a part of the video series?

from 3denginecpp.

pythoneer avatar pythoneer commented on June 23, 2024

@Colt-Zero NO! sorry if i'm confusing you :)

glDrawBuffer(GL_NONE);
glReadBuffer(GL_NONE);

is and will never be part of the video series – i guess
this is a commit (pull request merge) that was done right after the commit of the variance shadow code, which was part of the latest video – thus it is on par with the code you typed directly from the video. [except the little two line fix which broke the code]

from 3denginecpp.

Colt-Zero avatar Colt-Zero commented on June 23, 2024

@pythoneer

Ah.... I get you now. Well... Does that mean the issue has been solved? That fix did work for me, at least.
Perhaps we should get more opinions first

from 3denginecpp.

pythoneer avatar pythoneer commented on June 23, 2024

@Colt-Zero don't know – the code wasn't there for nothing. Like the commit message says: "Fix a problem with Intel integrated graphic cards." ... this was not intended to break the nvidia side and i guess it worked well with AMD cuz Benny merged it and he is using an AMD card if i recall correctly

from 3denginecpp.

Colt-Zero avatar Colt-Zero commented on June 23, 2024

@pythoneer

Ooch... One of these problems where it fixes one but breaks the other. It would probably be a bad move to make it check which kind of graphics card you have to determine whether the fix should be applied or not.

A non-universal fix for the problem such as a graphics card dependency could lead the way to future troubles.

from 3denginecpp.

pythoneer avatar pythoneer commented on June 23, 2024

At this Point we can't do much. Benny and pseudosoftware have to look at this since i don't really know what the fix is trying to do. maybe

glColorMask (GL_FALSE, GL_FALSE, GL_FALSE, GL_FALSE)

can help but i can only guess here :)

from 3denginecpp.

ForeverTPS avatar ForeverTPS commented on June 23, 2024

I can confirm that removal of

glDrawBuffer(GL_NONE);
glReadBuffer(GL_NONE);

resolves the issue on my system (nVidia 770, 337.50 Driver). As has been stated this needs to be looked at by Benny/pseudosoftware since they were handling that specific commit for an Intel fix.

from 3denginecpp.

BennyQBD avatar BennyQBD commented on June 23, 2024

Thanks for bringing this up everyone! For the time being, I've commented out those lines of code. I won't be adding them back until I receive more input from pseudosoftware.

from 3denginecpp.

pseudosoftware avatar pseudosoftware commented on June 23, 2024

I'll have a look.

from 3denginecpp.

DCubix avatar DCubix commented on June 23, 2024

Having the same problem with an intel processor #30

from 3denginecpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.