🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

No npm token specified.

An npm token must be created and set in the NPM_TOKEN environment variable on your CI environment.

Please make sure to create an npm token and to set it in the NPM_TOKEN environment variable on your CI environment. The token must allow to publish to the registry https://registry.npmjs.org/.

Good luck with your project ✨

Your semantic-release bot 📦🚀

I notice you dont disconnect the observer before deleting it. I dont think deleting the property will disconnect it for you.

I'd be very interested in seeing a CSS variable that supported the maintenance of an image's display ration before it was loaded. The goal there being to keep the content from jumping when the actual image is brought in.

I could see it being managed a number of different ways, but am not sure if it really aligns with the main goals of your component. Probably the most straight forward would be to use some sort of maintainRatio property, so that it would be available in your templating. This would allow for a secondary version of the styling that make the main element position: relative; padding-bottom: var(--ratio-padding); and the image position: absolute; top: 0; left: 0; for example. However, I'm not sure whether that starts to overcomplicate things.

I'm having trouble getting the fade functionality to perform correctly, and wondered if there was something special I need to do beyond setting the attribute?

From the code it looks like the "fade in" would be managed by the following code:

    img[intersecting] {
      opacity: 1;
    }

However, this doesn't guarantee that the image is available to display over the course of the image fade in. I'm fairly certain that you'd need to include something on the order of:

  loadImage() {
    let image = new Image();
    image.onload = () => {
      this.__img.src = this.src;
      requestAnimationFrame(() => {
        requestAnimationFrame(() => {
          this.__img.setAttribute('loaded','');
        });
      });
    };
    image.src = this.src;
  }

And call it from the intersecting setter like:

  set intersecting(intersecting) {
    this.__intersecting = intersecting;
    if (!this.__img) return;
    if (intersecting) {
      this.__img.setAttribute('intersecting', ''),
      this.loadImage();
    } else this.__img.removeAttribute('intersecting')
  }

It's possible I'm just completely on the wrong track, but if this is interesting I'd be happy to supply a PR.

It looks like you're missing coverage for when IntersectionObserver isn't available in the browser. Larger scale, it might be fun to have some sort of fallback to a polyfill, but I'd settle for it just loading the assets at runtime for now.

It looks like when you add the following to initIntersectionObserver:

    if (!window.IntersectionObserver) {
      this.setIntersecting(true);
      return;
    }

and swap the method order in connectedCallback, like so:

  connectedCallback() {
    this.attachShadow({mode: 'open'})
      .appendChild(getTemplate(this).content.cloneNode(true));
    this.initIntersectionObserver(this);

    this.placeholder = this.getAttribute('placeholder')
  }

That this functionality is achieved.

If that seems copacetic to you, I'm happy to submit a PR, or if there is a different approach, I'd be happy to take notes or wait for your our addition to support this area.

Thanks!

The new advice is to bring back width and height attrs so as to avoid layout recalculations as the page loads.

Let's add width and height attributes, and make a new index.js which feature-detects whether the browser supports native loading="lazy" and if so, loads a slimmer file.

Should close #4 also