benmneb / pts-converter Goto Github PK

Hi @benmneb,

first of all thank you for creating this new user interface! For https://pts.dhamma-dana.de/ I was already trying out a couple of months ago on migrating to it to your interface and better data (currently deployed here, with different frontend and data repos, but both are in a sort of "beta" state). I made some changes mostly regarding the data, e.g. updating the data format to a json api, updating the data itself, adding text excerpt preview and adding Dhp-A references to ancient-buddhist-texts.net .

Since we're now both already diverging in the frontend code and especially the data, how about we maintain the frontend repo together? It seems both your deployed version with Github pages and pts.dhamma-dana.de are being used by users, so I think it'd be good to merge in order to avoid confusion and inconsistencies between the two.

Please let me know what you think.

I noticed that some of the abbreviations are in lower case. This puts them out of order in the drop down:

As well, You have
Th and Thi for what "should" be Thag and Thig and also tha and thi instead of Tha-ap and Thi-ap.

From what I can tell, these values are only used as labels.

It appends ?ref=benmneb.github.io/pts-converter/ to the end of the ‘Read this sutta’ links, so I might look up S III 109 and it will form the following url (for English): https://suttacentral.net/sn22.84/en/sujato?layout=sidebyside&reference=main/pts&notes=asterisk&highlight=false&script=latin#pts-vp-pli3.109?ref=benmneb.github.io/pts-converter/

But that takes me to the start of SN 22.84

If I remove the ?ref=benmneb.github.io/pts-converter/ from the end of the url, then it scrolls to pts-vp-pli3.109 which is the behaviour that I was actually hoping for.

from https://discourse.suttacentral.net/t/suttacentral-2021-bug-reports-here/19609/215

You can contact me by sticking gmail after my username. They are the same.
I would like to add your tool to TPR.

I think that the Ud is completely new since you made the ap. Also now there is a complete Pali/English translation of the Snp by Bhante Sujato.

The Thag and Thig are older, so I'm not sure if there is a reason you don't include them.

Wonderful tool!