benkeen / rsv Goto Github PK

Hey there,

Been using RSV for a long long time; now using the jQuery version (now that I'm on a new project). Appreciated your work.

I found an interesting bug/feature in the jQuery version. Line 561-562.

It appears the customErrorHandler is always terminally called, irrespective of whether any errors are registered.

There are two problems;

1. If you have a customErrorHandler and a onCompleteHandler, I don't think the latter ever gets called.

2. The documentation (http://www.benjaminkeen.com/open-source-projects/smaller-projects/really-simple-validation-js/really-simple-validation-jquery-plugin/) specifies that customErrorHandler should 'always return false', which means that the form never validates and submits.

Problem 2 has a workaround, by adding this to any customErrorHandler...but it ought to be unnecessary. Or else documented! :)
if (errorInfo.length === 0 ) { return true; }

Our javascript error messages disappear immediately after appearing briefly in Chrome. Do you have a solution for this? This appears to be a Chrome issue. The error message pop-ups function as expect in Firefox, where they stay up until they are acknowledged and dismissed.

Thanks.

Hi,

I am a rooky on github, so maybe this is off topic, but I do not know how else to conatct you. The demo page seems to be off line.

http://www.benjaminkeen.com/open-source-projects/smaller-projects/really-simple-validation-js/really-simple-validation-standalone-version/experiments/rsv/standalone/