Hi Ben,

Thanks for the great tool! Simple cross-platform demangling from python without dependencies.
We would like to use this package, but as can be seen on the files list in PyPi, there are no Windows C-python 3.7 wheels available.

I think this is due to the version of cibuildwheel that is used in appveyor.yml. Since version 0.9.3 it has support for python 3.7 on Windows.

Background Info

We've recently come across a binary with what appears to be a malformed symbol name that would trigger the following exception:

thread '<unnamed>' panicked at 'a Display implementation returned an error unexpectedly: Error', /rustc/897e37553bba8b42751c67658967889d11ecd120/library/alloc/src/string.rs:2511:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
pyo3_runtime.PanicException: a Display implementation returned an error unexpectedly: Error

Reproduction

You can reproduce it with the Python lines below:

from cpp_demangle import demangle

demangle('_ZSt11make_sharedI16group_record_msgIRjR22mcast_addr_record_typeR12addr_storageSt3setI6sourceSt4lessIS7_ESaIS7_EE18group_mem_protocolEESt10shared_ptrIT_EDpOT0_')

This symbol name is really close to the other one, but this time it works:

from cpp_demangle import demangle

demangle('_ZSt11make_sharedI16group_record_msgJRjR22mcast_addr_record_typeR12addr_storageSt3setI6sourceSt4lessIS7_ESaIS7_EE18group_mem_protocolEESt10shared_ptrIT_EDpOT0_')

The only difference is the character at index 38 (a J in the valid one, a I in the invalid one, which looks like a bit flip. I'm currently investigating to see if it's the ELF parser or the file that got flipped.

Recommendation

Would it be possible to raise a ValueError instead of the PanicException on such cases ?

So this code

Is throwing a value error on these function names:
'_main', 'ctor_0', 'ctor_1', 'ctor_2', 'ctor_3', 'ctor_4', 'ctor_5', 'ctor_6', 'ctor_7', 'ctor_8', 'ctor_9', 'ctor_10', 'ctor_11', 'ctor_12', 'ctor_13', 'ctor_14', 'ctor_15', 'ctor_16', 'ctor_17', 'ctor_18', 'ctor_19', 'ctor_20', 'ctor_21', 'ctor_22', 'ctor_23', 'ctor_24', 'ctor_25', 'ctor_26'
I'm not entirely sure why c++ constructors are getting numbered like this.
This is my work around:

functionName = f.name
try:
    functionName = demangle(f.name)
except ValueError:
    allFailedFunctionNames.append(f.name)