bendickens / trails Goto Github PK

Depending on the GDAL version which is installed, the import statement for ogr and gdal (e.g. in extract.py) fails.
Recommened import from https://pypi.org/project/GDAL/ website:
from osgeo import gdal & from osgeo import ogr or

>>> try:
...     from osgeo import gdal
... except ImportError:
...     import gdal

Several functions call the function nearest_edge with 2 kwargs (point, edges), but the function requires 3 (geom, df, sindex), leading to an error.

Examples:

assert G.clusters(mode='strong')._len == 1

I have come across a few instances where I was not sure about the required type of geometries, and / or whether this is consistent throughout the module.

For instance, the following function seems to take pygeos geometries from a network instance as inputs, but applies shapely interpolation functions:

E.g., nearest_point_on_line is called by the following function:

I assume a network instance with shapely-based dataframes would work for this function combo, but not for others such as merge_multilinestrings or find_roundabouts, which explicitly apply pygeos functions.

Perhaps this is also intended, and the individual functions are not supposed to be taken out of a standard "work-flow"?