benbalter / retlab Goto Github PK

This line has the logic:

Fix: either give all nav pages a permalink, or change it to something like:

<li class="nav-item{% if nav_page.permalink and page.permalink == nav_page.permalink %} active{% endif %}">

It looks like the .gem file is empty:

$  wget https://rubygems.org/downloads/retlab-0.1.0.gem                                                                                                                                                                                                                                       
--2016-08-17 15:57:19--  https://rubygems.org/downloads/retlab-0.1.0.gem
Resolving rubygems.org... 54.186.104.15
Connecting to rubygems.org|54.186.104.15|:443... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
Location: https://rubygems.global.ssl.fastly.net/gems/retlab-0.1.0.gem [following]
--2016-08-17 15:57:20--  https://rubygems.global.ssl.fastly.net/gems/retlab-0.1.0.gem
Resolving rubygems.global.ssl.fastly.net... 151.101.44.249
Connecting to rubygems.global.ssl.fastly.net|151.101.44.249|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 4608 (4.5K) [application/octet-stream]
Saving to: 'retlab-0.1.0.gem'

retlab-0.1.0.gem                                                               
100%[====================================================================================================================================================================================================>]   4.50K  --.-KB/s    in 0.003s

2016-08-17 15:57:21 (1.49 MB/s) - 'retlab-0.1.0.gem' saved [4608/4608]

$ gem unpack retlab-0.1.0.gem                                                                                                                                                                                                                                                                
Unpacked gem: '/Users/jaiken/retlab-0.1.0'

$ cd retlab-0.1.0        

$ ls -lart
total 0
drwxr-xr-x    2 jaiken  staff    68 Aug 17 15:57 .
drwxr-xr-x+ 175 jaiken  staff  5950 Aug 17 15:57 ..

I'm not sure how to chase this down yet, but {{ site.github.build_revision }} isn't populating at least for sites that use this theme (maybe all themes?) when my site is built on github, leading to empty ?v= strings.

This means that cache-busting isn't working.

It's happening on ben.balter.com, too. For example:

Codeblocks in dark mode look washed out, like this:

Because the github theme doesn't handle switching the codeblock background color to work for dark mode.

Here's a bandaid approach that works, idk if best practice though. I replaced highlighting.scss with media imports for two rougify styles that I added to the /sass directory: base16.monokai.dark and github

# sass/_highlighting.scss
@media (prefers-color-scheme: dark) {
  @import 'base16.monokai.dark';
}

@media (prefers-color-scheme: light) {
  @import 'github';
}

Describe the bug

Project Page ●●● .github.io/●●● cannot display the image of the top page

Steps to reproduce the behavior

When you publish it on Project Page ●●●.github.io/●●●, you can check it immediately on the top page.

Expected behavior

image.jpg is fixed in /assets/css/style.css.

/assets/css/style.css

.hero-unit{background-image:url("/assets/img/header.jpg");background-size:cover;background-position:top left;height:400px}.

So for the project page ●●●.github.io/project/ , It is located at /project/assets/img/header.jpg

Screenshots

I actually used it in Project Pages and ran into this issue:

I would really appreciate an update to Font Awesome libraries. I am particularly interested in the Mastodon icon. See https://fontawesome.com/icons/mastodon

It may be as simple as updating the NodeJS configuration.

My alternatives include forking the theme. I’d rather not since I am not a front-end developer.

Other updates are welcome as well. I see automated dependency update pull requests. A good test suite should allow for safe and frequent updates.

Thank you.

Not necessarily a bad thing, but it is an undocumented thing.

Commit 5a8f638 dropped google_analytics, but _config.yml still includes ga_username. Should an if-block be added back in to _layouts/default.html, or should ga_username be removed from the config?

Hi, is it possible for the title to avoid appearing twice when you add it after the # at the top of a .md page?

Hi @benbalter,

I followed the instructions in the README but the site won't build with Jekyll 3.2.1 under Mac OS X.
Here is the error message:

Build Warning: Layout 'post' requested in _posts/2016-08-03-welcome-to-jekyll.markdown does not exist.

No build problem if I replace retlab with minima in _config.yml.

Running the http://wave.webaim.org/ tool on my site using an unmodified retlab theme gives an accessibility error for the lack of any visible text or alternate description for the feed.xml link.