Giter Club home page Giter Club logo

Comments (1)

davwheat avatar davwheat commented on June 8, 2024

I'm not totally sure why this happens.

The Regex used in generator.rb seem to match fine when testing them on Regexr.

I don't know Ruby, so I'd be lost trying to figure out what's going on here!

I'm assuming its an issue with this section:

jekyll-relative-links/lib/jekyll-relative-links/generator.rb

Lines 36 to 46 in 4449dba

documents = site.pages
documents = site.pages + site.docs_to_write if collections?
documents.each do |document|
next unless markdown_extension?(document.extname)
next if document.is_a?(Jekyll::StaticFile)
next if excluded?(document)
replace_relative_links!(document)
end
end

The converter probably won't find the document as it will be stored with a space, rather than %20.

Would it be possible to use CGI.unescape to ensure the file is URI decoded? Or would this be better fixed upstream? (I'd vote no on that, as there might be a weird edge case where someone has a file with % signs or something weird)

from jekyll-relative-links.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.