Giter Club home page Giter Club logo

Comments (15)

aaronmw avatar aaronmw commented on June 24, 2024 2

Still relevant. Just lost a bunch of hours trying to pin down our issues.

from jekyll-relative-links.

hasheddan avatar hasheddan commented on June 24, 2024 1

Some examples with the commonmark tool: https://spec.commonmark.org/dingus/?text=%5Ba%20cool%0Alink%5D(%2Furl)%0A%0A%5Banother%20cool%0Alink%5D(%0A%2Furl)%0A%0A%5B%0Aand%20another%20one%0A%5D(%2Furl)%0A

from jekyll-relative-links.

thaJeztah avatar thaJeztah commented on June 24, 2024 1

👍 just ran into this issue when debugging why some links were not handled correctly, but others did, and came to the same conclusion that it was due to those links being wrapped. I would prefer wrapped links to work, as it's quite commonly used.

from jekyll-relative-links.

hasheddan avatar hasheddan commented on June 24, 2024

@benbalter is this as simple as adding /m option to INLINE_LINK_REGEX (and REFERENCE_LINK_REGEX if we want that also) to enable multi-line mode?

INLINE_LINK_REGEX = %r!\[#{LINK_TEXT_REGEX}\]\(([^\)]+?)#{FRAG_AND_TITLE_REGEX}\)!.freeze

from jekyll-relative-links.

benbalter avatar benbalter commented on June 24, 2024

Based on https://spec.commonmark.org/, I don't believe links can have new lines in them. Do you read the spec otherwise?

from jekyll-relative-links.

hasheddan avatar hasheddan commented on June 24, 2024

@benbalter thank you for the quick response :) You can have breaks in an in-line markdown link as long as it does not break the actual link text. Examples: https://gist.github.com/hasheddan/0fcebadaa82f29fd51ab0bcd36d193dd

Gist
GitHub Gist: instantly share code, notes, and snippets.

from jekyll-relative-links.

hasheddan avatar hasheddan commented on June 24, 2024

@benbalter I am happy to make this update 👍 I don't work with Ruby too frequently, any tips on building / testing this project?

from jekyll-relative-links.

hasheddan avatar hasheddan commented on June 24, 2024

@benbalter just following up here :) anything I can do to help?

from jekyll-relative-links.

stale avatar stale commented on June 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from jekyll-relative-links.

hasheddan avatar hasheddan commented on June 24, 2024

@benbalter i would love to help get this fixed, any chance we could reopen this?

from jekyll-relative-links.

stale avatar stale commented on June 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from jekyll-relative-links.

thaJeztah avatar thaJeztah commented on June 24, 2024

still relevant

from jekyll-relative-links.

stale avatar stale commented on June 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from jekyll-relative-links.

thesofakillers avatar thesofakillers commented on June 24, 2024

still relevant

from jekyll-relative-links.

stale avatar stale commented on June 24, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from jekyll-relative-links.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.