Giter Club home page Giter Club logo

php-graphql-example's People

Contributors

benawad avatar heithemmoumni avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar

Forkers

binary64 nightghos santosh-td brenowii luisfc edenreich aduange heithemmoumni cuongdinhngo floriantsuala kasinico jerrynoritake

php-graphql-example's Issues

Fix DataLoader on field resolver

Hi!

First off; really big thanks! Your Youtube videos about GraphQL and this repo really inspired me. We've implemented GraphQL at my work using PHP and I had a task of solving the n+1 problem. Webonyx repo doesn't really help but this did the trick.

I did a similar implementation using Slim Framework and I put on SQL logging. I noticed that this line does not work as intended

php-graphql-example/resolvers.php

Line 8 in dc39fa5

return DataLoader::await($context['petLoader']->load($root['id']));

The await() seems to solve a promised PER $root['id'] meaning it visits the database fetching a result each time load() receives a new value (that is not cached). I did a demo with books and authors and noticed my SQL log looked like this:

{
  "1": {
    "sql": "SELECT * FROM book",
    "params": [],
    "types": [],
    "executionMS": 0.0005571842193603516
  },
  "2": {
    "sql": "SELECT id, `name` FROM author WHERE id in (?)",
    "params": [
      "1"
    ],
    "types": [],
    "executionMS": 0.0009350776672363281
  },
  "3": {
    "sql": "SELECT id, `name` FROM author WHERE id in (?)",
    "params": [
      "2"
    ],
    "types": [],
    "executionMS": 0.0002930164337158203
  },
  "4": {
    "sql": "SELECT id, `name` FROM author WHERE id in (?)",
    "params": [
      "3"
    ],
    "types": [],
    "executionMS": 0.00022983551025390625
  }
}

What solved it was removing the await() as apparently GraphQL-PHP already handles promises:

return $context['loaders']['author']->load($book['author_id']);

Now my SQL log looks like this:

{
  "1": {
    "sql": "SELECT * FROM book",
    "params": [],
    "types": [],
    "executionMS": 0.00038886070251464844
  },
  "2": {
    "sql": "SELECT id, `name` FROM author WHERE id in (?)",
    "params": [
      [
        "1",
        "2",
        "3"
      ]
    ],
    "types": [
      101
    ],
    "executionMS": 0.0014162063598632812
  }
}

You should test that out and fix the line!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.