beltex / libsmc Goto Github PK

• See beltex/SMCKit#2 for discussion
• Can give the option for auth via AuthorizationExecuteWithPrivileges() for convenience as it still seems to be available via C

• Use of test framework TBD
  • https://github.com/vmg/clar

In smc.c, write_smc() function, this code:

    // Set data to write
    memcpy(outputStruct.bytes, result_smc->data, sizeof(result_smc->data));

should actually be:

    memcpy(inputStruct.bytes, result_smc->data, sizeof(result_smc->data));

Otherwise, you're always writing 0.

In the Swift version, there's an uint16_t padding between keyInfo and result: https://github.com/beltex/SMCKit/blob/v0.0.13/SMCKit/SMC.swift#L473-L475

That seems to be missing in the C version:
https://github.com/beltex/libsmc/blob/master/src/smc.c#L193-L194

I believe a shift sign has been inverted rendering the conversion incorrect.

static unsigned int from_fpe2(uint8_t data[32])
{
    unsigned int ans = 0;
    
    // Data type for fan calls - fpe2
    // This is assumend to mean floating point, with 2 exponent bits
    // http://stackoverflow.com/questions/22160746/fpe2-and-sp78-data-types
    ans += data[0] << 6;
    ans += data[1] << 2;

    return ans;
}

Should be:

    ans += data[1] >> 2;

(+ typo "assumend" -> "assumed")

Can do a tiny PR if it helps.

• Javadoc like
• Possibilities: Doxygen, Docurium

• For convenience
• Possibly use CMake