beingmohit / browser-playerctl Goto Github PK

OS: Manjaro
Browser: Chromium 75 + 76
playerctl: 2.0.2-2
browser-playerctl: 0.2 (from webstore)
all other functions seem to work

Great extension, it's honestly very helpful!

Would be awesome if you could add support for https://music.youtube.com/ if you have the time.

Thanks!

1st let me say I love the idea of a MPRIS browser extension.

I've tested your extension against my GNOME Shell extension and it seems to work rather well with the exception that you can't raise the player (the browser in this case) because you set CanRasie to false and don't have a Raise method.

It would be awesome if raising would raise the browser and switch to the appropriate tab.

It would be also nice if your extension downloaded the fav icon of the "players" to ~/.local/share/icons so MPRIS widgets could find them. Basically if you set the DesktopEntry prop to the name of the fav icon my extension should be able to find the icon in ~/.local/share/icons

Some, maybe all controls are currently looked up in the DOM via their aria-label: $('[aria-label="Pause"]' $('[aria-label="Play"]', however there are locale dependent.

I have begun working on this in https://github.com/derflocki/browser-playerctl/tree/issue-7-make-google-play-music-work-independent-of-the-locale

User's can't legally use this project without an open source license.
Please read this document for more information

This is great! Many thanks. Any chance of adding support for Pandora?

Spotify is not working in other languages because titles (used by extension/providers/spotify.js) are localized.

For example, in Italian it is Avanti and not Next:
<button class="control-button spoticon-skip-forward-16" title="Avanti"></button>

It is better to base on other properties (maybe the class).