Comments (5)
I found the issue, it's due to this block of code:
// If there's no element after 100ms, it didn't work. This check is for Safari 5.1
// which fails to fire a `webkitfullscreenerror` if the request wasn't from a user
// action.
setTimeout(function() {
if (!document[fn.element]) {
callOnError(iframe ? 'not_enabled' : 'not_allowed', element);
}
}, 100);
In my own project, I've wrapped this in a User Agent test: navigator.userAgent.indexOf("Safari") > -1
from bigscreen.
Thanks for the detailed report! Seems like this is the same as #17. I generally dislike having to do UA detection, but I think it's the least bad way to handle it. Do you mind submitting a pull request with that change?
from bigscreen.
As for the tests, I'm happy to review a PR with any changes, but I want to note that I've started on a new major version that will be promise-based to match the latest spec. I definitely want to get better test coverage in actual browsers with the new version.
from bigscreen.
Yeah, I agree on avoiding UA strings -- but for a hack I thought it might be okay. If I think of something better I'll let you know.
I'll submit a PR right away. Cool stuff about the new major version, I'll keep an eye out for it.
from bigscreen.
How this issue can be avoided?
Because i'm also having same issue .onenter and .onexit not working on Firefox, what to do
from bigscreen.
Related Issues (20)
- Foundation 5 (with Orbit Slider) versus BigScreen
- Modern Chrome support? HOT 1
- Demo doesn't work on chrome latest HOT 2
- BigScreen.onexit method not working on latest version of firefox 43.0b4 HOT 1
- BigScreen.Enabled Not Correctly Set in Safari 5.1.x HOT 5
- Cannot fullscreen video in external iframe on iOS HOT 1
- Webkit issues with fullscreen inside a frameset HOT 2
- Webkit bug exiting fullscreen from within an iframe.
- Not working on nested iframe HOT 2
- CDN link not working HOT 1
- Demo does not work on Chrome 60+ on Android HOT 5
- Bigscreen conflicts with z-index
- Gray screen of death in Safari when fullscreening multiple times HOT 5
- Please allow other developers to pick up your work and to continue the BigScreen story
- BigScreen.element needs to check for all <video>s HOT 1
- component.json to bower.json
- Your demos no longer work in modern browsers HOT 1
- Iframe > Set Fullscreen Background Color HOT 1
- v2.0.4 throwing "addEventListener" error in IE8 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bigscreen.