Giter Club home page Giter Club logo

Comments (5)

terraboops avatar terraboops commented on June 9, 2024

I found the issue, it's due to this block of code:

// If there's no element after 100ms, it didn't work. This check is for Safari 5.1
// which fails to fire a `webkitfullscreenerror` if the request wasn't from a user
// action.
setTimeout(function() {
    if (!document[fn.element]) {
        callOnError(iframe ? 'not_enabled' : 'not_allowed', element);
    }
}, 100);

In my own project, I've wrapped this in a User Agent test: navigator.userAgent.indexOf("Safari") > -1

from bigscreen.

bdougherty avatar bdougherty commented on June 9, 2024

Thanks for the detailed report! Seems like this is the same as #17. I generally dislike having to do UA detection, but I think it's the least bad way to handle it. Do you mind submitting a pull request with that change?

from bigscreen.

bdougherty avatar bdougherty commented on June 9, 2024

As for the tests, I'm happy to review a PR with any changes, but I want to note that I've started on a new major version that will be promise-based to match the latest spec. I definitely want to get better test coverage in actual browsers with the new version.

from bigscreen.

terraboops avatar terraboops commented on June 9, 2024

Yeah, I agree on avoiding UA strings -- but for a hack I thought it might be okay. If I think of something better I'll let you know.

I'll submit a PR right away. Cool stuff about the new major version, I'll keep an eye out for it.

from bigscreen.

uc-ach avatar uc-ach commented on June 9, 2024

How this issue can be avoided?
Because i'm also having same issue .onenter and .onexit not working on Firefox, what to do

from bigscreen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.