bdbcat / o-charts_pi Goto Github PK

Win10
This applies to two canvas mode for o-charts_pi. No problem in single canvas mode.
Using o-charts the "Lights" (L) toggle needs to be active on both canvases to show the object query or light sectors for a light house.
If "Lights" is on at only one canvas the lights are shown on that canvas but neither the lights Object query nor cursor controlled sectors are shown for that canvas until I also select "Lights" on the other canvas.

If I compare to pure ENC charts (OCPN core) both canvases works independently of the other in this matter. There I can have "Lights" switched off at one canvas and switched on at the other. Then lights object query and light sectors are shown at the other canvas.

Hi David
I've been a rpm packager for opencpn and its plugins for some years
I'm still using opencpn 5.24 because I waited for opencpn 5.6.2 to be published before packaging it
I know that you are promoting the Plugin Manager which is a real improvement

But for other distributions than debian or ubuntu the only way to use opencpn and its Plugin Manager is to work inside the flatpak sandbox (which is heavy : I have been testing it for 8 months and I had to download 2 Go of updates for flatpak itself ! to cooperate with Rick Gleason)

My rpm install was more safe than flatpak and I am still using it until the issues inside flatpak are closed

Two problems appeared since o-chats_pi replaces and obsoletes oernc_pi and oesenc_pi
opencpn 5.2.4 can't use anymore the charts paid from o-charts.org and complains it needs o-charts_pi... that's not very user friendly !

and worse : I couldn't build a package for o-chats_pi neither for opencpn 5.2.4 nor for opencpn 5.6.2
since you emptied the PluginPackage.cmake
(besides all the others that's the only plugin for which I can't build a rpm package anymore, When I could still build packages for oernc_pi and oesenc_pi.)

You allow to build packages of o-charts_pi for Windows, MacOS and Debian or Ubuntu but not anymore for rpm based distro (Fedora, RedHat, OpenSuse, Mageia, OpenMandriva, PCLinuxOS...) that could use the rpms I build

Nevertheless I tried to use a workaround : I built a tarball (cmake make tarball) and cherry picked in the app directory the binary, the libraries and the data needed and built a rpm with them
But, the o-charts_pi installed this way induces a segfault inside opencpn 5.6.2 ...

I know you adjusted digits spacing for ENC.
The same may be needed for o-charts. Both for digits and comma separation.
This is about Win scaled display. Win "normal" 100% scale is no problem. There are also o-charts soundings correct separated.

See pictures from Win scaled 175%. Red = pure ENC. Blue is o-charts.

O-charts provide far too large font sizes on my Mac, making charts illegible at certain scales. CM93 and ENC (S67) do not suffer from this problem.

Version is 1.21/arm32. There's a segfault when running oexserverd and /sys/bus/usb/devices is empty, but works ok if I attach a usb device before running it. Attached strace logs for both cases.
strace_logs.zip

OS: Windows 11 Enterpirse
OpenCpn Verison: OpenCPN version 5.8.4-0+1637c28
o-charts vesrion: o-charts-2.0.2.1-msvc-wx32-10-tarball/versions/2.0.2.1/o-charts-2.0.2.1_msvc-wx32-10-win32.tar.gz

On a fresh install of open cpn after installing the ocharts plugin, i can logon but the chart install hangs and never returns.

Video example: https://drive.google.com/file/d/1uWVCIBC6mmfmPo8IWsKzMsMRoXJv0W_B/view?usp=sharing
opencpn.log

I notice a few things. The system name is Test1, even before i have set anything. And the dialog to set a new name pops up multiple times. In the o-charts plugin settings the box for 'reset system name' is greyed out.

The log seems to indicate there is some permissions issue with the fpr file. I've tried to click the 'create fingerprint` button several times manually and that doesn't seem to help either way. I also tired running open cpn as administrator and that didn't make it.

I'm not sure if it's an issue with o-charts or the plugin manager, but I can't install the o-charts plugin, I've got a checksum error.

I'm on windows, with Open CPN 5.6.2, and I've tried a clean install 2 times
Message in logs :
17:11:15.088 MESSAGE download_mgr.cpp:99 Checksum fail on o-charts, tarball: sha256:9385814ec13755283b2b8e34fa1470123c5c6b87a9e12e482743171046e33545, metadata: sha256:17996e0597857bd7d36cb4187915ae8670360d44accc2c84eb6000ac7d7801cd

Hi,

I posted a bug report on CruisersForum following the recommendation of O-Charts.org support, and I re-post here, because it's related to o-charts_pi.

Ref. https://www.cruisersforum.com/forums/f134/opencpn-version-5-8-4-released-276788-12.html#post3875618

Hello,

I experience stability issues with OpenCPN and I found many reports in this thread very close to my case.

I will describe here a reproducible case, a bit of context and some notes, but my main question is about the logging. I wanted to enable extra logging to try to investigate this issue by myself.

I tried to set DebugOpenGL=1 but I didn't get any interesting logs before the crash.

I conducted my test on both Linux and Windows. On Linux I also recompiled the binaries directly from the sources but it don't change anything. The interesting point is that I got the same issue on both systems (Linux/Windows), and I have a reproducible case at a specific GPS location, using o-chart plugin with Canada Atlantic Coast (oeuSENC-CAac). Coordinate:
51° 05.3621' N, 058° 44.1917' W

When you zoom in at this specific spot, the application crashes (again, on both Linux and Windows, so I don't think it's related to any OS, library or hardware driver).

I also tried to avoid OpenGL hardware acceleration, by using software GL, but I got the same issue.

The only message I got during the crash is:
Job 1, 'opencpn' terminated by signal SIGSEGV (Address boundary error)

It looks like a buffer allocation error, typical with C/C++.

I started to investigate the core-dump, and a quick analysis pointed to a call on o-charts plugin. The last entry (#0) below shows a call on the RenderLSLegacy function.

Core was generated by `/usr/bin/opencpn'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000727d407d242a in s52plib::RenderLSLegacy(_ObjRazRules*, _Rules*) ()
   from /usr/lib/opencpn/libo-charts_pi.so

Code ref:
https://github.com/bdbcat/o-charts_pi/blob/master/libs/s52plib/src/s52plib.cpp#L4064
(note: s52plib is not a remote repo link, it's a local copy)

There are some issues related to a similar issue here:
OpenCPN/OpenCPN#3437
But I can reproduce this case with or without OpenGL.

The upper function related is: eSENCChart::DCRenderLPB(wxMemoryDC&, PlugIn_ViewPort const&, wxRect*)

Code ref:
https://github.com/bdbcat/o-charts_pi/blob/master/src/eSENCChart.cpp#L6245

Below, a part of the stack-trace.

#0  0x0000727d407d242a in s52plib::RenderLSLegacy(_ObjRazRules*, _Rules*) ()
    at /usr/lib/opencpn/libo-charts_pi.so
#1  0x0000727d407dbbcd in s52plib::DoRenderObject(wxDC*, _ObjRazRules*) ()
    at /usr/lib/opencpn/libo-charts_pi.so
#2  0x0000727d406b8e47 in eSENCChart::DCRenderLPB(wxMemoryDC&, PlugIn_ViewPort const&, wxRect*) () at /usr/lib/opencpn/libo-charts_pi.so
#3  0x0000727d406b93a2 in eSENCChart::DCRenderRect(wxMemoryDC&, PlugIn_ViewPort const&, wxRect*) () at /usr/lib/opencpn/libo-charts_pi.so
#4  0x0000727d406d500f in eSENCChart::DoRenderViewOnDC(wxMemoryDC&, PlugIn_ViewPort const&, bool) () at /usr/lib/opencpn/libo-charts_pi.so
#5  0x0000727d406d5db1 in eSENCChart::RenderRegionView(PlugIn_ViewPort const&, wxRegion const&) () at /usr/lib/opencpn/libo-charts_pi.so
#6  0x0000727d406b4bc9 in eSENCChart::RenderRegionViewOnDCNoText(PlugIn_ViewPort const&, wxRegion const&) () at /usr/lib/opencpn/libo-charts_pi.so
#7  0x000063355427f963 in ChartPlugInWrapper::RenderRegionViewOnDCNoText(wxMemoryDC&, ViewPort const&, OCPNRegion const&) ()
#8  0x00006335542e11b1 in Quilt::DoRenderQuiltRegionViewOnDC(wxMemoryDC&, ViewPort&, OCPNRegion&) ()

Some additional information on my setup:

Hardware (standard PC computer, with dual-boot Linux/Windows)

• CPU Intel i7-5820K, x86_64, 32GB
• GFX card NVidia GeForce RTX 2080
• Dongle used for o-charts (SG-Lock USB Key)

OS (the Linux part)

• ArchLinux (up to date, weekly)
• Linux 6.7.6-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 23 Feb 2024 16:31:48 +0000 x86_64 GNU/Linux

OpenCPN version: v5.8.4

• https://github.com/OpenCPN/OpenCPN/releases/tag/Release_5.8.4

o-charts plugin version: v2.0.3.1

• https://github.com/bdbcat/o-charts_pi/releases/tag/2.0.3.1

Note: s52plib is obviously imported from OpenCPN, and I will try to check the diff between this local version and the latest version to ensure this bug was not already fixed.

Good day,
Guenael

Hi,
Trying to build and install the package on Debian Bullseye. All seems to go well.

$ cd o-charts_pi
$ cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo ..
$ make pkg

generates the package
o-charts-0.9.0.32-+82a4468_debian-11-x86_64.deb

But if I try to install it with
sudo dpkg -i o-charts-0.9.0.32-+82a4468_debian-11-x86_64.deb

I get the following error

skipper@boat:~/o-charts_pi/build$ sudo dpkg -i o-charts-0.9.0.32-+82a4468_debian-11-x86_64.deb
dpkg: warning: parsing file '/var/lib/dpkg/tmp.ci/control' near line 1:
'x86_64' is not a valid architecture name in 'Architecture' field: character '_' not allowed (only letters, digits and characters '-')
dpkg: error processing archive o-charts-0.9.0.32-+82a4468_debian-11-x86_64.deb (--install):
package architecture (x86_64) does not match system (amd64)
Errors were encountered while processing:
o-charts-0.9.0.32-+82a4468_debian-11-x86_64.deb

Hi,

I'm trying to build o-charts on ubuntu 20.04

mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release ../
make pkg
Scanning dependencies of target pkg-conf
-- Cmake version: 3.16.3.
-- Building: pkg
-- Selected upload repository: david-register/ocpn-plugins-unstable
-- *** Staging to build o-charts_pi ***
-- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") 
-- Found OpenGL: /usr/lib/x86_64-linux-gnu/libOpenGL.so   
-- Found wxWidgets: -L/usr/lib/x86_64-linux-gnu;-pthread;;;-lwx_baseu-3.0;-lwx_gtk3u_core-3.0;-lwx_baseu_net-3.0;-lwx_baseu_xml-3.0;-lwx_gtk3u_html-3.0;-lwx_gtk3u_adv-3.0 (found version "3.0.4") 
-- Found CURL: /usr/lib/x86_64-linux-gnu/libcurl.so (found version "7.68.0")  
-- PluginLocalization...GETTEXT_XGETTEXT_EXECUTABLE: /usr/bin/xgettext
-- Using bundled tinyxml
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11") 
CMake Error at libs/oeserverd/CMakeLists.txt:31 (configure_file):
  configure_file Problem configuring file


CMake Error at libs/oeserverd/CMakeLists.txt:35 (configure_file):
  configure_file Problem configuring file


-- Configuring incomplete, errors occurred!
See also "/home/oleg/tmp/o-charts_pi/build/CMakeFiles/CMakeOutput.log".
make[3]: *** [CMakeFiles/pkg-conf.dir/build.make:57: pkg-conf] Error 1
make[2]: *** [CMakeFiles/Makefile2:135: CMakeFiles/pkg-conf.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:412: CMakeFiles/pkg.dir/rule] Error 2
make: *** [Makefile:261: pkg] Error 2

regarding
free-x

On debian 11. bullseye:

• Build from source using tag Release_5.8.4
• Update catalog
• Install plugin
• watch broken linkage:

al@bullseye:~$ opencpn-cmd update-catalog
al@bullseye:~$ opencpn-cmd install-plugin o-charts
al@bullseye:~$ opencpn-cmd print-abi
debian-x86_64:11
al@bullseye:~$ opencpn-cmd list-plugins | grep o-charts
Error: /home/al/.local/lib/opencpn/libo-charts_pi.so: undefined symbol: _ZTI10wxCurlHTTP
o-charts                 2.0.0.58

I have two Debian 12 systems running OpenCPN 5.8.4 with o-charts plugin 2.0.1.9. One system works perfectly with both a dongle and a simple fingerprint.

The other system fails to see the dongle (it does show in the system) and will not accept the username/password when I try to refresh the charts (even though the list of charts show).

I've completely deleted the OpenCPN settings and reset everything and still have the same issue.

The two errors I get are
"USB key dongle not detected"

and (when trying to refresh the chart list)
"o-Charts shop interface error 3f void password"

Some error messages are unclear (or my english is not good enough).

When the system gives "void password" this translates to either "empty", "useless" or "undefined" in my opinion.
How can this matter arise?
Lack of internet connection?

If it happens when either password or name is not supplied I could guess, but when a password has been supplied?
Is it possible the password contains some illegal characters?

Is there a list of possible errors with a explanation what to look for?

On Rpi5 Bookworm o-charts_pi is not listed.
arm64:11 and more are there but not compatible.

Hi David
I'm still using an old but still valid x86 laptop with linux (some distributions such as Debian or Mageia still provide 32bits OS ...)

Flatpak itself is too heavy to use and update on this old laptop ... that's the reason why I prefer to install packages (I could do this for oesenc and oernc with opencpn 5.2.4)

I build packages of opencpn 5.6.2 and its plugins for Mageia (and could still build one for opencpn-o-charts-plugin using a workaround based on making a tarball and picking what I need in the build tree )
I was able to do this for armf aarch64 and x86-64

but the 32bits closed source binary and library are missing for linux (when they exist for arm32bits)

Would you please provide them in a github.com/bdbcat/o-charts_pi/tree/master/libs/oeserverd/linux new directory
besides your existing
github.com/bdbcat/o-charts_pi/tree/master/libs/oeserverd/linux64
github.com/bdbcat/o-charts_pi/tree/master/libs/oeserverd/linuxarm
github.com/bdbcat/o-charts_pi/tree/master/libs/oeserverd/linuxarm64

I get a "checksum error" when trying to install o-chart plugin.
OS is win11,
Opencpn is the latest release (5.8.4-0)
Plugin catalog is master and updated
O-charts plugin is 2.0.0.57
I'm not a coder and not sure it's the place to report bugs.
Anyone can help?

Hey,
I recently encountered a problem with missing charts due to a temporary storage (/run/user/1000) being too small during install causing the unzipping of the charts to be interrupted.
The installation process seemed successful, it showed even the "validating download" message and gave no error. On the first look the charts were all there but when you zoomed in on certain spots you could discover missing charts.

This is a unlucky and potentially dangerous situation, therefore I would like to suggest:
Add the existing "Validate chart set" routine to the installation process and warn the user in case the chart set was not installed completely for some reason.

Many thanks!

The problem: with the old oesenc pluging the charts worked fine.
With the new plugin I can login, but I'm forced to give a system ID and the USB dongle is not found.

Closing the system (arm64, native) and starting opencpn/flatpak a native the USB dongle is visible and the charts work.
The sglock rule in udev did not change between stopping opencpn and starting flatpak,

Reason to want a native version of the plugin is because it is easier to work with unsupported (old) plugins.

USB dongle version 1.0.0.
The sglock rule in udev did not change between stopping opencpn and starting flatpak,
'$ /usr/local/bin/oeserverd -s
'1
'$ /usr/local/bin/oexserverd -s
'0
'$ .var/app/org.opencpn.OpenCPN/bin/oexserverd -s
'1

Hi @bdbcat ,

while building plugin for ARM64 i noticed that blob has wrong architecture. It is ARMHF ( 32bit) instead of AARCH64/ARM64

pi@xnav:~/tmp/o-charts_pi $ file libs/oeserverd/linuxarm64/oexserverd 
libs/oeserverd/linuxarm64/oexserverd: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.2.0, BuildID[sha1]=42000dca2db7c850b4212c9b909813ad17a22e69, stripped

Regards
free-x

Hi,

As a follow up to OpenCPN/OpenCPN#2273 (comment) , I still have the issue of connecting to ocharts.

My raspberry is connected to the internet, running OpenCPN 5.2.4-0+5b5bc06 from Flatpak Beta, and latest ocharts from Beta repository, version 0.9.0.37+4d3b0a7.

The error message is the following

This happens with my credentials from www.o-charts.org .

I did some tests also with wrong credentials and the error is the same. I've checked several times my credentials to make sure there was no mistake on those.

How can I help find the root cause?

o-charts is now available but the key dongle is not detected.
No extra actions are performed by me. I suppose o-charts are expected to trace it?

More info:..
rpi5@raspberrypi:/etc/udev $ lsusb
........
Bus 001 Device 003: ID 1547:1000 SG Intec Ltd & Co KG SG-Lock[U2]
........
rpi5@raspberrypi:/etc/udev $ ls
hwdb.d rules.d udev.conf
rpi5@raspberrypi:/etc/udev $ cd rules.d
rpi5@raspberrypi:/etc/udev/rules.d $ ls
99-com.rules

uname -a:
Linux raspberrypi 6.1.0-rpi7-rpi-2712 #1 SMP PREEMPT Debian 1:6.1.63-1+rpt1 (2023-11-24) aarch64 GNU/Linux

While using ocharts with the oeuSENC-NL_BE charts, I noticed that sometimes double-clicking a buoy returned info on mutliple nearby buoys. Because objects are returned based on their bounding box (including any label), this is sometimes expected (though sometimes confusing, but I opened OpenCPN/OpenCPN#2712 about making sure the object clicked is actually shown at the top always).

For regular ENC charts, the behavior is what I expected based on (what I think are) the bounding boxes. However, for o-charts, I sometimes see objects returned that should not be based on (what I think is) their bounding box.

For example, with the Netherlands & Belgium chart (oeuSENC-NL_BE), around 53° 02.2163' N / 004° 51.3733' E at 1:10000 (1:9400 and 1:11000) also worked, clicking the OS2 buoy also returns info for the T12 buoy, whose bounding box I would expect to end to the left of the "T12" label, which is sufficiently far away from the click point to not be returned:

Interestingly, when I restart OpenCPN, the problem no longer occurs, but when I change the zoom and back (i.e. press - and then +), the problem does occur. Also, clicking quite a bit above (around the 291 deg label) or to the left of the T12 label also shows that buoy in the list. It seems a bit like the bounding box of the T12 label is bigger than it should be, while the bounding box of the icon is as expected.

This was tested using OpenCPN 5.6.1 and o-charts 1.0.25.0.

At the very least it should be similar to
https://opencpn.org/wiki/dokuwiki/doku.php?id=opencpn%3Aopencpn_user_manual%3Aplugins%3Acharts%3Aocharts&lng=en

and it should probably have reference to some of these pages on O-charts.org

See oeSENC outdated and now O-charts is used. Updates needed. #90 for these links

The shading of the precaution area's is a bit to dark (To my opinion) To compare the same area (Aproaches to Rotterdam) in o-chart_pi and direct enc in O. OpenGL on/off doesn't make a difference. OS is linux.