Giter Club home page Giter Club logo

png's People

Contributors

cigonzalez avatar jponttuset avatar parbela avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

png's Issues

Standalone evaluation code

Hello,

Thank you for providing the code, and congratulation on the paper acceptance, this is a very interesting task.

It is very helpful to provide the baseline model, however, I’d argue that it would facilitate adoption if a standalone reference evaluator for the task was provided. Something with minimal dependencies (eg no assumption on the DeepLearning framework used, although numpy/sklearn are probably ok), that takes in the path to the annotations, as well as the model predictions in a documented format (json or dict for eg), and spits out the official metrics. Some basic checks could also be carried out, eg that all predictions are present, that there is no duplicate, that the masks have the correct resolution,...

As far as I can tell, the current evaluation code is too tightly integrated with the model to be used independently, for example taking care of dealing with distributed aspect, relying on internal configuration classes, and more importantly, integrating the forward pass directly inside the evaluation function.

For examples of such standalone evaluators, I refer to the panoptic evaluation toolkit for coco: https://github.com/cocodataset/panopticapi or for a more closely related task, the referring expression segmentation evaluator on PhraseCut: https://github.com/ChenyunWu/PhraseCutDataset

Looking forward to working on this task,

Best regards,
Nicolas Carion

Error in the "panoptic_narrative_grounding.py"

image
In "panoptic_narrative_grounding.py", the definition of "mask_transform" is as follows:
image
,which takes the "PIL Image" as input.
However, the type of the input "mask" is a tensor, there is an error ["TypeError: img should be PIL Image. Got <class ‘torch.Tensor’>"] when I run your repo.
Therefore, I change this code in this way:
image, and the code can run successfully.

A similar change is also in the 'train_net.py'
image
The types of "p" and "t" are both tensors.

Is it OK?

Thanks for your nice work and code.
Looking forward to your reply.
Jiaheng.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.