bcn-medtech / reimagineclient Goto Github PK

All logs are now either in the terminal console or in the app, but normal users cannot see them. We should move them to a file in Documents/reImagine/log-DATE.txt and also report the fatal ones to the user with a popup (for now if you don't see the console you will miss them)

For now we only tested in linux: please test in windows 10 and report all the errors!

For now you have to check in the console logs

We should sign also binaries for windows and linux

For now we just check whether conda is installed or not at the starting of the app

There are many warnings that appears in the devel version, we should fix them

For now they stay in Documents/reImagine/an and they waste space

We should say if it was successfull or not

Describe the bug
If I put the annotations before starting the anonimization, they are lost and the uploaded metadata.json contains only "null"

Expected behavior
Annotations should be maintained independently from the anonimization process

Additional context
Annotations should be retrieved from the state.formData of the form so we ensure that we always capture the latest information the user has introduced. Trying to sync between forms is not a good idea IMO

Since clinicians are gonna use the, how about a dialog for creating a new credential if none are found?

Currently, if a user selects a non-dicom folder anonimization exits without errors, but the upload does not recognise that there is nothing to upload.

Either do not show uploader if there is nothing in the anonimization folder or simply copy the original files and skip anonimization altogether

I get this error during anonimisation. File name is

ADUHEART429_TWOCHAMBER_1.MR.0027.0001.2017.11.17.16.30.17.827150.3253495.IMA

in folder:
/Users/gbernardino/Data/aduheartultimos/aduheart231/2 chamber'

Could it be that there are spaces in the path?

An error occurred during anonimization!
Reason: Error while running anonimization: undefined Command failed: /Applications/reImagineClient.app/Contents/Resources/scripts/runDeid.sh /Users/gbernardino/Data/aduheartultimos/aduheart231/2 chamber /Users/gbernardino/Documents/reimagine/an/63e69fdf-a8ef-4d80-a5f9-3ca276b79556 /Applications/reImagineClient.app/Contents/Resources/scripts/deiden/src/deidTest_pyd.py /Users/gbernardino/Documents/reimagine/patients.sqlite /Users/gbernardino/miniconda3/bin/activate /Applications/reImagineClient.app/Contents/Resources/scripts/deiden/src/deid_light.dicom /Users/gbernardino/Documents/reimagine/patients.csv /Users/gbernardino/Documents/reimagine/headers
activate does not accept more than one argument:
['/Users/gbernardino/Data/aduheartultimos/aduheart231/2 chamber', '/Users/gbernardino/Documents/reimagine/an/63e69fdf-a8ef-4d80-a5f9-3ca276b79556', '/Applications/reImagineClient.app/Contents/Resources/scripts/deiden/src/deidTest_pyd.py', '/Users/gbernardino/Documents/reimagine/patients.sqlite', '/Users/gbernardino/miniconda3/bin/activate', '/Applications/reImagineClient.app/Contents/Resources/scripts/deiden/src/deid_light.dicom', '/Users/gbernardino/Documents/reimagine/patients.csv', '/Users/gbernardino/Documents/reimagine/headers']

/Applications/reImagineClient.app/Contents/Resources/scripts/runDeid.sh: line 15: pushd: scripts/deiden/: No such file or directory
usage: deidTest_pyd.py [-h] [--outdir OUTDIR] [--recipe RECIPE]
[--save-headers] [--headers-dir HEADERS_DIR]
[--db-location DB_LOCATION]
[--export-on-save EXPORT_ON_SAVE]
basedir
deidTest_pyd.py: error: unrecognized arguments: chamber

Check into the logs for additional informations

This is a regression

Describe the bug
Since ddbf911 a form is available in the anonimizer to add metadata to the upload. The title and description of the form are not well visible. Probably we need to fix the style.

Expected behavior
Title and description should be in white

Screenshots

Some packages are marked as obsolete. We should upgrade them if possible

We should ensure that all uploaded files have correct metadata that identifies at least the project, the physicians uploading them, the hospital, the type of the file and the intented use.

We could either put them in a json, or dicomify everything...

M.

Because if we have several people anonimizing from different pcs the reandom ids will not match the followups of the patient

For now File, Edit, Help menu in the app are not useful: remove or update?

It only list deiden as software installed. Between installed and not installed it should list all the config.requiredPrograms

• Check the type of files in the folders and groups them by type
• Run dicom anonimization only on the dicom ones
• Others, such as video of the intervention, or segmentations should be uploaded as they are

Describe the bug
I installed version 1.4.17. Once opened, it should have visualized the updating screen and gave the possibility to upload or else. Instead nothing happened.

Desktop (please complete the following information):

• OS and version of the OS: [e.g. Mac OS and windows]

Additional context
There are probably two bugs here: on windows the update works but the updating screen is not sent. On mac the update itself does not happen because of a missing zipfile in the web

Logs on MacOS:
log_Main.txt

I tried to install reimagine with a current version of conda. Then, I get some error due to some incompatibility (log below). Why don't you use conda to create a full environment with all the packages you need, without interferring with the local conda environments? I clicked a second time, and it seemingly worked, but then it said that deiden was still not installed

Also, it is not urgent but there are some spelling mistakes and incorrect spacing in some of the text.

Cheers,
Gabriel

The error happens because we search for "node" executable without checking if it is valid