Comments (18)
Just to provide an update for this issue. I checked the repos in bcgov organization, don't see any other repo named with "nr" or "theme", also chatted with Andrea, we should be good to use "nr-theme". If other teams also work on other design systems, they can call their repo a different name.
I'll start to make the name change this week or next week.
from nr-theme.
yeah, sorry i didn't tag anyone. my last comment was meant to ask @MCatherine1994 to pick a timeline that best suits her pre-existing workload
from nr-theme.
sure, I'll bring this to our dev meetup this Thursday cause the package naming change will impact the teams that are currently using it. And will target do the change next Monday. Thanks!
from nr-theme.
@MCatherine1994 I like that idea! Departments get renamed all the time in gov. Plus common says a lot. :)
Even just nr-theme
works.
from nr-theme.
yeah, I agree. If other teams want a different theme, they can name their repo differently
from nr-theme.
I'll put this on hold for now until Andrea is back from the vacation and it's not that urgent, then we can discuss which name want to use.
from nr-theme.
Ideally we'd build components that all of NR can use. Most of my tools are for general consumption, not just gov.
nr-theme
!
i like to think that way too, building for all of gov, but we did shop what we're doing with other NR teams and they were not satisfied with it.
the other thing that makes me not that comfortable with a generic nr-theme repo name is that we made a lot of decisions that are not in line with the rest of BCGov/GCPE. for example the blue that we have for the buttons across all of our login pages and headers on the content pages is not a normal BC Gov blue. we made some decisions that were only focused on FSA/FDS apps. other parts of gov may not want to follow what we did
i agree with @MCatherine1994, let's wait for Andrea
from nr-theme.
@jackwingsam Ha, sure! Whatever your team decides we do. :D
from nr-theme.
Looks like while I was on vacation, we got approval to change from FSA to FDS
from nr-theme.
Welcome back @jackwingsam! :) ...Let's talk to @MCatherine1994 about making this change.
from nr-theme.
Hi Jack @jackwingsam, changing repo name is doable. Just wondering since we already published some packages based on the current repo name for teams to share the stylesheet. If we change the repo name, we might want to change the package name as well?
If so please let me know when you'd like the name change to be done, thanks!
from nr-theme.
i really don't know how to answer the part about the packages name.
the name change overall is not a high priority thing. but slightly higher priority now that Chantelle got the name change approved. what's a good timeline that fits your schedule?
from nr-theme.
@jackwingsam Let's leave that to @MCatherine1994. I'm mostly here for support and/or to fill in any gaps.
from nr-theme.
Morning @jackwingsam @DerekRoberts, I wonder do we need to include "fds" in our repo name? Or maybe we can call it "nr-common-theme", so we don't need to worry about the team name in the future?
from nr-theme.
I'm ok with a more generic name but maybe something more specific to forestry? We know there are other NR sector teams (like ENV and even with FOR/WLRS) also doing their own design systems. We tried to join forces but they didn't want to...
from nr-theme.
how about nr-forest-theme? or any other suggestion? @jackwingsam @DerekRoberts
from nr-theme.
Ideally we'd build components that all of NR can use. Most of my tools are for general consumption, not just gov. nr-theme
!
from nr-theme.
Thanks @MCatherine1994
@alkolot is the one who's going to have to interface with other nr design teams
from nr-theme.
Related Issues (20)
- Add walkthrough in design system
- Buttons
- Header gray border fix
- Fix button spacing from icons
- Navigation tab
- Cross-project test
- test 2
- Test3
- Review FREP support tickets in Jira to see common issues
- Examine data table vertical spacing
- change the error icon in the notification message to "x" HOT 3
- Status icons - do we need both red ! and red ❌
- Notifications for low-contrast dark mode are too low-contrast
- Prototype updated typography
- Create background variables for light and dark mode
- Create atomic colour variables
- Re-create data table component by columns instead of by row HOT 1
- Create semantic colour variables
- Update colour tokens names
- Ensure Notification token names match between Figma and Github
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nr-theme.