Comments (12)
This issue includes a fair bit of documentation updating as well. Perhaps just a notice for deprecating, but quite a bit of editing with removal.
from bcmaps.
Would we consider using lifecycle for this, it has a nice option to deprecate just an argument or partially deprecate an argument. On quick look this is what we will need to do for most of the functions for sp
?
from bcmaps.
I think for the functions that provide data sources that makes sense... basically want to deprecate the class
parameter right? For the utility functions (fix_geo_problems
, transform_bc_albers
) we want to deprecate the .Spatial
methods I think using the traditional means - but I bet Lifecycle has ways to facilitate that as well?
from bcmaps.
One other way would be to just add a message on package load saying "sp is going away, be advised". The advantage there is that it is more likely to be read. Or maybe a combination of the two.
from bcmaps.
I think both are a good idea. Using the .Depracated
method you get the message on the function calls "for free"
from bcmaps.
For sure. We should check the vignettes as well.
from bcmaps.
I have a PR up starting this work. Should (or can) we duplicate this issue and have one Issue/PR for deprecating all sp
-related functionality and a second Issue/PR for changing raster fxns to use {terra}?
from bcmaps.
@ateucher nudge re: splitting the work behind this issue out into 2 PRs?
from bcmaps.
I think two PRs makes sense
from bcmaps.
@ateucher Do we leave this open until the Summer release?
from bcmaps.
Let's close it - I'll change the name so it's more reflective of what we did, then open a new one with a milestone
from bcmaps.
closed by #119
from bcmaps.
Related Issues (20)
- Write up instructions for adding a layer (for potential contributors) HOT 1
- Please remove dependencies on **rgdal**, **rgeos**, and/or **maptools** HOT 6
- Release bcmaps 1.1.0
- Drop raster and switch to using terra HOT 2
- Change `master` to `main` HOT 1
- Release bcmaps 1.2.0
- Drop sp support HOT 3
- Improve documentation for bc_bound() vs. bc_bound_hres() HOT 1
- Add citation to README? HOT 1
- Update add_points vignette with a ggplot2 example HOT 1
- Improvements to pkgdown site
- Missing part of map in airzone() HOT 19
- Hide uninformative plot captions in vignettes HOT 6
- Release bcmaps 2.0.0 HOT 3
- Ensure cded functions play well with terra
- Release bcmaps 2.1.0
- cded_raster deprication lifecycle message doesn't print properly HOT 4
- Release bcmaps 2.2.0
- `utm_convert()` drops tbl class
- utm_zone_lookup not found HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bcmaps.