Deprecate support for sp about bcmaps HOT 12 CLOSED

This issue includes a fair bit of documentation updating as well. Perhaps just a notice for deprecating, but quite a bit of editing with removal.

from bcmaps.

Would we consider using lifecycle for this, it has a nice option to deprecate just an argument or partially deprecate an argument. On quick look this is what we will need to do for most of the functions for sp?

from bcmaps.

I think for the functions that provide data sources that makes sense... basically want to deprecate the class parameter right? For the utility functions (fix_geo_problems, transform_bc_albers) we want to deprecate the .Spatial methods I think using the traditional means - but I bet Lifecycle has ways to facilitate that as well?

from bcmaps.

One other way would be to just add a message on package load saying "sp is going away, be advised". The advantage there is that it is more likely to be read. Or maybe a combination of the two.

from bcmaps.

I think both are a good idea. Using the .Depracated method you get the message on the function calls "for free"

from bcmaps.

For sure. We should check the vignettes as well.

from bcmaps.

I have a PR up starting this work. Should (or can) we duplicate this issue and have one Issue/PR for deprecating all sp-related functionality and a second Issue/PR for changing raster fxns to use {terra}?

from bcmaps.

@ateucher nudge re: splitting the work behind this issue out into 2 PRs?

from bcmaps.

I think two PRs makes sense

from bcmaps.

@ateucher Do we leave this open until the Summer release?

from bcmaps.

Let's close it - I'll change the name so it's more reflective of what we did, then open a new one with a milestone

from bcmaps.

closed by #119

from bcmaps.