bbvaengineering / ember-modal-service Goto Github PK
View Code? Open in Web Editor NEWAn ember-cli addon to manage modals as promises
License: MIT License
An ember-cli addon to manage modals as promises
License: MIT License
15.12.3
to 15.12.4
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
semantic-release is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
branch
parameter from push
function (ffe1062)The new version differs by 1 commits.
ffe1062
fix: remove unnecessary branch
parameter from push
function
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
As Octane edition is around the corner it seem good time to get support (or at least define/discuss the plan if it's not defined yet) for Glimmer Components.
7.8.0
to 7.9.0
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
ember-cli-babel is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.
The new version differs by 15 commits.
6b8cf74
Release 7.9.0
8907a49
Update RELEASE.md.
a8adb49
Update modules API for colocation support (emberjs/rfcs#481). (#295)
4f9e319
Update modules API for colocation support (emberjs/rfcs#481).
0b5f299
Merge pull request #292 from babel/dependabot/npm_and_yarn/lodash.defaultsdeep-4.6.1
909a94c
Merge pull request #293 from babel/dependabot/npm_and_yarn/lodash.merge-4.6.2
447b7b2
upgrade all in-range deps (#291)
e61f9b2
Bump lodash.merge from 4.6.1 to 4.6.2
dba1ec5
Bump lodash.defaultsdeep from 4.6.0 to 4.6.1
47672e0
Merge pull request #289 from efx/remove-bower-config
adfd200
remove legacy bower configuration
2714489
Merge pull request #288 from rwjblue/reroll-yarn
a61d5d3
Refresh yarn.lock.
a4a668b
Merge pull request #287 from rwjblue/add-release-setup
321743b
Add automated release setup.
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
3.0.3
to 3.0.4
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
@semantic-release/changelog is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 3 commits.
50ed752
fix(package): update fs-extra to version 8.0.0
dd0d91f
chore(package): update tempy to version 0.3.0
00204d2
chore(package): update nyc to version 14.0.0
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
3.12.0
to 3.13.0
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
ember-cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
2.0.0
to 2.0.1
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
ember-export-application-global is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
0.9.0
to 0.9.1
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
qunit-dom is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
hasTagName()
assertion (@scalvert)The new version differs by 116 commits.
e797234
v0.9.1
d844878
build(deps-dev): bump eslint-config-prettier from 6.4.0 to 6.5.0 (#517)
d4e4307
build(deps-dev): bump rollup from 1.25.2 to 1.26.0 (#516)
a03f613
build(deps-dev): bump @types/jest from 24.0.19 to 24.0.20 (#515)
8545c51
build(deps-dev): bump @ember/optional-features from 1.0.0 to 1.1.0 (#513)
d27f0e1
build(deps-dev): bump rollup from 1.25.1 to 1.25.2 (#514)
2246477
build(deps-dev): bump rollup from 1.24.0 to 1.25.1 (#512)
4a0374f
build(deps-dev): bump ember-cli-htmlbars from 4.0.5 to 4.0.8 (#511)
b9c7d2a
build(deps-dev): bump rollup from 1.23.1 to 1.24.0 (#510)
06ef888
build(deps-dev): bump @types/jest from 24.0.18 to 24.0.19 (#509)
afca4ec
build(deps-dev): bump typescript from 3.6.3 to 3.6.4 (#507)
738e9b6
build(deps-dev): bump ember-cli-inject-live-reload from 2.0.1 to 2.0.2 (#506)
212cd7c
build(deps-dev): bump ember-source from 3.13.2 to 3.13.3 (#505)
2dfb164
Merge pull request #499 from step2yeung/hasnotext
058b20d
Add hasNoText assertion
There are 116 commits in total.
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
5.2.0
to 5.2.1
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
ember-resolver is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 5 commits.
cd2e16b
Release 5.2.1
307ce67
Add v5.2.1 to CHANGELOG.
403bb72
Component and their templates should be normalized the same. (#396)
422b1c7
Component and their templates should be normalized the same.
6f9793b
Bump eslint-plugin-ember from 6.7.1 to 6.8.2
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
4.5.0
to 4.5.1
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
ember-qunit is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 5 commits.
46b7c68
Release 4.5.1
e808fb7
Add a small configurable delay to test isolation validation asse⦠(#528)
9efa52e
Add a small configurable delay to test isolation validation assertion.
f2109f9
Merge pull request #527 from emberjs/dependabot/npm_and_yarn/ember-resolver-5.2.0
c6fe6d0
Bump ember-resolver from 5.1.3 to 5.2.0
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
master
branch failed. π¨I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.
You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. Iβm sure you can resolve this πͺ.
Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.
Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master
branch. You can also manually restart the failed CI job that runs semantic-release.
If you are not sure how to resolve this, here is some links that can help you:
If those donβt help, or if this issue is reporting something you think isnβt right, you can always ask the humans behind semantic-release.
An npm token must be created and set in the NPM_TOKEN
environment variable on your CI environment.
Please make sure to create an npm token and to set it in the NPM_TOKEN
environment variable on your CI environment. The token must allow to publish to the registry https://registry.npmjs.org/
.
Good luck with your project β¨
Your semantic-release bot π¦π
2.0.1
to 2.0.2
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
ember-cli-inject-live-reload is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 42 commits.
f3e9bea
Release 2.0.2
4c4ebc0
Respect liveReloadPort even if same as ember server port (#113)
9581f3b
Respect liveReloadPort even if same as ember server port
ba3de60
Change entry-point script. (#123)
8b732e0
Change entry-point script.
00616ce
Re-roll yarn.lock due to issues with [email protected] (#122)
f608771
Re-roll yarn.lock due to issues with [email protected]
5a37c1d
[Security] Bump eslint-utils from 1.3.1 to 1.4.2
d7fd57f
[Security] Bump lodash from 4.17.11 to 4.17.14
e9738c0
Bump express from 4.17.0 to 4.17.1
f1a66fc
Bump express from 4.16.4 to 4.17.0
0367c3f
Bump eslint from 5.15.3 to 5.16.0
6800f6d
Bump ember-cli-version-checker from 3.1.2 to 3.1.3
3ee4ac7
Bump eslint from 5.15.2 to 5.15.3
3e43143
Bump eslint from 5.15.1 to 5.15.2
There are 42 commits in total.
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
7.5.0
to 7.6.0
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
@commitlint/config-conventional is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
The package 'ember-task-scheduler' is only used for testing. Searching for it in this repo gives only 3 results:
Hi, is it possible to customise the name used for the modal?
I like to store my modals in a nested directory structure (e.g: modals/some-modal
). It seems that nested components is incompatible with the add-on?
Attempting to inject an unknown injection: 'service:scheduler'
Above error occur in v1.1.0 while trying to open a modal.
I have a modal with two text fields. After filling them up, when you click the YES
button, I call the action "resolve" with two arguments containing the two texts. In the .then((text1, text2) => ..., text2 is always undefined.
I've debugged the service, and in resolve action, arguments are good. But the call to this.resolve(...arguments) fails, because the function resolve only takes first argument as data, the second one is label, so it is resolved as label and not passed to the .then function later.
7.0.15
to 7.0.16
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
@semantic-release/git is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 1 commits.
a93b846
fix(package): update globby to version 10.0.0
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
2.0.0
to 2.1.0
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
ember-load-initializers is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
sudo: false
option (@Turbo87)The new version differs by 92 commits.
a28db5e
Release 2.1.0
60d700d
Add release-it setup.
fae7eab
Build(deps): Bump ember-cli-babel from 7.9.0 to 7.10.0
8277efa
Merge pull request #111 from ro0gr/types
74ad062
Add typescript support
01b3b93
Build(deps-dev): Bump eslint-plugin-ember from 6.9.1 to 6.10.0
4b1da73
Build(deps-dev): Bump eslint-plugin-ember from 6.9.0 to 6.9.1
72d274a
Build(deps): Bump ember-cli-babel from 7.8.0 to 7.9.0
84e0ab2
Build(deps-dev): Bump eslint-plugin-ember from 6.8.2 to 6.9.0
4fece24
Build(deps-dev): Bump ember-qunit from 4.5.0 to 4.5.1
d42dc0d
Build(deps-dev): Bump ember-resolver from 5.2.0 to 5.2.1
ae9616b
Build(deps-dev): Bump eslint-plugin-ember from 6.7.1 to 6.8.2
fd20863
Build(deps-dev): Bump ember-resolver from 5.1.3 to 5.2.0
3843070
Build(deps-dev): Bump ember-qunit from 4.4.1 to 4.5.0
d66c66e
Build(deps): [Security] Bump lodash from 4.17.11 to 4.17.14
There are 92 commits in total.
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
I found out that transitionend
event emitted from child element inside modal component can trigger modal to be prematurely close.
If I added a check in on-transition-end.js
like so then it works. I'm not sure if the intention was to catch all transitionend
event but it looks like a bug to me.
export default function onTransitionEnd(element, callback, transitionProperty = 'all', once = false) {
const fn = (e) => {
const { propertyName, type, target } = e;
// Check to see if target and element are the same element.
if (target !== element) {
return ;
}
if (transitionProperty !== 'all' && propertyName !== transitionProperty) {
return;
}
if (once) {
element.removeEventListener(type, fn, true);
}
run(null, callback, e);
};
element.addEventListener(transitionEndEventName, fn, true);
}
When using ember-modal-service with Ember 3.3.0, I get the following deprecation message:
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.1.10 located: ...
Hi!
I faced an issue when we can't close modal window.
If we going to close a modal window which has the transition property, modal won't close.
Because removing will happen only on onTransitionEnd event
(https://github.com/BBVAEngineering/ember-modal-service/blob/master/addon/components/modal.js#L177)
But onTransitionEnd will never happen because the modal window is already hidden.
7.5.2
to 7.6.0
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
@commitlint/cli is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
This issue applies when #7 is merged.
Using Ember.run
in line 49 of addon/utils/css-transitions/on-transition-end.js
can cause a reflow if the callback code is using some DOM properties that forces reflow.
This can be fixed using window.requestAnimationFrame
.
Remember to fix this when requestAnimationFrame
addon its done and published.
2.6.0
to 2.7.0
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
husky is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
10.0.2
to 10.0.3
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
babel-eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
Hello!
I have a computed property on a modal component.
The computed property creates a 'title' for the modal which I want to display in the modal template.
The title
computed property is dependent on a value in the modal's options object (this value is the model for a form contained within the modal)
title: computed('model.options.formModel', function() {
if(this.get(model.options.formModel)) {
alert('hello')
}
}
It seems that the options object is not populated when I try to read it using this.modal.options
in the component.
I've tried waiting on model.promise
in the hope that when the promise is resolved, the options become available, but no luck.
I've also tried making the computed dependent on model.options.@each
and then check for this.model.options.formModel
when this.model.options
changes - but also no luck.
Any suggestion on how to go about accessing the options
of a particular modal in a computed property of a modal component?
Cheers!
6.2.0
to 6.3.0
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
eslint-plugin-ember is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
no-unnecessary-service-injection-argument
rule (@bmish)closure-action
rule examples (@Caltor)There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
Hi,
I'm curious if there's anyway to set a default set of actions to be called for a single modal or for all modals.
For example, I'd like to add the overflow: hidden
style to the <body>
element when I open any modal and then remove the inline styling when I close the modal.
It seems that the obvious way to handle this is something like:
this.get('modal').open('my-modal, { formModel: this.model }).then(
document.getElementsByTagName("BODY")[0].setAttribute("style", "overflow: hidden"),
function() {
document.getElementsByTagName("BODY")[0].setAttribute("style", "overflow: visible");
}
);
But this means I now need to remember to add this to all calls to modal.open
, which seems too fragile...
9.0.1
to 9.1.0
.π¨ View failing branch.
This version is covered by your current version range and after updating it in your project the build failed.
eslint-plugin-node is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
The new version differs by 3 commits.
7ce77f9
π 9.1.0
e5aee3c
π support *
in engines.node
(fixes #155)
fd9d19d
β¨ no-deprecated-api
adheres to targeted node version (fixes #141) (#164)
See the full diff
There is a collection of frequently asked questions. If those donβt help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot π΄
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.