bbg-cookbooks / monit-ng Goto Github PK

Using Chef Client, version 11.18.0

I get the error

Chef::Mixin::Template::TemplateError (Undefined method or attribute only_on' onnode') on line #39:

37: <% @alert.each do |alert| %>
38: set alert <%= alert.name %>
39: <% if ! alert.only_on.nil? -%>
40: only on { <%= alert.only_on.join(', ') %>}
41: <% elsif ! alert.subscriptions.nil? -%>

Seems to be from the recent changes (today)

monit package is available via amazon repository and yum-epel is not required for amazon platform.

submitting a PR..

Hi,

I'm running monit-ng in chef-provisioning on Ubuntu 15.04, via:

    recipe "monit-ng"

I'm getting:

error    : Status not available -- the monit daemon is not running

This seems fixed when I do a

$ sudo monit

So I've added

execute "sudo monit"

to service.rb.

Do you have any suggestion on the matter ?
Thanks

hello! i am trying to manage monit configuration alone with chef role, but facing some issues.

1. localhost is always set to first mailserver, where i want to configure it to something else for different location servers and the only way i get it right is overriding attribute in a chef role, but that does not get me so far as i need different config for different chef roles
2. default root subscribers does not help my scenario much, at some places even local smtp is disabled

what do you think about having an attribute e.g. default['monit']['default_config']? which if set true, then below attributes will get default values otherwise not:

default['monit']['config']['subscribers']
default['monit']['config']['mail_servers']

i have PR ready if this sound good to you.

It's a bit of an odd situation, but we have situations where monit is already installed and switched off while we're doing work on either the OS, Java applications, or the databases the Java applications use. In some cases we need a Chef run before we're actually done with the work, and in every case monit-ng sees the installed monit service not running and immediately enables and restarts it. This immediately brings up our apps before we're ready, causing a bit of havoc. We're currently working around it by unmonitoring everything before maintenance, but that has caused a couple of issues as you can imagine.

Would it be strange to have a default attribute that could be overridden so that the monit-ng cookbook won't touch the service for a start or restart?

Thanks!
-Matt

submitting a PR.

Would you mind adding stop_as support? We're using monit to control applications that require a specific uid for both start AND stop.

hello! how do you think about setting monit['config']['listen'] to node['ipaddress']?

afaik, it can be set to '127.0.0.1', but can not be set to node['ipaddress'] using a chef role.

i will submit a PR if it sound good.

I'm trying to mask monit instance restarts (because you restart it every Chef run) but this doesn't work:

monit_check 'localhost' do
  check_type   'system'
  alert        '[email protected]'
  but_not_on   true
  alert_events ['instance']
end

because

================================================================================
    Error executing action `create` on resource 'monit_check[localhost]'
    ================================================================================

    Chef::Exceptions::ValidationFailed
    ----------------------------------
    Required argument check_id is missing!

check_id is only used by the template when id_type is set... which isn't true in this situation. From your own resource:

def check_pairs
        {
          'process' => %w( pidfile matching ), 'procmatch' => %w( matching ),
          'file' => %w( path ), 'fifo' => %w( path ),
          'filesystem' => %w( path ), 'directory' => %w( path ),
          'host' => %w( address ), 'system' => %w(),
          'program' => %w( path )
        }
      end

There should be a way to override template name. Currently it is a hardcoded "monit.check.erb" value. I've added a request #68 but for some reason it is failing.

it'd be nice to provide resources like monit_disk_check, monit_process_check, etc, that wrap the core monit_check resource and remove some of the redundancy of writing monit_check resources and specifying common stuff like id_type, etc.

When using cloud-init or other similar tools they often change the base sources.list to point to a IaaS specific mirror (region specific or otherwise) for performance

-# See http://help.ubuntu.com/community/UpgradeNotes for how to upgrade to
-# newer versions of the distribution.
-deb http://us-west-2.ec2.archive.ubuntu.com/ubuntu/ trusty main
-deb-src http://us-west-2.ec2.archive.ubuntu.com/ubuntu/ trusty main
+deb http://us.archive.ubuntu.com/ubuntu trusty main restricted universe multiverse
+deb-src http://us.archive.ubuntu.com/ubuntu trusty main restricted universe multiverse

Is anyone aware of how to make it not totally overwrite the hostname there? Haven't looked too deeply into the ubuntu recipe this cookbook sources

e.g. [using SSLAUTO|SSLV2|SSLV3|TLSV1|TLSV11|TLSV12]

https://github.com/bbg-cookbooks/monit-ng/blob/master/recipes/service.rb#L26

doesn't declare that it supports the status command, it should have the status set to true for the supports property

simplify the resources by inheriting from LWRPBase

besides hostname attribute, other attributes for node['monit']['config']['mail_servers'] are optional.

template must check each optional attribute.

http://mmonit.com/monit/documentation/monit.html

per documentation, multiple email servers must be , separated. But, it throws syntax error.

While configuring separate set mailserver for each email server, it works without any error.

template needs to be modified to generate set mailserver config for each mail server.

Hi there,

It is possible to define more than one service's group in monit check configuration. However group attribute is defined as a String in monit-ng. What do you think about adding a support for multiple groups here?

It can be achieved in three ways:

1. Change group to accept both, string and array types and recognize it in template.
2. Rename group into groups and force everybody to use an array type even for a single item.
3. Allow to use both, group and groups and add them in template.

Personally i would go with the first one as it seems to be the most "user friendly". What do you think? I can prepare a pull request if you agree on this.

need to delay monit service start to fix any error in lwrp resource(s).

cookbook tries to start the service before lwrp resources setup.

EL6 uses /etc/monit.conf, EL7 uses /etc/monitrc for the package-installed monit, need to correct this for EL7

Can you provide examples of how to set the configuration in attribute files? It appears that they should be assigned arrays of hashes with the appropriate data elements, but this does not jive with the default template which apparently uses dot notation to try to access the data. Either the template should use the proper hash key syntax (for example mailserver['hostname'] instead of mailserver.hostname), or an example should be given demonstrating how this is supposed to be used so future users don't have to chase their tails for days trying to figure out what's wrong with their config.

I'm seeing dependancy resolution issues when using this cookbook. I believe this is due to not having the dependancies in metadata.rb referenced in the repo Berksfile, e.g.

metadata.rb
%w( yum-epel ubuntu apt build-essential dpkg_autostart ).each do |dep|
  depends dep
end

Should have the following in the Berksfile

Berksfile
cookbook 'yum-epel', '~> 2.1.2'
cookbook 'ubuntu', '~> 2.0.1'
cookbook 'apt', '~> 6.1.4'
cookbook 'build-essential', '~> 8.0.3'
cookbook 'dpkg_autostart', '~> 0.2.0'

        Recipe: monit-ng::install
         * apt_package[monit] action install
           * No candidate version available for monit
           ================================================================================
           Error executing action `install` on resource 'apt_package[monit]'
           ================================================================================

For some reason, the monit package has been moved to buster-backports. Thus the recipe monit-ng::install fails on Debian 10. I'm not sure what's the best way to fix it as enabling buster-backports does not feel like the responsibility of the monit-ng cookbook. Thoughts?

A 127-character limit for start/stop commands was added in 22c6eef. For some use cases I'm having to wrap long commands in a shell script because. Is the limit still necessary?

I'm running Monit 5.6 and have not seen any issues with commands being truncated.

foodcritic lint test throws below error.

FC002: Avoid string interpolation where not required: ./recipes/source.rb:29

submitting a PR.

See: https://github.com/bbg-cookbooks/monit-ng/blob/master/libraries/monit_check.rb#L23

Why is this max arg limit necessary?

In https://github.com/bbg-cookbooks/monit-ng/blob/master/templates/default/monit.conf.erb#L75 it is hard coded to include any files with extension .conf. Is .conf is standard file extension that monit expects generally? Is it possible to override this somehow to say also include .monitrc' extension? As an example, the opsworks_ruby generates files with .monitrc` extension and therefore monit skips to load them as a monitoring services. Thanks.