batcypher / sample-credit Goto Github PK

The database persistence layer should be stored in a separated volume

https://docs.docker.com/compose/compose-file/compose-file-v3/#volumes-for-services-swarms-and-stack-files

In the absence of having named volumes with specified sources, Docker creates an anonymous volume for each task backing a service. Anonymous volumes do not persist after the associated containers are removed.

example:

...
  mysql:
    image: mysql
    volumes:
       - db-data:/var/lib/mysql/data
    networks:
       - overlay
    deploy:
      mode: replicated
      replicas: 2
      endpoint_mode: dnsrr

volumes:
  db-data:
  ...

always run pip install --upgrade pip setuptools before installing

This API name is wrong and should not be hard-coded but imported using from os import environ: environ["API_NAME"]

Also in the README the API name in the URL is wrong, use placeholders like localhost:8080/{API_NAME}

Same here, paths cannot be hard-coded but built from existing environment variables:

https://docs.docker.com/compose/compose-file/compose-file-v3/#healthcheck