Giter Club home page Giter Club logo

bjimagecropper's People

Contributors

barrettj avatar edsko avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bjimagecropper's Issues

There is an issue while setting frame of BJImageCropper class.

I am using this code.

self.imageCropper = [[BJImageCropper alloc] initWithFrame:self.myView.frame];
self.imageCropper.image = self.imageToCrop;
self.imageCropper.clipsToBounds = YES;
[self.myview addSubview:self.imageCropper];
self.imageCropper.center = self.view.center;
self.imageCropper.imageView.layer.shadowColor = [[UIColor blackColor] CGColor];
self.imageCropper.imageView.layer.shadowRadius = 3.0f;
self.imageCropper.imageView.layer.shadowOpacity = 0.8f;
self.imageCropper.imageView.layer.shadowOffset = CGSizeMake(1, 1);

and i also change code of BJImageCropper

  • (id)initWithFrame:(CGRect)frame {
    self = [super initWithFrame:frame];
    if (self) {
    imageScale = 1.0;

// imageView = [[UIImageView alloc] initWithFrame:CGRectInset(self.bounds, MAGE_CROPPER_OUTSIDE_STILL_TOUCHABLE, IMAGE_CROPPER_OUTSIDE_STILL_TOUCHABLE)];
imageView = [[UIImageView alloc] initWithFrame:self.frame];
[self addSubview:imageView];
[self setup];
}
return self;
}

There is also padding from y direction to the my view.

img_0050

bug infinite loop

Hi Barrett Jacobsen

First of all, thanks for this great project, it's very helpful.
Yesterday, i have found a bug during my test. In one case there is an infinite loop, in the while loop of the function call :

  • (void)constrainCropToImage;
    I think the block who create the pb is that one :

if (CGOriginX(frame) + CGWidth(frame) > CGWidth(cropView.superview.frame)) {
........
........
}

To create this case I start my cropView to 0,0 with the max frame. Then I select the leftView and drag it slowly to the right and in one moment the program stop because of the while loop.

I have try to fixed the bug but I'm not sure.

Other question : If I want to crop the image and keep the ratio, what can I do ??

thanks a lot !!

SIZE OF CROPPER

In iPhone its working fine but in iPad the size of the cropper is small really small. The bjImagecropper view gets small very small

BJImageCropper not center aligned

Hi Barrett J,

I am using BJImageCropper in one of my iPhone apps. I select picture from Photo Library and crop it using your cropper classes. The problem I am facing is that I want to center align BJImageCropper. But it always get skewed to left side. And its frame is always different depending upon the image selected. So at times, it comes in middle. At times it goes to extreme left. Is there anyway to center align it. Am attaching screenshot. If possible please reply me. Thanks
bjimagecropper - frame not set

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.