baptistearno / tinking Goto Github PK

Describe the bug
When in the process of selecting a node, if the page is reset, that node becomes useless unless you select a different action.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://www.youtube.com/'
2. Add step with action to extract text
3. Reload window
4. See error (step does not work)

Expected behavior
The step should be activated again when window is reloaded

Additional context
I suggest that it should be fixed by deleting the in-progress step altogether when page is reloaded.

Describe the bug
Related to issue #12

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://www.youtube.com/'
2. Make step to extract text
3. Click on video title (do not "check")
4. Make step to "record..."
5. See error (overlay still active)

Expected behavior
Overlay to disappear and "record..." action to begin.

Additional context
This issue is also related to the unclear focus of what step you are on. Whenever I click on new step I would expect that new step to be the focus therefore the overlay should disappear.

Describe the bug
While everything stays constant while the tippy is the only thing that disappears when the iframe is dragged.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://www.youtube.com/'
2. Extract text of a video
3. Drag the popup
4. Tippy disappears

Expected behavior
Tippy should not disappear when dragging the iframe

Additional context

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
Some component at the bottom of the popup that is dynamic and reacts according to the most probable issue. If the user generated code; the feedback should be set to a code broblem mode. If the user is in the middle of scraping; the feedback should be set to a scraping mode.

Describe alternatives you've considered

Additional context
The solution I suggest is very y complex but we don't really need that. But we Tinking definitely NEEDS user feedback

Tink ID: "b081d065-70af-4823-aea0-73be587fdd74"
Description: It did not record when I clicked on an article. It only recorded when I clicked on an external link

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
Dragging steps and/or being able to add a step between two steps

Describe alternatives you've considered

Additional context

Describe the bug
When npm run build I receive a yarn error
To Reproduce
Steps to reproduce the behavior:

1. follow the getting started steps with npm
2. when running npm i && npm run build the error appears

Expected behavior
No errors to show up and tinking to be set up successfully

Additional context
(I will fix this issue)

No Tink ID
Description: Final test

Tink ID: "b9acfba8-1239-4055-aeb9-3b07366804f1"
Description: testing automated issue creation

Hi,

Firstly, really cool plugin.

I was playing around with it and i nothing the following setting.

Select get Link -> Variable = "Anything" -> option - infinite scrolling -> Generate Code

The generate code doesn't declare the variable, anything.

await page.waitForSelector("div.item-summary a");
await autoScroll(page);

console.log({ Anything });
data = { Anything };
fs.writeFile(
  outputFilename ?? `./${new Date()}.json`,
  prettier.format(JSON.stringify(data), {
    parser: "json",
  }),
  (err) => {
    if (err) return console.log(err);
  }
);

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
Each recorded key or click should be stored as an action. Having them compressed as one action does not make sense and it results in many useless step action fields.

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.
The user should have an option to indicate how many elements (or pages or "down scrolls") to scrape

Describe the solution you'd like
Some kind of input where the user can choose infinite (max) or custom (as many as the user desires)

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.
It helps make issue13 pull more consistent

Describe the solution you'd like
Not allow the user to make more steps if there already is an empty one. (provide responsive validation checks like: "make sure step 3 does something")

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

Describe the solution you'd like
you cannot add more steps if there already is an empty step

Describe alternatives you've considered
decrease opacity of Add step button and disable it untill the empty step is dealt with.
the disabled Add step button should also hint the user on why its disabled

Additional context

Is your feature request related to a problem? Please describe.
Allow to deploy script on Phantombuster to use Phantombuster infra and scheduling option

Describe the solution you'd like
From puppeter code:
Add the following header:

// Phantombuster configuration {
"phantombuster package: 5"
"phantombuster command: nodejs"
"phantombuster flags: save-folder"
// }
const Buster = require("phantombuster")
const buster = new Buster()

Comment those lines:

//const prettier = require("prettier");
//const prompts = require("prompts");

Comment those lines:

      /*
      console.log({ variable0: formattedVariable0 });
      if (!promptContinue) {
        const response = await prompts({
          type: "confirm",
          name: "value",
          message: "Continue?",
          initial: true,
        });
        if (!response.value) {
          process.exit();
        }
        promptContinue = true;
      }
      data.push({ variable0: formattedVariable0 });
      bar.tick();*/
      }
      
    /*
    fs.writeFile(
      outputFilename || `./${new Date()}.json`,
      prettier.format(JSON.stringify(data), {
        parser: "json",
      }),
      (err) => {
        if (err) return console.log(err);
      }
    );
    */

Add the following lines to save the result:

let csvContent =  data.join("\r\n");
const saveAs = "texts/sample.csv"
const mime = "text/plain"
const url2 = await buster.saveText(csvContent, saveAs, mime)

replace all catch by catch (e).

Just click the Video Demo Link in the Readme

Tink ID: "2d9b1fe7-5d48-452d-8614-70bc86ac2bfa"
Description: When recording and moving from one domain to another the popup does not reopen.

Hello! I'm setting up the project to give it a test go. I'm running into a dependency tree issue when running npm i:

npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.1" from the root project
npm ERR!   peer react@"16.x || 17.x" from @chakra-ui/[email protected]
npm ERR!   node_modules/@chakra-ui/react
npm ERR!     @chakra-ui/react@"^1.0.1" from the root project
npm ERR!   2 more (@emotion/react, @emotion/styled)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8" from [email protected]
npm ERR! node_modules/framer-motion
npm ERR!   framer-motion@"^2.9.4" from the root project
npm ERR!   peer framer-motion@"^2.9.4" from @chakra-ui/[email protected]
npm ERR!   node_modules/@chakra-ui/react
npm ERR!     @chakra-ui/react@"^1.0.1" from the root project

I'm running node 14.7.0 and npm 7.5.2.

Not sure why it's complaining here - your version of react seems to be compatible with framer-motion and @chakra-ui/react. 🤷‍♂️

Describe the bug
By simply pressing on add step multiple times you can still have many empty steps

To Reproduce
Steps to reproduce the behavior:

1. Repeatedly click on Add step button
2. See error

Expected behavior
You should only be able to have one empty step

Additional context

Describe the bug
It many instances whenever you select an action that creates the overlay, whenever you click on something ".crx_mouse_visited" shows

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://www.youtube.com/'
2. Add a step that extracts text
3. Click on anything on the page
4. See error (".crx_mouse_visited" shows)

Expected behavior
The correct query selector to show

Additional context
PROGRAM BREAKING ERROR

Describe the bug
The onMouseMove is not stopped in any way other than confirming the selection, yet confirming the selection is not obligated.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://www.youtube.com/'
2. Extract title text from a video (do not confirm)
3. Add another step
4. See error (reguardless of what you do in the next step you continue editing the previous step)

Expected behavior
When you don't "check" of a step and move on to something else the onMouseMove should stop.

Additional context
Either make the "check" obligated (cant do anything else untill its confirmed) or BETTER yet make it so that whenever any other step is in focus automatically confirm and stop onMouseMove.

Is your feature request related to a problem? Please describe.
It is related to the "without explicit "checking"" issue.

Describe the solution you'd like
Make it clear which step you are working on at the moment.

Describe alternatives you've considered
Reduce opacity for steps that are not currently being worked on.

Additional context
Add any other context or screenshots about the feature request here.

            return [...elements].map((element) => element.textContent ? ? null);

error log :

            return [...elements].map((element) => element.textContent ?? null);
                                                                       ^

SyntaxError: Unexpected token ?
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)

Describe the bug
Whenever you begin recording the handle of the iframe can be recorded.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://www.youtube.com/'
2. Begin new step with action: "Record..."
3. Click on handle
4. See error (handle is recorded)

Expected behavior
The handle should never be recorded.

Additional context
Either catch and completely prevent the issue or at least make it so that the handle does not show up on the iframe UI.