bandprotocol / band Goto Github PK

The comparison table on https://bandprotocol.com/features/overview uses webp format, which renders blank on Windows machine.

Current Behavior

• Blank page on Windows

Expected Behavior

• Renders like on MacOs

Steps to Reproduce

• Go to https://bandprotocol.com/features/overview on Windows machine.

Suggested Solutions

Switch to this jpg instead

From #146, openzeppelin has introduced new standard to detect revert transaction. And we need to specify error message from contract, so we need to update our test to new standard.

Current Behavior

Every shouldFail statement now can't compiled

Expected Behavior

Change all shouldFail to expectRevert

Suggested Solutions

Read our contract and add error message to test (or contract)

Fix breadcrumb

Current Behavior

Expected Behavior

Add a filter on each page expect Web Request.

Example Image for sport

Motivation

Easy to find dataset.

Suggested Implementation

Adjust fetcher by sending types as params to query data.

Additional Context

Reference website

As the timing changes, let's remove the link to Airdrop.bandprotocol.com for now

Current Behavior

Expected Behavior

The link gone

Steps to Reproduce

Go to https://bandprotocol.com

Currently the README is WIP. Let's make it more understandable.

Motivation

Good projects start with good README.

Suggested Implementation

N/A

Additional Context

See 0x Monorepo for a possible example.

Motivation

To description more detail about transaction in wallet

We implemented regex driver to classify key to each group of driver. We want to use waterfall model to handle what driver used to query a request.

Current Behavior

We use map for store regex pattern and driver, and our code use loop on that map make order for check regex is inconsistency, so each node run different driver on same key.

Expected Behavior

Every node should select same driver for query the same key

Suggested Solutions

Add priority field to determine which driver will be done first if key match regex

The social links on the navbar don't function as they're supposed to

1. Hovering on the background should do nothing (currently highlight, which makes it seems clickable)

2. Hovering on the logo should show a filled version of these
   

3. Clicking on each logo should link to the corresponding social media channel

Can you make this more aligned / looks better

We want to have simple tests and travis script in place for bandapp.

Motivation

CI is the first safeguard against possible failure. Having it in place makes our lives easier when merging trivial changes like version bumps.

• Update whitepaper.bandprotocol.com to point to this pdf
  18090720sfvtdtxtmpzc.pdf
• Update every place that says "whitepaper 3.0" to "3.1"

New adapter type support getting data from other endpoint.

Motivation

Each provider can implement own data feeder external from our adapter concept (ex. create own web server to handle data). If we have adapter to request data from arbitrary endpoint, provider don't need to write data feed in go (free to read on your own way)

Suggested Implementation

We will set endpoint specification how request should be and your service must serve data in the correct way

Current Behavior

BandApp currently uses 1 BAND/USD exchange rate. This needs to be fix prior to mainnet launch.

Expected Behavior

The application should use real-world exchange rate of BAND/USD. I suggest we use CoinGecko https://api.coingecko.com/api/v3/simple/price?ids=band-protocol&vs_currencies=USD for this initial version.

Error messages are not aligned. Texts are difficult to read.

Related issue: #62

Motivation

Currently there is no way for investors to know about the estimated staking APR of data tokens. Showing estimated staking APR will potentially increase the adoption of data tokens staking.

Suggested Implementation

Estimated staking APR can be calculated based on the past staking reward distributions.

Motivation

Revenue from TCD stake is not automatically converted to user token. Let's have this column to differentiate stake from revenue.

Suggested Implementation

Ask @evilpeach

Additional Context

To understand more, you can look at the smart contracts.

Create Max Deposit Button in Deposit Modal.

Motivation

Easy for the user to use the maximum balance for staking.

Suggested Implementation

Similar to the withdraw button.

Dependabot couldn't find a package.json for this project.

Dependabot requires a package.json to evaluate your project's current JavaScript dependencies. It had expected to find one at the path: /bandweb/package.json.

If this isn't a JavaScript project, or if it is a library, you may wish to disable updates for it from within Dependabot.

You can mention @dependabot in the comments below to contact the Dependabot team.

1. The subscription on the navbar shouldn't be like this. Clicking on "subscribe" should replace it with the message showing success / error.
2. Similar to #75 hovering on the menu should not highlight.

Dependabot couldn't find a package.json for this project.

Dependabot requires a package.json to evaluate your project's current JavaScript dependencies. It had expected to find one at the path: /bandweb/package.json.

If this isn't a JavaScript project, or if it is a library, you may wish to disable updates for it from within Dependabot.

You can mention @dependabot in the comments below to contact the Dependabot team.

Dependabot couldn't find a package.json for this project.

Dependabot requires a package.json to evaluate your project's current JavaScript dependencies. It had expected to find one at the path: /bandweb/package.json.

If this isn't a JavaScript project, or if it is a library, you may wish to disable updates for it from within Dependabot.

You can mention @dependabot in the comments below to contact the Dependabot team.

With the upcoming Kovan testnet launch, we want to also have a new website with updated information on the current tech of Band Protocol

Motivation

• Current Band Protocol website still presents deprecated tech interfaces which no longer reflects what Band Protocol offers
• With the current implementation, our message offers a broad view of the products we have built. With the focus we now put on the TCD, we want to shape the messages to be more

Suggested Implementation

We already planned out the implementation detail. Here's what we need to do:

1. Create a sitemap - this will help to guide the content draft
2. Get a content draft - create a text-only version of the website. With this we try to make sure that when we put down the layout we have the narration ready, and that graphics should be supplementary to the content

https://docs.google.com/document/d/1mxRn0uzCZ-E2qngM2F_xPozl0Qf6uDkDihTEjsjOz_M/edit#

3. Get the layout down - with this step, we will have a working (design) prototype of the website that we can interact with. The goal is to make sure with got all the key navigation down and that the only thing left is graphics

Link gone > see full mockup instead

4. Full Mockups - now it's when things get real. This is what users will see on the fina implementation

https://invis.io/RETDW4S3NTK#/378112190_Landing

5. Implementation - this is where we'll put most energy on keeping track of things we need to accomplish before we release the website into the wild. Next section will underline the implementation checklist.

Implementation Checklist

Design

• Landing
• Feature > Overview
• Feature > Dual-Token
• Feature > TCD
• Feature > Data Governance Portal
• For Developer
• Company > About Us
• Company > Career
• Navigation
  • Navbar > Features
  • Navbar > Company
  • Navbar > Community

Desktop (Layout-only)

• Landing
• Feature > Overview
• Feature > Dual-Token
• Feature > TCD
• Feature > Data Governance Portal
• For Developer
• Company > About Us
• Company > Career
• Navigation
  • Navbar > Features
  • Navbar > Company
  • Navbar > Community

Desktop (Full)

• Landing
• Feature > Overview
• Feature > Dual-Token
• Feature > TCD
• Feature > Data Governance Portal
• For Developer
• Company > About Us
• Company > Career
• Navigation
  • Navbar > Features
  • Navbar > Company
  • Navbar > Community

Mobile (Full)

• Landing
• Feature > Overview
• Feature > Dual-Token
• Feature > TCD
• Feature > Data Governance Portal
• For Developer
• Company > About Us
• Company > Career
• Navigation
  • Navbar > Features
  • Navbar > Company
  • Navbar > Community

Analytics

• GA
• Amplitude

@evilpeach Please make sure we keep track of what's implemented

Here's the current info box.

Let's add TCD contract address (call it Dataset) and Governance contract address to this box.

Currently the logo on https://developer.bandprotocol.com doesn't follow the CI

Current Behavior

Expected Behavior

Suggested Solutions

• @evilpeach grab the new logo from this issue and make the change happen

Add an option that has 🔁 sign after the amount. On clicking, user can choose to (1) stake the revenue or (2) withdraw the revenue.

Motivation

Currently the only way for user to convert users pending revenue to voting power while still maintaining the stake it to click withdraw then deposit. This is non-obvious for users.

Suggested Implementation

Add a button to each row in table. Upon clicked, a modal pops up for users to choose. After chosen, a saga action is dispatch to perform the corresponding action.

I've not been able to see any doc around.
I got a few questions.

Where are located in this package the modules/fns to:

• generate a private/public key.
• encode an address from a private/public
• create and sign a tx

thanks

Current Behavior

Crash when community client is undefined.

Expected Behavior

Not crash when community client is undefined.

Steps to Reproduce

Suddenly buy the dataset token on web opening.

Suggested Solutions

disable input of buy and sell token modal when community client is undefined.

The current bandapp sidebar looks like this.

However, since we will have 1 tcd per dataset in this iteration, let's make "available dataset" look more like "configurations"

There should be arrow here for each item. Upon clicking, scroll down to the corresponding point.

Currently, dataset title in lottery page makes user confuse.

Current Behavior

The title doesn't show the type of lottery. (MegaMillions or Powerball)

Expected Behavior

Add type in the title

We have a fantastic idea for GasSwap implementation. Let's make sure we put it out there

Motivation

• GasSwap is a great complementary to Band Protocol query interface.
• @sorawit is going to talk about it at DevCon5!

Suggested Implementation

• Detail out in developer doc
• Add illustrations to better explain to idea
• Add demo contract / short tutorial on how to use it
• Publish medium article on this
• Create infographics to share in social media so ppl learn about it
• Partner with other projects on adopting the idea

To deposit the maximum amount for staking

Motivation

Easy for a user to deposit the maximum amount

Suggested Implementation

Similar to max withdraw button

[ Short explanation ]

Current Behavior

"Democretize"

Expected Behavior

"Democratize"

Suggested Solutions

@yeast72 This should be a quick fix

Right now links are green. Let's change them to blue.

Current Behavior

Expected Behavior

Suggested Solutions

• @evilpeach Change color from #3eaf7c to #1242ea

Add a summary for staking token and un-staking token of all TCDs.

Motivation

Make sure user know the staking token amount of each TCD

Suggested Implementation

Get data from the redux store

The green sign for "Live on Kovan Testnet" should blink

Suggested Implementation

Use css animation in https://bandprotocol.com/developer

The whitepaper version is incorrect.

Current Behavior

Expected Behavior

[ How you think it should look like ]

Suggested Solutions

Change text from 3.1 to 3.0

User should not deposit for staking if balance is not enough.

Motivation

Good for user experience.

In Buy/Sell -> advance setting:

https://developer.bandprotocol.com/home/comparison.html

The current version of BandApp does not support mobile. Let's make it show "not support" message when opening from a mobile device.

Motivation

Currently the way TCD works does not encourage more data providers beyond the active ones. Thus, if a provider goes offline or stops providing data, adding a new data provider may not be as smooth. Looking at EOS, for example, reserved validator nodes are in place to prevent such situation. Band should also have that.

Suggested Implementation

1. Add two governance parameters: reserved_providers_count and reseved_reward_percentage.
2. Whenever distributeFee function is called, also split some revenue to the reserved providers.

We need illustrations on our Developer Doc.

Motivation

Right now it's dull and not really tasteful.

Suggested Implementation

Let's go through this check list

• @sorawit list out all the specs for illustrations needed
• @prin-r draft the illustrations and align with @sorawit on the result
• @smiled0g turns the drafts into full version
• @sorawit then add all illustrations to the doc

Add field to each dataset to determine how to aggregate value.

Current Behavior

Now every data, we use median of value to be an aggregated value.

Expected Behavior

Each dataset can select way how to aggregate data. Median, Majority, or Depended on key.