balestrapatrick / valuestepper Goto Github PK

Not sure what broke but the number in the middle is no longer appearing in the app. I'm about to dive in and see if I can see what is going on.

doesn't work if min value = 1 and current value = 1

Hello, please add a callback If user Increment or decrement it would be a lot easier for us thanks, because for now we need to store the previous value to check if it's +1 / - 1

I have put the stepper in a tableViewCell, and for testing purposes every time the cell is show, the tint color is chosen randomly so, so once they go out of view, and come back they will have new color.

After coming back into view.

fix would be to add these into func tintColorDidChange()

increaseLayer.strokeColor = tintColor.cgColor
decreaseLayer.strokeColor = tintColor.cgColor

Hi,
I would like to change font(and size) of valueLabel, but it is private. Maybe you can add property to change font also?

Hi
I am receiving this error when updating Carthage.
Can you help?

*** Skipped building ValueStepper due to the error:
Dependency "ValueStepper" has no shared framework schemes

Thanks
WTBM

When we use ValueStepper in collectionView Cell, every time reusable cell is allocated, ValueStepper calls target method even though when it is not required. Also when altering value of the stepper, target method is called. What I think is you can remove Action(for:) from DidSet of value variable.

Looks like only a couple of issues

I need to add image on plus and minus but I dont see any option to add background image.

The return statement on lines 255 and 265 prevent a normal tap from changing the value and forces the user to tap+hold to change the value when autorepeat is enabled. Removing these two lines will cause the control to behave like the standard UIStepper where a tap+release will change the value by the step amount exactly once and a tap+hold will still autorepeat the value change.

Pod library is not working for extension, I tried to set Require only app-extension-safe api to NO, but didn't work.
I am using the extension for remote notification.
Please let me know if there is any workaround

Hi,
can you add the support for Swift Package Manager??

Thank

Hi, what pod should i add?
pod "ValueStepper"?

There is a subtle bug in labelPressed function on line 360. The following line of code
if newValue >= self.minimumValue || newValue <= self.maximumValue
must be replaced by
if newValue >= self.minimumValue && newValue <= self.maximumValue

The || operator must be replaced by && operator.

I got this error failed to render and update auto layout no suitable image found after installing via cocoa pods

I installed using Pod as indicated. Made no changes and instantly had the error. "Shared" is unavailable. Use New Controller based solution.

Using Xcode 8.3.3. Thanks for your help!
Howard

I do not find any font size option for value of stepper. Please provide this...

ValueStepper.swift line 205

override open static var requiresConstraintBasedLayout: Bool 

produces error:

Static declarations are implicitly 'final'; use 'public' instead of 'open'

/// - decrease: decrease button has tag 0.
/// - increase: increase button has tag 1.
private enum Button: Int {
case decrease
case increase
}

You can not set the tag value of an element to 0. Need to modify that logic in order to get elements by tag value correctly.

/// - decrease: decrease button has tag 1.
/// - increase: increase button has tag 2.
private enum Button: Int {
case decrease = 1
case increase = 2
}

so here is the attached gif of the bug:

basically happens when one presses +/- when the tableview is scrolling, it causes never ending acton (-- or ++ on the value). when one tries to to decrease while in never ending increment, it resists (as seen towards the end of the gif) and just continues to increment.

gonna do a PR.