bakkdoor / gumbo-d Goto Github PK

I guess official gumbo parser has changed their enum struct and this is not compatible with latest gumbo anymore.

class Element : Node {
enum Tag {
html, head, title, base, link, meta, style, script, noscript, template_, body_, article,
section, nav, aside, h1, h2, h3, h4, h5, h6, hgroup, header,
footer, address, p, hr, pre, blockquote, ol, ul, li, dl, dt, dd,
figure, figcaption, main, div, a, em, strong, small, s, cite, q, dfn, abbr,
time, code, var, samp, kbd, sub, sup, i, b, mark, ruby, rt, rp, bdi,
bdo, span, br, wbr, ins, del, image, img, iframe, embed, object, param,
video, audio, source, track, canvas, map, area, math, mi, mo, mn, ms,
mtext, mglyph, malignmark, annotationXML, svg, foreignObject, desc,
table, caption, colgroup, col, tbody, thead, tfoot, tr, td, th, form,
fieldset, legend, label, input, button, select, datalist, optgroup,
option, textarea, keygen, output, progress, meter, details, summary,
command, menu, applet, acronym, bgsound, dir, frame, frameset,
noFrames, isIndex, listing, xmp, nextId, noEmbed, plainText, rb,
strike, baseFont, big, blink, center, font, marquee, multicol, nobr,
spacer, tt, u, unknown, last,
};

First of all, the library looks very useful. Thank you for your work.

Second of all, it's nothing major, but just as a suggestion, you might want to follow the D style for the enum members names to fit more into other D code. (http://dlang.org/dstyle.html)
If you prefer, I can do a pull request for that.

Other than that, it might be good to have a link to this library on the original gumbo github page as the other bindings. (https://github.com/google/gumbo-parser)

Thanks again.

after including in App:
import gumbo.node, gumbo.parse;
and trying to compile it I am getting error:

Compiling using dmd... Linking... OPTLINK (R) for Win32 Release 8.00.15 Copyright (C) Digital Mars 1989-2013 All rights reserved. http://www.digitalmars.com/ctg/optlink.html C:\Users\Dima\AppData\Roaming\dub\packages\gumbo-d-0.2.2\gumbo-d.lib(parse) Error 42: Symbol Undefined _gumbo_destroy_output C:\Users\Dima\AppData\Roaming\dub\packages\gumbo-d-0.2.2\gumbo-d.lib(parse) Error 42: Symbol Undefined _gumbo_parse --- errorlevel 2 FAIL .dub\build\application-debug-windows-x86-dmd_2066-E9FCE136882C663918FD5E784 D7D2C14\ seismodownloader executable Error executing command run: dmd failed with exit code 2.