Disabling source maps about babel-loader HOT 11 CLOSED

Resolving this as the fix mentioned has since been implemented in another feature - https://github.com/babel/babel-loader/blob/master/index.js#L55-L57

from babel-loader.

Looks like 6to5-loader finds out whether to include source maps or not via this line.

from babel-loader.

Yeah, I saw that, but I don't know how to set it. In my webpack.config.js I have my loader options as:
loader: '6to5-loader?{"runtime":true,"modules":"common","blacklist":["react"],"sourceMaps":"false"}'
But that doesn't seem to work.

from babel-loader.

Webpack uses a querystring like style to pass options to loaders.
You should do something like:

loader: '6to5?runtime&modules=common&blacklist[]=react&!-sourcemap

You can find more info on how to use options with webpack loaders here: https://github.com/webpack/loader-utils

from babel-loader.

Uh. Took a deeper inspection (or better reading) and your way of passing options is fine. My bad.

However the sourceMap option should be singular not plural.
Still I need to take a better look to compare both source maps.

from babel-loader.

@Couto, using sourceMap or sourceMaps doesn't work. The suggested querystring style also doesn't work as given, and removing the "!" yields errors from the source-map module (I also tried with variations of case and plurality all with errors).

So far the only way I've found that works is to manually set options.sourceMap to false in 6to5-loader, which is far from ideal.

from babel-loader.

yields errors from the source-map module

Our build servers just updated to webpack-core 0.5.0 (and its source-maps dependency) and this is breaking everything. Is there no way to set this.sourceMaps from options ?

edit: it's not babel-loader which is breaking everything. but in my testing, this.sourceMap is always true, no matter what webpack config options I try

edit: specified webpack-core, not webpack

from babel-loader.

Not sure what the specific issue is so if someone can elaborate it'd be great. ie. why it's an issue and why webpack isn't supplying the correct sourceMap option.

from babel-loader.

Also can you confirm your webpack version please? the current version of webpack is 1.7.2, so I find your version kinda odd.

from babel-loader.

It looks like babel-loader ignores any sourceMap options you pass in the 'loader' line, it just checks to see if webpack wants a sourceMap and forwards that option. Webpack sourcemaps are enabled with the devtool param (as you probably already know).

Maybe the right thing to do for this issue is to have the 'loader' sourceMap option override the global webpack option. e.g. changing

https://github.com/babel/babel-loader/blob/master/index.js#L31

to

if (options.sourceMap === undefined) options.sourceMap = this.sourceMap;

but keep in mind that turning on sourcemaps there won't work unless sourcemaps are turned on for webpack also.

from babel-loader.

@Rob-ot that fix solves my problem.

from babel-loader.