Refresh time is too slow in expo react-native project after upgrade about babel-loader HOT 14 OPEN

@elitenas Thanks. I have downloaded the repro and will take a look.

from babel-loader.

I can confirm the problem.

@liuxingbaoyu @elitenas Okay, maybe this issue is platform dependent. I am on arm64.

Yeah, it's possible.

I use windows, I will try to fix it.

from babel-loader.

@nicolo-ribaudo please help with this as you made changes for 8.3.0

from babel-loader.

Can you provide a repo to reproduce it?

from babel-loader.

@liuxingbaoyu thanks for the response. Here is a repro project: https://drive.google.com/file/d/1lYluHiGl4UVnp9bbPjcIOid09NnbYifX/view?usp=sharing

It takes 30 seconds for a simple text change to apply. With babel-loader 8.2.5 or below, takes 2-3 seconds max.

from babel-loader.

@elitenas Can you attach the specific reproduction steps?

Here is mine:

npm i
npm run web
# Manually edit src/screens/Authentication/Login.tsx
# Observe http://localhost:19006/

The page reload is instant, less than 3 seconds consistently.

from babel-loader.

@JLHwung My repro steps were similar.

1. npm install
2. npm start
3. press w
4. make a change to login page

The only thing i would point out is make sure you are on npm > 8.3.x. I am not in front of my my work laptop but I believe we are on 8.19.2. Otherwise the overrides object in package.json is ignored if you are on npm below that.

Let me know if this doesn't work. I had another developer reproduce this well. So i can double check.

Expo by default doesn't use babel-loader 8.3.0 yet

from babel-loader.

Let me know if this doesn't work.

$ npm -v
9.4.0
$ npm ls babel-loader
[email protected] /path/to/my-app
└─┬ @expo/[email protected]
  └── [email protected] overridden
$ cat node_modules/babel-loader/package.json | grep version
  "version": "8.3.0",
    "preversion": "yarn run test",

Expo by default doesn't use babel-loader 8.3.0 yet

Yes I am aware of that. I also tried bumping @expo/webpack-config to 8.0.1, hotloading is still instant.

from babel-loader.

It takes about 10s for my test, and I will downgrade the loader for testing.

By the way, it is recommended to update webpack, because repro does not work by default in the new version of node.

from babel-loader.

Just tried on a brand new laptop and it takes around 10 seconds. Keep in mind this is a barebone project. In our main project its taking 45 seconds.

from babel-loader.

@liuxingbaoyu @elitenas Okay, maybe this issue is platform dependent. I am on arm64.

from babel-loader.

Changes brought by #971.
Since externalDependencies has a value, caching is disabled.
The fix seems to be to check if they are up to date?

from babel-loader.

Haven't tested yet but this seems about right. I wasn't able to reproduce the slowness in babel-loader 9.1.2 after upgrading to expo 48

from babel-loader.

@liuxingbaoyu any update on this for 8.x.x?

from babel-loader.