b13 / geocoding Goto Github PK

https://packagist.org/packages/b13/geocoding#dev-master doesn't show the same last commit like github.

TYPO3 v8 has switched to Doctrine DBAL, this should be supported to ensure compatibility with TYPO3 v9 which will drop the old DB layer.

GeoService.php, near line 230:
$cacheManager = GeneralUtility::makeInstance('TYPO3\CMS\Core\Cache\CacheMananger');

should be:
$cacheManager = GeneralUtility::makeInstance('TYPO3\CMS\Core\Cache\CacheManager');

Is there a plan to update the extension?

When using the Geocoding API with a key, the service needs to be called via https:

https://github.com/b13/t3ext-geocoding/blob/1b61fdd7e912b4378a8a1fabcb4fa4e1f5b5c86f/Classes/Service/GeoService.php#L43

Regards,
Uwe Michelfelder

Hi,

even if a api key is configured in the extension settings, it won't be used, because it is commented out:

https://github.com/b13/t3ext-geocoding/blob/1b61fdd7e912b4378a8a1fabcb4fa4e1f5b5c86f/Classes/Service/GeoService.php#L60

Regards,
Uwe Michelfelder

Is neither city nor zip is entered the check if (empty($addressPart)) fails because a white space makes $addressPart being not empty.

Would be a solution to check with strlen(trim($addressPart)) <= 0 instead.

Background:
Otherwise this can lead to two consecutive commas. As a result the request leads sometimes to ZERO_RESULTS.

Is the solution okay? Shall I make a PR?

Do you plan an update of your extension in the near future?

It would be nice to have an error message if something is wrong with the API key.

Had for example the following problem:

{
   "error_message" : "This API key is not authorized to use this service or API.",
   "results" : [],
   "status" : "REQUEST_DENIED"
}

Will create a PR.