Giter Club home page Giter Club logo

geocoding's Issues

Add support for TYPO3 v8 DBAL

TYPO3 v8 has switched to Doctrine DBAL, this should be supported to ensure compatibility with TYPO3 v9 which will drop the old DB layer.

typing error in GeoService.php

GeoService.php, near line 230:
$cacheManager = GeneralUtility::makeInstance('TYPO3\CMS\Core\Cache\CacheMananger');

should be:
$cacheManager = GeneralUtility::makeInstance('TYPO3\CMS\Core\Cache\CacheManager');

Check for empty `$addressPart` can fail

Is neither city nor zip is entered the check if (empty($addressPart)) fails because a white space makes $addressPart being not empty.

foreach ([$street, $zip . ' ' . $city, $country] as $addressPart) {
if (empty($addressPart)) {
continue;
}
$addressParts[] = trim($addressPart);
}
$address = ltrim(implode(',', $addressParts), ',');

Would be a solution to check with strlen(trim($addressPart)) <= 0 instead.

Background:
Otherwise this can lead to two consecutive commas. As a result the request leads sometimes to ZERO_RESULTS.

Is the solution okay? Shall I make a PR?

Add error message for Google Maps API request

It would be nice to have an error message if something is wrong with the API key.

Had for example the following problem:

{
   "error_message" : "This API key is not authorized to use this service or API.",
   "results" : [],
   "status" : "REQUEST_DENIED"
}

Will create a PR.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.