Allow to add additional tags in reservation about ipam HOT 6 CLOSED

Hi @DCMattyG , thanks for your quick response.

Totally agree about using the term "metadata" instead of "tags",
I used the "tag" concept because I see that the application already uses it, and I intended to implement the functionality I need being the most minimally invasive, but any option would be valid for us.

Basically what we need is a simple description, which could be achieved by adding a simple text field.

Totally agree that displaying a tooltip on a floating window is not the most stylish and practical UI implementation ;)
We will adapt to the implementation that you consider most optimal, and will align the terraform provider to it.

Thanks!!

from ipam.

Hello @XtratusCloud, thanks so much for submitting this feature request!

First and foremost, I love this and I'm happy to incorporate this into Azure IPAM.

Couple of things:

1. The term "tags" is a very Azure/Cloud specific term. Would it make more sense to call the additional field "metadata" which woulda align with other API's that already exist within Azure IPAM?
2. Displaying a huge list of Key/Value pairs in a tiny column as you've shown in your mocked-up UI above doesn't feel like the best way to bubble this data up to the UI. I would imaging this can be extremely hard to ready, especially if users had a significant number of "tags" or "metadata" they were passing in.

Do you think an arbitrary dictionary of key/value pairs makes sense here? What type of data are YOU using this for, and could those same purposes be applied to other users (e.g. is this only a description, or is there something else that is important here)?

Very much appreciate the feedback and I'm quite sure we can get this folded in right away. Let's just make sure we're thinking through the proposed structure and it's intended use cases together. Thanks!

from ipam.

Thanks for the feedback @XtratusCloud!

In that case does it make sense just to add an optional description field to the API, or is there a need where a number of key/value pairs would need to be appended?

from ipam.

Hi @DCMattyG ,
We only needs to be able to add a description to the reservation, a text field would be fine.
But if you think that adding a "metadata" collection could be useful for other users, will also be good.

Thanks!!

from ipam.

I have tested the existing implementation in the "vwan-support" branch, which allows you to specify a description when creating a reservation, and it covers our needs perfectly.

@DCMattyG , this request can be closed at your convenience.

from ipam.

Hi @XtratusCloud, this is now completed and had been merged into main via PR #113. Thank you for all of your support in bringing this feature into Azure IPAM!

from ipam.