Giter Club home page Giter Club logo

mod-random-enchants's Introduction

logo AzerothCore

RandomEnchantsModule

  • Latest build status with azerothcore:

Build Status

  • Make sure to support the main project:

https://github.com/azerothcore/azerothcore-wotlk/

  • This is a "fun" script/module converted from an LUA script I found, credits to whoever did this originally

What this does

  • Will sometimes add random enchantments on any item Looted, Quest Rewarded or Profession created

Configurable

  • Login message for the module (on, off and what to display)
  • Select if you want to enchant loot, quest reward, profession or all
  • Modify the source to mess with the chances of enchantment

mod-random-enchants's People

Contributors

3ndos avatar bytesgalore avatar day36512 avatar helias avatar locus313 avatar milestorme avatar mitradis avatar pangolp avatar yehonal avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

mod-random-enchants's Issues

Compile Error

/home/ubuntu/azerothcore/modules/mod-random-enchants/src/RandomEnchants.cpp:134: 34: fatal error: no member named 'PQuery' in 'DatabaseWorkerPool'; did you mean 'Query'?
QueryResult qr = WorldDatabase.PQuery("SELECT enchantID FROM ite m_enchantment_random_tiers WHERE tier='%d' AND exclusiveSubClass=NULL AND class= '%s' OR exclusiveSubClass='%u' OR class='ANY' ORDER BY RAND() LIMIT 1", tier, Cl assQueryString.c_str(), item->GetTemplate()->SubClass);
^~~~~~
Query
/home/ubuntu/azerothcore/src/server/database/Database/DatabaseWorkerPool.h:119:1 7: note: 'Query' declared here
QueryResult Query(std::string_view sql, Args&&... args)
^
1 error generated.
make[2]: *** [modules/CMakeFiles/modules.dir/build.make:1532: modules/CMakeFiles /modules.dir/mod-random-enchants/src/RandomEnchants.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

[Feature]disable enchants in bg and arena

For more balanced pvp competition a feature that disables the random enchants on items while in bg or arena and re enables them after the bg or arena would be very good

Not working correctly in group

it wont enchant when an item that is rolled for, you have to pass on it and pick it up, module needs updating to fix this

Cannot be compiled

I have the following warning when trying to compile with the azerothcore commit ce8db43

RandomEnchants.cpp:37:20: fatal error: overlapping comparisons always evaluate to false [-Wtautological-overlap-compare] if ((Quality > 5 && Quality < 1)/*eliminates enchanting anything that isn't a recognized quality*/ || (Class != 2 && Class != 4)/*eliminates enchanting anything but weapons/armor*/) ~~~~~~~~~~~~^~~~~~~~~~~~~~

[Feature Request] Improve Features / Config

Here are some suggestions for huge improvements to the module -

All as optional / configs.

  1. Enchantments are "tiered" in the database. Offer an option to enable/disable tiers. (E.g no lvl 80+ enchants on a server like ChromieCraft capped at lvl 19/29).

  2. Functionality to enable/disable random enchants on items below a certain level. (E.g no lvl 1 gear with +60 fire damage)

  3. Functionality to enable/disable random enchants on characters below a certain level. (E.g no lvl 1s with +60 fire damage)

  4. Functionality to enable/disable random enchants on BOE or non-binding items. (E.g no mailing crazy enchants to others)

4b) Optional: Other modules achieve this by "binding" the item when it is enchanted. Problem with this is if you're deliberately farming for BOE blues/epics and it forcibly binds because of an enchant you didn't ask for.

  1. Functionality to pair item tiers to levels. E.g Item levels 1-30 tier 1, item levels 31-60 tier 1+2, etc.

  2. Functionality to limit random enchants on rarity. E.g no grey/white items with enchants.

  3. Functionality to disable random enchants on slots. E.g no more tabard/shirts with enchants.

  4. Functionality to "smart detect" the item and assign stats relevant to the item (like https://github.com/AnchyDev/StatBooster/tree/master )

  5. Popup or sound alerts for enchanted items. Text chat is visible but not noticeable.

  6. configurable notification(s) for the looted items

  7. add new database columns so that random enchants aren't just using the gem slots which then get them overwritten by adding/removing gems to items

Some/many of these features were figured out by statbooster which was never finished, which in turn lacks many features (randomness/double ench/triple ench).

Both modules have strengths/weaknesses.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.