azer / logger Goto Github PK

Running the example code:

package main

import (
    "github.com/azer/logger"
    "time"
)

var log = logger.New("app")

func main() {
    log.Info("Starting at %d", 9088)

    log.Info("Requesting an image at foo/bar.jpg")
    timer := log.Timer()
    time.Sleep(time.Millisecond * 250)
    timer.End("Fetched foo/bar.jpg")

    log.Error("Failed to start, shutting down...")
}

with version 71c896b yields the following error:

panic: assignment to entry in nil map

goroutine 1 [running]:
panic(0xc58e0, 0xc820064050)
    /usr/local/go/src/runtime/panic.go:464 +0x3e6
/vendor/github.com/azer/logger.New(0x10baf8, 0x3, 0xc820050000)
    /vendor/github.com/azer/logger/logger.go:26 +0xaa
main.init()
    /example.go:8 +0x65
exit status 2

Reverting to d8432cee resolves the issue:

11:39:22.887 app: Starting at 9088
11:39:22.887 app: Requesting an image at foo/bar.jpg
11:39:23.142 app(254.627113ms): Fetched foo/bar.jpg
11:39:23.142 app(!): Failed to start, shutting down...

Official log package provides SetOutput(w io.Writer) for change writer os.Stderr to another.

Hey, this logger looks great- a good blend of simple API, levelling/app-segregation, and nice design.

One feature I'd really like, though, is the ability to programmatically enable logs and log levels, rather than relying on the environment variable method. If I'm already defining a CLI interface for my application I'd prefer to add a "-v" / "-vv" flag to enable various log levels or log types.

It looks like this would be easy to do if the "enabled" map were exposed publicly. Alternatively, if a setter function were added to complement IsEnabled, so you could call a function with a logger name and a state to enable. Something like SetEnabled(logname string, setstate bool) error.

I can write it up and PR, if you like?

Hello, under what license is this project released under ? Thank-you.