azanor / baubles Goto Github PK

Title is pretty self-explanatory. Running revision f2e8633

Normal inventory hotkey will close an open inventory (such as a chest or crafting grid) when pressed. The Baubles hotkey does not.
EDIT: Seems to have been fixed by 1.0.0.7 while I wasn't looking.

When I die, my baubles are totally gone, not dropped on the ground nor present in player's slots.
This happens randomly, not always, so I'm not sure how to reproduce. Checked with NEI's magnet it doesn't fall somewhere out of sight.

FTB Mage Quest pack
Minecraft 1.7.10
Thaumcraft 4.1.2.4

I wanted to search for something in the creative gui and the Baubles Hotkey closed it.

The most famous mod pack that your mods are included in is probably the Direwolf20 mod pack, which also includes Tinkers Construct mod. Having both of these mods installed could possibly create confusion as to which ring, amulet(necklace), or belt goes where and such. With that said, I love the concept of having a separate mod for these items, but I also favor the tab system that the T'Construct mod uses. Do you think it would be possible for you and mDiyo to collaborate on this?

How to reproduce:

• Get a bauble that has some sort of HUD element or client indication
• Equip it on a dedicated server
• Close your client
• Reopen your client
• Log back into the server

The element is gone, because the server doesn't send the packets over to the client.

As a suggestion, could you consider making a version of onWornTick() that respects EntityPlayer as opposed to the current EntityLivingBase. This would be especially useful to increase the players capabilities using things such as the speedOnGround variable, the speedInAir variable and to test to see if the player is blocking, without needing to add potion effects.

Using forge-1.7.10-10.13.0.1183

[09:04:05] [Server thread/INFO]: dehtrim_mwb has just earned the achievement [Taking Inventory]
[09:04:21] [Server thread/INFO]: dehtrim_mwb lost connection: TextComponent{text='Disconnected', siblings=[], style=Style{hasParent=false, color=null, bold=null, italic=null, underlined=null, obfuscated=null, clickEvent=null, hoverEvent=null}}
java.io.FileNotFoundException: ./apocalypse/players/dehtrim_mwb.baub (No such file or directory)
[09:04:21] [Server thread/INFO]: dehtrim_mwb left the game
at java.io.FileOutputStream.open(Native Method)
[09:04:21] [Server thread/ERROR] [Baubles]: Could not save baubles file for player dehtrim_mwb
at java.io.FileOutputStream.(FileOutputStream.java:221)
at java.io.FileOutputStream.(FileOutputStream.java:171)
at baubles.common.lib.PlayerHandler.savePlayerBaubles(PlayerHandler.java:143)
at baubles.common.network.EventHandlerNetwork.playerUpdateEvent(EventHandlerNetwork.java:26)
at cpw.mods.fml.common.eventhandler.ASMEventHandler_86_EventHandlerNetwork_playerUpdateEvent_PlayerEvent.invoke(.dynamic)
at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:51)
at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:122)
at cpw.mods.fml.common.FMLCommonHandler.firePlayerLoggedOut(FMLCommonHandler.java:554)
at net.minecraft.server.management.ServerConfigurationManager.func_72367_e(ServerConfigurationManager.java:305)
at net.minecraft.network.NetHandlerPlayServer.func_147231_a(NetHandlerPlayServer.java:628)
at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:158)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:335)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

Thanks again for this wonderfull mod. We are playing on the regrowth modpack, and have come across an issue that is a slight anoyance, and was wondering if you would be willing to think about the solution we came up with.

First, thank you for adding the ability to equip the focus pouch into the bauble slot. This is wonderfull. except for one thing. To access the focus's requires a multitude of steps.

We humbly request an hot key be added to access the an inventory when equipped in the baubles slot. This could be defaulted off as to not confuse players who would not use this function.

Added benifits is that this would allow other mods to that add a storage type item to be easily accesed while also equipped in these slots. (F.M. modifies the pouch is another example)

As always thank you for taking the time to consider it's request.

several times now I have tested this and my inventory did not drop on the ground whenever I died with a bauble equipped. This happens with both Botania Baubles and the sample Bauble in the API. I have not tested this with baubles from Thaumcraft.

This happened to me using 1.7.2 and 1.7.10.

I also remember this happening in a Direwolf20 video where he killed himself with the Bound blade from Blood Magic while wearing a Botania Bauble.

Here is the error I receive when I play my singleplayer world:

java.io.FileNotFoundException: C:\Users\Samuel\Downloads\MultiMC\instances\WipCraft\minecraft\saves\Lets Play WiP No_ 1\players.baub (The system cannot find the path specified)
at java.io.FileOutputStream.open(Native Method)
at java.io.FileOutputStream.(Unknown Source)
at java.io.FileOutputStream.(Unknown Source)
at baubles.common.lib.PlayerHandler.savePlayerBaubles(PlayerHandler.java:143)
at baubles.common.lib.PlayerHandler.loadPlayerBaubles(PlayerHandler.java:98)
at baubles.common.network.EventHandlerNetwork.playerLoggedInEvent(EventHandlerNetwork.java:16)
at cpw.mods.fml.common.eventhandler.ASMEventHandler_107_EventHandlerNetwork_playerLoggedInEvent_PlayerLoggedInEvent.invoke(.dynamic)
at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:51)
at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:122)
at cpw.mods.fml.common.FMLCommonHandler.firePlayerLoggedIn(FMLCommonHandler.java:549)
at net.minecraft.server.management.ServerConfigurationManager.a(ServerConfigurationManager.java:180)
at cpw.mods.fml.common.network.handshake.NetworkDispatcher.completeServerSideConnection(NetworkDispatcher.java:173)
at cpw.mods.fml.common.network.handshake.NetworkDispatcher.completeHandshake(NetworkDispatcher.java:446)
at cpw.mods.fml.common.network.internal.HandshakeCompletionHandler.channelRead0(HandshakeCompletionHandler.java:17)
at cpw.mods.fml.common.network.internal.HandshakeCompletionHandler.channelRead0(HandshakeCompletionHandler.java:11)
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98)
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337)
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323)
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111)
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337)
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323)
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785)
at io.netty.channel.embedded.EmbeddedChannel.writeInbound(EmbeddedChannel.java:169)
at cpw.mods.fml.common.network.internal.FMLProxyPacket.func_148833_a(FMLProxyPacket.java:77)
at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:212)
at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:165)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:659)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:111)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)

Bug found on http://pastebin.com/ms1g5d4B . When the Bauble runs out of durability (see line 51), the Bauble plays the break sound, but does not break. Instead, it is replaced with a full durability Bauble of the same type.

This makes the API rely on the core file for compilation, which no sane modder will be including :P

When the player dies with keepInventory set to true, baubles still drop upon death instead of remaining in the player's inventory.

I think it's might be a bug, if you die with something equipped on a extra slot, only one item of all inventory is dropped.

Add support for battlegear so that the buables button does not go away in battlegear inventory and the battlegear buttons not go away in buables inventory!

Log: http://pastebin.com/f1NKUA3d

When the player has a potion effect in his inventory the button to go to the botania mod moves to the right:

Usually:

Came across this graphical glitch on the latest build, when ever you remove a bauble it causes the buff to spaz out as you can see in the image below:

Hello and thank you for the wonderful mod / api. I do have a question for you

1. We are on a Server
   • As such, we deal with a lot of grief and theft
   • Sometimes we need to discreetly check what a person has in their inventory
2. So we were wondering if one of the following would be possible
   • Add in an OP'ed only command so that Admins can view / edit another players baubles slots
   • Open the slots to the forge essentials API so it works with /openinv command on servers
   • Some other wonderful idea that you might have that I have not thought of.

Thank you for taking the time to read this.

How do I install this in eclipse? I keep getting "The source attachment doesn't contain the source for..." I have downloaded the deobf from minecraft forums

When joining a world(just tested on singleplayer) and picking up an item the item is not shown until you open the inventory (deobfuscted environment).

Also it would be nice to have a creative baubles inventory and when sitting on a horse the horse inventory does not open. Just check if the player rides a horse and show their inv instead of doing nothing.

Great mod btw!

Similar to armor, baubles should be able to be right clicked to be automatically equipped.

I notice this warning in my Minecraft logs.

[13:29:33] [main/WARN]: Error parsing manifest entries in 'C:\Users\Enderandrew\AppData\Roaming.minecraft\mods\1.7.10\Baubles-1.7.10-1.0.1.5.jar'

Hello. Can you move your API to separate project? It will allow to use it as a git submodule without exporting all your mod's sources. At the same time submodules give a more flexible way to configure and deploy project and all its dependencies(one of them is your API)

You can read more about submodules here https://git-scm.com/book/en/v2/Git-Tools-Submodules
For gradle configuration examples you can look at Forestry(https://github.com/ForestryMC/ForestryMC/blob/dev/build.gradle#L47), Railcraft(https://github.com/CovertJaguar/Railcraft/blob/master/build.gradle#L26) or Gravestone(https://github.com/NightKosh/GraveStone-mod/blob/master/build.gradle#L36) repositories.

Other players in the server don't know which baubles are equipped which causes some desync on some cases.

I'm using Baubles 1.0.0.16 and Minecraft 1.7.10 (but this also happens in 1.7.2).
Upon starting a new single-player world, I get these errors in the console: http://pastebin.com/jwLcU77f
It's not enough to crash; things still work. But they also come up whenever I open the Baubles inventory. And, sure enough, if I equip a bauble like the Miner's Ring and then quit and reload the level, it's gone.
Is this some kind of permission error where it can't access files at that directory or something? I'm not entirely sure what's going on.

The new button will only show up after i use the hotkey then when i open and close the inv the button is gone again.
None of my rings or stash or neck work unless i open the baubles inv with the hotkey and remove and place the item ..

Version 1.0.1.2
Forge 10.13.0.1189
MC 1.7.10
Botania items..

Hey Azanor,
Would you ever consider adding a 5th slot for like a back / backpack type thing? I have a few ideas that would be perfect for that kind of slot.
Thanks,
FireBall

Baubles 1.0.0.16
Minecraft 1.7.2

Also may be related with this https://github.com/Azanor/thaumcraft/issues/986

So.. I noticed that everytime I start my client and my server the Baubles mod gets deleted!? How? And why? I even changed ownership to root and only read permission for the others, that didnt help. To clarify, Im not running anything as root.

This is freaking me out. Im running my own modded Forge server.

For some reason the NEI Item Subsets don't work from within the Baubles inventory. They do work without issue from the standard inventory. From looking at the Minecraft forums, this bug appears to have been around since at least Aug 2014.

NotEnoughItems-1.7.10-1.0.5.110-universal
Baubles-1.7.10-1.0.1.10

I have installed a Forge server and it won't let me open the Baubles tab. I have tried other server and baubles versions installed everything again and other things but it still doesn't work .I have seen other people have this problem but I have found no reasons or solutions as of yet.

My onUnequipped function removes the haste buff. It isn't called when the item is replaced by another.
Code: https://github.com/Vazkii/Botania/blob/master/MODSRC/vazkii/botania/common/item/equipment/bauble/ItemMiningRing.java

I put in the ftb unstable pack 1.7.2 and after i launch it, the game crashes and baubles is gone. don't know if you need more info.

Title, this causes baubles that add stats and remove onUnequipped to malfunction.
EDIT: Turns out it calls onEquipped, onUnequipped and onEquipped in that order. Put a println on both functions and you can see it.

I get this when compiling:

/home/user/projects/experiments/Baubles/build/sources/java/baubles/common/network/PacketSyncBauble.java:37: error: exception IOException is never thrown in body of corresponding try statement
        try { pb.writeItemStackToBuffer(bauble); } catch (IOException e) {}
                                                   ^
/home/user/projects/experiments/Baubles/build/sources/java/baubles/common/network/PacketSyncBauble.java:46: error: exception IOException is never thrown in body of corresponding try statement
        try { bauble = pb.readItemStackFromBuffer(); } catch (IOException e) {}

Not sure why this happens, just curious if it is a bug or if I did something wrong. Removing the try statement seems to not have any bad effects, in my small tests.

UPDATE:

Turns out the problem is stranger. My commands and their results can be found here: http://paste.ubuntu.com/7984700/.

Not sure if global is the correct term to use for this. I believe tinkerer's construct also still exhibits this issue with their knapsack and additional 'armor slots'. My goal is to use the "Sync" mod in conjunction with mods that utilize the Baubles mod. I'm also trying to use OpenBlocks as well, but that should be.. mostly unrelated. The sync mod creates clones of the player that have separate inventories. When I change from my original body to clone 1 my original body's inventory, hotbar, and armor remain on my original character. If I'm playing on a clone and I die, I return to the body of another clone or to my original body.

The problem is that baubles exist across the original body and all clones, they do not stay with the body they were equip on. The additional resulting problem is that if I die on a clone the bauble will no longer be equipped on the intended body, for it dropped upon death.

I made a fresh instance using MultiMC to confirm the behavior. It was running Minecraft 1.7.10 with Forge 10.13.2.1307. Mods installed were Baubles 1.7.10-1.0.1.10, iChunUtil-4.1.3, Sync-4.0.0, OpenBlocks-1.7.10-1.3-snapshot-556, OpenModsLib-1.7.10.0.6-snapshot-307. I said 'mostly unrelated' in regards to OpenBlocks before because I didn't test if the Baubles are dropped to the floor-- I tested if they are dropped into the OpenBlocks grave that is left behind on death (which they are.)

My fml-client-latest.log file is apparently slightly too big to upload to pastebin, so if you think it's necessary please recommend somewhere for me to upload it ; ;.

http://pastebin.com/dYV4SD6i

So I got botania baubles and the aura band, the mana band, AND souljours sash all aren't working. Funny enough, same problem happened with thaumcraft baubles.

I can confirm this is indeed a bug, I've googled the issue and a few people have it and all where open to LAN and playing with there friends. The baubles can be placed in the bauble slots just fine, they just do NOTHING. Absolutely NOTHING. Even after charging my aura band manually, my souljour sash stayed kaput.

Crash in dev when opening Baubles inventory.
http://pastebin.com/CnkvtTdK
Baubles 1.8-1.1.0.0 deof
Forge 11.14.0.1281

If you shift-click an item out of a slot, onUnequipped is called twice on each side.

When you change your username with the new mojang feature from today all items in the bauble slots are gone.
Reason: The items are save in .baub and you need to you the uuid.

If you don't have the correct mod loadout and try to connect to a server on which you have baubles, once you update and reconnect, all the baubles are gone.

I'm guessing this has something to do with not getting as far as loading the baubles for a player, but then saving their now empty inventory when disconnecting.

It's happened 3 times to me on Forgecraft 2 now, and a couple other players too. Each time was immediately after a rejected connection for incorrect mods.

Apologies for the lack of concrete information, it's happened over the space of a few weeks.

When a Bauble is equipped, is it possible to make it so that the background image of that slot is not shown? This means that I can use any texture for a Bauble without having the slot icon showing in the background. I'm sure this will be useful for others using the API, as well as resource pack creators.

I'm playing on a LAN server with my friend and anytime I try to equip a Botania bauble it refuses to work. (eg. Bands of Mana don't supply any mana and the Soujourner's Sash doesn't give a speed or jump height buff. It does, however, give the step assist)
However, if I load a single-player save with a bauble equiped then quit and load the server without shutting down Minecraft, the effect carries over with me whether or not the bauble is equipped on the server.
This occures in a world with only Baubles and Botania installed.
I'm using Baubles-1.7.10-1.0.1.7, Botania r1.2-112, and Forge 10.13.0.1208
I should note that the Thaumcraft baubles work perfectly when installed as a test.

I have 2 different mods that add belts that are supposed to add step-up functionality like the Boots of the Traveler but they will not work in the Baubles slot. Botania r1.0-45 and Mystical Trinkets v1.3.0. The Stepping Belt from Mystical Trinkets will however work as long as I am holding it, but as soon as i put it in the belt slot it fails to work anymore. I have tested this with Baubles versions 1.0.0.13 through 1.0.0.16 and still no luck.

I have posted this issue on the Botania Github and will also try to post it for Mystical Trinkets if I can find their issue tracker as well. Please help if you can.

The other day me & my roomie updated to Thaumcraft version 4.1.1.14, and (lackaday) he died from a creeper attack; but the only items he dropped were his baubles (and then, only ones that were equipped his baubles inventory)

We tested this a few times, and each time he died the only items dropped were the baubles he had equipped.

When pressing the Inventory key (default E), open GUIs are closed. It would be nice to be able to do this with the Baubles GUI as well, so changing the Baubles key to E doesn't require us to use Esc for closing other GUIs quickly.