ayyess / overlays Goto Github PK

Hi,

I've added this package to the official Gentoo repository: https://packages.gentoo.org/packages/app-laptop/mbpfan

Would you like to be listed as the primary or secondary maintainer for it?

If you less the fzf file, there is a note: This script is no longer maintained. Use the new Go version.
The ebuild currently installs the old ruby script. The new Go version is in src/. I don't know anything about Go, so I'm not even sure how to compile it (have to play with it more). If you can do it, would be nice. The ruby dependency can be dropped then. Maybe it would make sense to split the build in two - one depending on ruby and offering the old script (for people who are really bothered to install Go), another depending on Go and offering just the new version. The newer fzf features are only available in the Go version.
Side note, the install.sh script have an option to download a pre-compiled binary (but I guess it's not the Gentoo way, is it? Unless it's a binary package ebuild).

https://github.com/andjscott/overlays/blob/master/app-misc/fzf/fzf-0.12.0.ebuild#L24
The file completion.bash should not be installed into /usr/share/bash-completion/completions, but rather to /etc/bash_completion.d.
The first dir holds completions that are loaded on-demand for particular commands. Installing completion.bash there as fzf will source the file only when the user types fzf and press tab twice. But completion.bash doesn't contain completions for the command fzf, it contents completions that add ability to use ** to various standard commands (e.g. cp, cd, unset etc.). So this file should be sourced when bash_completion is initialized - means it should be in /etc/bash_completion.d.

On a side note, it would be nicer if the downloaded distfile was saved as fzf-0.12.0.tar.gz, not 0.12.0.tar.gz, is that possible with ebuilds?