ay2122s2-cs2103t-w11-2 / tp Goto Github PK

This project forked from nus-cs2103-ay2122s2/tp

License: MIT License

Shell 0.61% Java 97.91% CSS 1.48%

tp's Introduction

HRConnect

This product is for tech HR recruiters who prefer to use CLI to store contacts of job applicants and their respective interviews as well as keep track of the status of each applicant through the application process.

tp's People

Contributors

Watchers

Forkers

eman-kom rcjj98 brigittesantoso imrajsinghsandhu

tp's Issues

[PE-D] User experience bug when exporting data.

The application does not tell the user what the error was.

Labels: type.FunctionalityBug severity.Medium
original: Benjykoh/ped#8

[PE-D] Link from UG should direct to releases

Link from UG should direct to releases instead of tP homepage. Otherwise, may confuse users where to actually find it if they are not familiar with GitHub.

As a side note, Prof's link to download the jar file also links to the release page.

Labels: type.DocumentationBug severity.VeryLow
original: bakano98/ped#2

Interview Features

Import Feature

[PE-D] Implementation of delete

Not sure on the rational of why it doesn't allow user to delete just because there is an interview present. A hassle to change interviewee to rejected, then delete interview, then delete the person.

Labels: type.FeatureFlaw severity.Low
original: Benjykoh/ped#13

Update the DG: Use Cases

[PE-D] User experience bug in importing

Application just says entry is already in address book, not sure if it refers to entry 2 in addressbook or entry 2 in csv file. Perhaps can specify. If it refers to entry 2 in addressbook, maybe skip over it instead of aborting all.

Labels: type.FeatureFlaw severity.Medium
original: Benjykoh/ped#9

[PE-D] Example on error message shown in UI not valid

However, the example shown in the UG is correct

Labels: type.FunctionalityBug severity.Low
original: wxliong/ped#3

[PE-D] Wrong error message shown

Notice that I am in the Interview page. Attempting to edit something in Task page while in Interview page shows the wrong error.

For reference, here is the Task page.

The same error can be replicated by doing it in any of the other pages as well.

Labels: severity.Low type.FunctionalityBug
original: bakano98/ped#7

[PE-D] Header not shown properly in UG

Occured twice, once at General Features and the other at Applicant Features

Labels: severity.VeryLow type.DocumentationBug
original: wxliong/ped#2

Edit edit command

[PE-D] Error found when importing data.

If I exported the data, then I edit, then I realised got an error in the near future.

I want to version control and export back the old file. But application does not allow it.

Labels: severity.High type.FunctionalityBug
original: Benjykoh/ped#10

[PE-D] find command is not the same as advertised in UG

Meaning I should be able to do something like find [t] g/contact. However, if I were to do that:

It only works if I do find [t] g/h/KEYWORDS. If no g/ flag, everything fails.

Labels: severity.Medium type.FunctionalityBug
original: bakano98/ped#5

Update the DG: User Profile, Value Proposition, User Stories

[PE-D] Suggestion: Add a caveat in the UG to only allow `clear [p]` if the interview list is empty.

I wasn't expecting clear [p] to fail if the interview list is not empty as it was not stated in the UG.

Perhaps you could include that so that it won't be as unexpected for users.

Labels: severity.VeryLow type.DocumentationBug
original: bryans17/ped#3

Add delete by name command

[PE-D] Able to create an interview for a person that does not exist by editing JSON

By editing the JSON, I'm able to have an interview for a non-existent person.

The person list:

The interview list:

Labels: severity.Medium type.FunctionalityBug
original: bryans17/ped#5

Export Feature

Update the UG

[PE-D] Phone Numbers allows for 3 digit numbers

Allows for 3 digit phone numbers which might not be practical. I personally do not know of any countries using 3 digit phone numbers. But not too big of an issue.

Labels: severity.VeryLow type.FunctionalityBug
original: bryans17/ped#4

Update the DG: Non-Functional Requirements

Update the DG: Glossary

Edit add command

Update project website: AboutUs, README

[PE-D] Able to do clear [p] despite Tasks not being empty

As a HR, if my "People" and "Interview" is cleared, I would not be able to say, "Contact Jerry to ask for John's number" because I have am unable to contact Jerry anymore.

Labels: type.FeatureFlaw severity.Low
original: bakano98/ped#4

[PE-D] Attempting to import a .json file with duplicate data throws wrong error

JSON since I cannot attach file:

{ "persons" : [ { "name" : "Alex Lee", "phone" : "87438807", "email" : "[email protected]", "address" : "30 Defu Lane 10 #04-104", "job" : "Software Engineer", "stage" : "INPROGRESS" },{ "name" : "Alex Lee", "phone" : "87438807", "email" : "[email protected]", "address" : "30 Defu Lane 10 #04-104", "job" : "Software Engineer", "stage" : "INPROGRESS" }, { "name" : "Alex Tan", "phone" : "94825832", "email" : "[email protected]", "address" : "1 Finlayson Green #13-00", "job" : "Data Scientist", "stage" : "ACCEPTED" }, { "name" : "Alex Chan", "phone" : "82619180", "email" : "[email protected]", "address" : "6 Ang Mo Kio Industrial Park 2", "job" : "Data Scientist", "stage" : "REJECTED" }, { "name" : "Alex Lee Kai Jie", "phone" : "92462946", "email" : "[email protected]", "address" : "76 Lorong 19 Geylang #03-01", "job" : "Data Scientist", "stage" : "INPROGRESS" }, { "name" : "Steven Tan Kai Ming", "phone" : "84303712", "email" : "[email protected]", "address" : "10 Admiralty Street #01-78 North Link Building", "job" : "Mobile Engineer", "stage" : "INPROGRESS" }, { "name" : "Lee Kai Jie", "phone" : "92821318", "email" : "[email protected]", "address" : "252 Jurong East Street 24 #01-139", "job" : "Software Engineer", "stage" : "ACCEPTED" }, { "name" : "Janet Tan", "phone" : "94303312", "email" : "[email protected]", "address" : "10 Admiralty Street #01-78 North Link Building", "job" : "Software Developer", "stage" : "REJECTED" }, { "name" : "Lew Jia Xin", "phone" : "92573826", "email" : "[email protected]", "address" : "261 Yishun St 22 #01-137", "job" : "Software Developer", "stage" : "ACCEPTED" }, { "name" : "Tan Jia Ling", "phone" : "93375454", "email" : "[email protected]", "address" : "12 New Industrial Road #05-05 Morningstar Centre", "job" : "Data Analyst", "stage" : "ACCEPTED" }, { "name" : "Zhou Jia Ling", "phone" : "92462146", "email" : "[email protected]", "address" : "80 Marine Parade Rd #21-08", "job" : "Software Engineer", "stage" : "INPROGRESS" } ], "interviews" : [ { "person" : { "name" : "Steven Tan Kai Ming", "phone" : "84303712", "email" : "[email protected]", "address" : "10 Admiralty Street #01-78 North Link Building", "job" : "Mobile Engineer", "stage" : "INPROGRESS" }, "date" : "2022-01-17", "time" : "13:05" }, { "person" : { "name" : "Alex Lee", "phone" : "87438807", "email" : "[email protected]", "address" : "30 Defu Lane 10 #04-104", "job" : "Software Engineer", "stage" : "INPROGRESS" }, "date" : "2022-01-20", "time" : "17:01" }, { "person" : { "name" : "Alex Tan", "phone" : "94825832", "email" : "[email protected]", "address" : "1 Finlayson Green #13-00", "job" : "Data Scientist", "stage" : "ACCEPTED" }, "date" : "2022-01-22", "time" : "16:02" }, { "person" : { "name" : "Alex Chan", "phone" : "82619180", "email" : "[email protected]", "address" : "6 Ang Mo Kio Industrial Park 2", "job" : "Data Scientist", "stage" : "REJECTED" }, "date" : "2022-01-24", "time" : "15:03" }, { "person" : { "name" : "Alex Lee Kai Jie", "phone" : "92462946", "email" : "[email protected]", "address" : "76 Lorong 19 Geylang #03-01", "job" : "Data Scientist", "stage" : "INPROGRESS" }, "date" : "2022-01-28", "time" : "14:04" } ], "tasks" : [ { "header" : "Contact Jerry", "date" : "2022-01-09", "time" : "09:10", "information" : "Ask Jerry for John number" }, { "header" : "Call Thomas", "date" : "2022-01-19", "time" : "19:10", "information" : "Ask when he is free for interview" }, { "header" : "Write report", "date" : "2022-02-01", "time" : "18:20", "information" : "Finish up writing annual report" } ] }

Note that persons 1 and 2 in the JSON file are an exact duplicate of each other. I get this error:

despite all fields being valid, except for the fact that there is duplicate content. Maybe just add "make sure there is no duplicate name"

Labels: severity.VeryLow type.FunctionalityBug
original: bakano98/ped#9

[PE-D] Cosmetic bug in ResultDisplay (AB3 term)

Random white box. Try to work on the CSS file to remove this as it looks rather awkward

You can reproduce this by giving any command that results in the error message being shown on ResultDisplay, then minimise your window.

Labels: type.DocumentationBug severity.VeryLow
original: bakano98/ped#3

[PE-D] Issue with exporting data

UG stated that data exported into .csv file will be seperated by tabs, but does not seem to work as intended.

Labels: type.FeatureFlaw severity.Medium
original: Benjykoh/ped#6

[PE-D] Implementation of Edit Command

In the case when the applicant has an interview and had changed their contact details before completing the interview, the application does not allow the user to edit the details.

Labels: type.FunctionalityBug severity.Medium
original: Benjykoh/ped#2

[PE-D] Unexpected logic flow for error

Attempting to edit a user into one that is already in People throws that error instead of saying that the person already exists, so you cannot edit.

It only throws a duplicate person error when there is no one in the interview. However, logical flow should dictate that you should not be able to edit a person to become a duplicate person whether or not they have an interview.

For reference, here is the Interviews page:

Labels: type.FeatureFlaw severity.Low
original: bakano98/ped#6

Edit find command

Add a skeletal PPP

[PE-D] Discrepancy with input and output

Shows rejected in command line, but shows accepted on the display.

Labels: type.DocumentationBug severity.Medium
original: Benjykoh/ped#12

[PE-D] Bug in implementation of Find

I believe we need to use the prefix g/ for all find commands according to the UG, but the error message does not specify as such.

Labels: severity.Low type.FunctionalityBug
original: Benjykoh/ped#4

[PE-D] Table of Contents not displayed

Labels: severity.Low type.DocumentationBug
original: Benjykoh/ped#11

[PE-D] Finding people by email not working as intended

Given example in the UI not working as intended. The system says the command contains an invalid email

Example given in the application was: find [p] g/n/john j/software engineer g/e/gmail.com

Labels: type.FunctionalityBug severity.High
original: wxliong/ped#6

[PE-D] UG: typo in `find` command

All 3 find commands have wrong example format in the hint. Does not have [p], [t], or [i].

Labels: severity.VeryLow type.DocumentationBug
original: bryans17/ped#6

[PE-D] UG: Dead link to Features.

This link does not scroll my webpage to the required section.

Labels: severity.VeryLow type.DocumentationBug
original: bryans17/ped#2

[PE-D] People with the same name should be allowed to add into the program

Perhaps it will be better to use something else as a unique identifier? Although it is rare someone will have the exact same first and last name but it would be better if it is possible to add someone with the same name.