Giter Club home page Giter Club logo

aws-toolkit-common's Introduction

AWS Toolkit Common

This repo contains shared components for the AWS Toolkits for

Contributers looking to contribute to the above projects should consult the contributing guide (CONTRIBUTING.md) on the repos they are interested in: this repo contains internal components that most contributers would find boring.

Components

Telemetry

Telemetry is the first shared component in this repository. Read about telemetry here.

License

This project is licensed under the Apache-2.0 License.

aws-toolkit-common's People

Contributors

abrooksv avatar andrewyuq avatar awschristou avatar bryceitoc9 avatar ctlai95 avatar damntrecky avatar daviddguez8 avatar dependabot[bot] avatar dhasani23 avatar dhruvigajjar avatar dianaabv16 avatar floralph avatar gsweetwood avatar hayemaxi avatar hunterwerlla avatar jadensimon avatar jsalles avatar justinmk3 avatar kevluu-aws avatar kiiadi avatar laileni-aws avatar leigaol avatar manodnyab avatar nkomonen-amazon avatar rbbarad avatar rli avatar sannicm avatar shruti0085 avatar will-shaohua avatar zixlin7 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

aws-toolkit-common's Issues

generator output doesn't include result and reason by default for all packages

Is your feature request related to a problem? Please describe.
The general discussion is that IntelliJ does not add reason and result to its overloaded definitions output. Same for Visual Studio. For VSCode you can use run or emit reason and resultWITHOUT explicitly defining those fields in thecommonDefinitions.json`

Describe the solution you'd like
I would like to not have to define reason or result in commonDefinitions.json since these fields are considered essential and required by the AWS Toolkit team.

Describe alternatives you've considered

  1. Explicitly define result and reason in commonDefinitions.json.

Additional context
tbd

VSCode `allowedValues` Output string literal Union type - Asking for enum

Is your feature request related to a problem? Please describe.
The current VSCode allowedValues outputs a string literal union type in Typescript:

export type LambdaRuntime = 'dotnetcore2.1' | 'nodejs12.x'

The other implementations for Kotlin and C# output an enum type. The Typescript code standard in PR's keep asking for Enums as the preferred implementation, so we are converting the String literal Union types output from this package to hardcoded Enums... This process seems backwards.

Describe the solution you'd like
I would like the Typescript allowedValues to ouput an Enum type

export  enum LambdaRuntime{
    Dotnetcore21 = 'dotnetcore2.1',
    Nodejs12x = 'nodejs12.x'
}

Describe alternatives you've considered
I have not

Additional context

Kotlin output for enum

/**
 * The lambda runtime
 */
public enum class LambdaRuntime(
    private val `value`: String,
) {
    Dotnetcore21("dotnetcore2.1"),
    Nodejs12x("nodejs12.x"),
    Unknown("unknown"),
    ;

    public override fun toString(): String = value

    public companion object {
        public fun from(type: String): LambdaRuntime = values().firstOrNull { it.value == type }
                ?: Unknown
    }
}

All code snippets referenced from test files generatorOutput.ts and testGeneratorOutput for Kotlin and Typescript within this package.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.