AsyncRequestBody: ability to set content-type about aws-sdk-java-v2 HOT 5 CLOSED

Providing content-type to PutObjectRequest (not the request body) should work fine, I believe.

Can you share a repro code showing how you're making the upload?

from aws-sdk-java-v2.

I do it like this:

public CompletableFuture<PutObjectResponse> uploadContentAsync(ContentId contentId, AsyncRequestBody body) {
	var requestBuilder = PutObjectRequest.builder()
	        .bucket(contentId.bucket())
	        .key(contentId.key()
	        .contentType(body.contentType()); // Use contentType from body here
	
	return client.putObject(requestBuilder.build(), body);
}

So, content-type can be set in requestBuilder, but use AsyncRequestBody for that seems more preferrable to me...

My point here is: why do we need to add extra-argument contentType to uploadContentAsync method, if AsyncRequestBody has quite similar data already?

It is far more obvious and easy to use single source-of-truth instead of always aware, which source is more thuth here...

from aws-sdk-java-v2.

Understood, thank you for the code sample. Feature request acknowledged.

Community note: please show your support by adding a 👍 reaction to the original issue to help us prioritize this request.

from aws-sdk-java-v2.

Feature was implemented in PR 5234 and merged to master

from aws-sdk-java-v2.

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

from aws-sdk-java-v2.