Giter Club home page Giter Club logo

Comments (9)

debora-ito avatar debora-ito commented on July 19, 2024 2

Thank you all, this context would be helpful in the initial description.

Discussed with the team, and we don't want to shade org.reactivestreams so the SDK can use the interoperability between other reactive stream libraries.

We have an internal test for the bundle shading that allows the org.reactivestreams path, the suggestion here is to do something similar in your tests.

from aws-sdk-java-v2.

mukund-thakur avatar mukund-thakur commented on July 19, 2024 1

Okay sounds good. thanks.
We were trying to write a similar test and we can add that to the ignore list.

from aws-sdk-java-v2.

mukund-thakur avatar mukund-thakur commented on July 19, 2024

@HarshitGupta11 could you add some examples of unshaded dependencies?

from aws-sdk-java-v2.

debora-ito avatar debora-ito commented on July 19, 2024

@HarshitGupta11 can you tell us more why do you need the SDK to shade all its dependencies? What you're trying to do?

from aws-sdk-java-v2.

SentryMan avatar SentryMan commented on July 19, 2024

are you aware that you can use the maven shade plugin to do this yourself?

from aws-sdk-java-v2.

HarshitGupta11 avatar HarshitGupta11 commented on July 19, 2024

Hi @debora-ito , these are the unshaded classes i found in version 2.25.53: List of unshaded classes:[org/reactivestreams/FlowAdapters$FlowPublisherFromReactive.class, org/reactivestreams/FlowAdapters$FlowToReactiveProcessor.class, org/reactivestreams/FlowAdapters$FlowToReactiveSubscriber.class, org/reactivestreams/FlowAdapters$FlowToReactiveSubscription.class, org/reactivestreams/FlowAdapters$ReactivePublisherFromFlow.class, org/reactivestreams/FlowAdapters$ReactiveToFlowProcessor.class, org/reactivestreams/FlowAdapters$ReactiveToFlowSubscriber.class, org/reactivestreams/FlowAdapters$ReactiveToFlowSubscription.class, org/reactivestreams/FlowAdapters.class, org/reactivestreams/Processor.class, org/reactivestreams/Publisher.class, org/reactivestreams/Subscriber.class, org/reactivestreams/Subscription.class]
I am writing a test in hadoop to verify that there are no as in the past upgrading to 2.24.46 has caused deployment failures having us to rollback all the changes.

from aws-sdk-java-v2.

HarshitGupta11 avatar HarshitGupta11 commented on July 19, 2024

the hadoop pull: apache/hadoop#6865

from aws-sdk-java-v2.

mukund-thakur avatar mukund-thakur commented on July 19, 2024

@debora-ito here are more details of slf4j issue we fixed before #4778 (comment)

from aws-sdk-java-v2.

debora-ito avatar debora-ito commented on July 19, 2024

Glad to hear. Let us know if there's any follow-up questions.

from aws-sdk-java-v2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.