Refactor: Signers about aws-sdk-java-v2 HOT 2 CLOSED

Big outlines, about signing the HTTP requests:

• The signer (e.g. Aws4Signer) should be a decorator for a HTTP request object.
• Less injection through setters, in favor of injection through the ctor (less configurable objects)
• Better encapsulation of classes which require a lot of knowledge about the SDK (e.g. classes such as ExecutionContext)
• I do like the Handlers part, but I don't understand why is the Request parameterized with <Void> and what else could there be.

I wrote a post about it here. Any effort towards a similar, composable design, based on interfaces, would be an advance, from my point of view.

The main idea is that users should primarly be able to sign HTTP requests. I may not want to learn the whole SDK, but just make a few requests to some service. So I should be able to figure out in a matter of minutes, that I can do something like this:

    Request req = new SignedRequest(
        new Get (
            new HttpHeaders(
                ...
            ),
            "https://us-west2-aws.amazon.com/elasticsearch/_search"
        )
     )
     Response response = req.perform();
     InputStream body = response.content();

All of the above (SignedRequest, Get, HttpHeaders etc) are decorators for Request. I shouldn't have to worry about setting regions (region can be taken from the url, right?), execution contexts and client configurations. Maybe Builder instead of Decorator is also good, but then keep it simple, one single builder and no other setters.

from aws-sdk-java-v2.

Implemented

from aws-sdk-java-v2.