Comments (4)
theoparis
commented on August 16, 2024
This might be a c23 standard issue actually. I set cmake_c_standard to fix libarchive but it seems to break aws-lc.
from aws-lc.
samuel40791765
commented on August 16, 2024
Hi, thanks for reaching out!
I tried building off the tip of main with clang 17.0.6 on an x86_64 instance and everything seems to fine on my end. Both the debug and release build compile fine. Could you share the specific clang version were you using?
Output:
+ cmake ../aws-lc -GNinja -B/home/ubuntu/workplace/aws-lc/test_build_dir -DCMAKE_INSTALL_PREFIX=/home/ubuntu/workplace/aws-lc/test_build_dir/
-- The C compiler identification is Clang 17.0.6
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- The CXX compiler identification is Clang 17.0.6
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Perl: /usr/bin/perl (found version "5.30.0")
-- Checking for module 'libunwind-generic'
-- No package 'libunwind-generic' found
libunwind not found. Disabling unwind tests.
-- stdalign_check.c probe is positive, enabling AWS_LC_STDALIGN_AVAILABLE
-- builtin_swap_check.c probe is positive, enabling AWS_LC_BUILTIN_SWAP_SUPPORTED
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Using unsigned short
-- Check if the system is big endian - little endian
-- The ASM compiler identification is Clang
-- Found assembler: /usr/bin/cc
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Generating test executable mem_test.
-- Generating test executable mem_set_test.
-- Generating test executable dynamic_loading_test.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/ubuntu/workplace/aws-lc/test_build_dir
+ ninja -j8 -C test_build_dir run_tests
ninja: Entering directory `test_build_dir'
[536/540] cd /home/ubuntu/workplace/aws-lc && cd ssl/test/runner && /usr/local/go/bin/go t...r-test-file /home/ubuntu/workplace/aws-lc/ssl/test/runner/ssl_transfer/test_case_names.tx
0/0/992/1000/9280
0/0/992/1000/9280
0/0/993/1000/9280
0/0/1993/2000/9280
0/0/2992/3000/9280
0/0/2992/3000/9280
0/0/2992/3000/9280
0/0/2992/3000/9280
0/0/2993/3000/9280
0/0/3992/4000/9280
0/0/3993/4000/9280
0/0/4992/5000/9280
0/0/4992/5000/9280
0/0/4992/5000/9280
0/0/4993/5000/9280
0/0/5992/6000/9280
0/0/5992/6000/9280
0/0/5992/6000/9280
0/0/5993/6000/9280
0/0/6992/7000/9280
0/0/6992/7000/9280
0/0/6993/7000/9280
0/0/7992/8000/9280
0/0/7992/8000/9280
0/0/7993/8000/9280
0/0/8992/9000/9280
0/0/8993/9000/9280
0/0/9280/9280/9280
PASS
ok boringssl.googlesource.com/boringssl/ssl/test/runner 21.535s
[539/540] cd /home/ubuntu/workplace/aws-lc && /usr/local/go/bin/go test ./ssl/test/runner/...al/go/bin/go run util/all_tests.go -build-dir /home/ubuntu/workplace/aws-lc/test_build_di
ok boringssl.googlesource.com/boringssl/ssl/test/runner/hpke 0.082s
ok boringssl.googlesource.com/boringssl/util/ar 0.004s
crypto/crypto_test [shard 6/8]
crypto/crypto_test [shard 5/8]
crypto/crypto_test [shard 7/8]
crypto/crypto_test --gtest_filter=Crypto.OnDemandIntegrityTest (custom environment)
crypto/crypto_test [shard 4/8]
crypto/crypto_test [shard 8/8]
crypto/crypto_test --gtest_also_run_disabled_tests --gtest_filter=RSATest.DISABLED_BlindingCacheConcurrency
crypto/crypto_test [shard 2/8]
crypto/crypto_test [shard 1/8]
crypto/urandom_test
crypto/crypto_test --fork_unsafe_buffering --gtest_filter=RandTest.*:-RandTest.Fork
crypto/crypto_test --gtest_filter=RandTest.* (custom environment)
crypto/crypto_test --gtest_filter=ForkDetect.* (custom environment)
crypto/urandom_test (custom environment)
ssl/ssl_test [shard 1/8]
ssl/ssl_test [shard 2/8]
crypto/urandom_test (custom environment)
ssl/ssl_test [shard 3/8]
ssl/ssl_test [shard 4/8]
ssl/ssl_test [shard 6/8]
ssl/ssl_test [shard 5/8]
ssl/ssl_test [shard 7/8]
crypto/mem_test
crypto/mem_set_test
crypto/dynamic_loading_test
ssl/ssl_test [shard 8/8]
ssl/integration_test
crypto/crypto_test [shard 3/8]
crypto/urandom_test (custom environment)
crypto/urandom_test (custom environment)
crypto/crypto_test --gtest_also_run_disabled_tests --gtest_filter=BNTest.DISABLED_WycheproofPrimality
crypto/urandom_test (custom environment)
All tests passed!
As for your question, AWS-LC is not ABI stable or ABI compatible with OpenSSL. This means programs cannot directly swap out OpenSSL with AWS-LC without recompiling.
from aws-lc.
github-actions
commented on August 16, 2024
This issue has not received a response in 1 week. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled.
from aws-lc.
theoparis
commented on August 16, 2024
Hi, thanks for reaching out!
I tried building off the tip of main with clang 17.0.6 on an x86_64 instance and everything seems to fine on my end. Both the debug and release build compile fine. Could you share the specific clang version were you using?
Output:
+ cmake ../aws-lc -GNinja -B/home/ubuntu/workplace/aws-lc/test_build_dir -DCMAKE_INSTALL_PREFIX=/home/ubuntu/workplace/aws-lc/test_build_dir/ -- The C compiler identification is Clang 17.0.6 -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- The CXX compiler identification is Clang 17.0.6 -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found Perl: /usr/bin/perl (found version "5.30.0") -- Checking for module 'libunwind-generic' -- No package 'libunwind-generic' found libunwind not found. Disabling unwind tests. -- stdalign_check.c probe is positive, enabling AWS_LC_STDALIGN_AVAILABLE -- builtin_swap_check.c probe is positive, enabling AWS_LC_BUILTIN_SWAP_SUPPORTED -- Check if the system is big endian -- Searching 16 bit integer -- Looking for sys/types.h -- Looking for sys/types.h - found -- Looking for stdint.h -- Looking for stdint.h - found -- Looking for stddef.h -- Looking for stddef.h - found -- Check size of unsigned short -- Check size of unsigned short - done -- Using unsigned short -- Check if the system is big endian - little endian -- The ASM compiler identification is Clang -- Found assembler: /usr/bin/cc -- Looking for pthread.h -- Looking for pthread.h - found -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- Generating test executable mem_test. -- Generating test executable mem_set_test. -- Generating test executable dynamic_loading_test. -- Configuring done -- Generating done -- Build files have been written to: /home/ubuntu/workplace/aws-lc/test_build_dir + ninja -j8 -C test_build_dir run_tests ninja: Entering directory `test_build_dir' [536/540] cd /home/ubuntu/workplace/aws-lc && cd ssl/test/runner && /usr/local/go/bin/go t...r-test-file /home/ubuntu/workplace/aws-lc/ssl/test/runner/ssl_transfer/test_case_names.tx 0/0/992/1000/9280 0/0/992/1000/9280 0/0/993/1000/9280 0/0/1993/2000/9280 0/0/2992/3000/9280 0/0/2992/3000/9280 0/0/2992/3000/9280 0/0/2992/3000/9280 0/0/2993/3000/9280 0/0/3992/4000/9280 0/0/3993/4000/9280 0/0/4992/5000/9280 0/0/4992/5000/9280 0/0/4992/5000/9280 0/0/4993/5000/9280 0/0/5992/6000/9280 0/0/5992/6000/9280 0/0/5992/6000/9280 0/0/5993/6000/9280 0/0/6992/7000/9280 0/0/6992/7000/9280 0/0/6993/7000/9280 0/0/7992/8000/9280 0/0/7992/8000/9280 0/0/7993/8000/9280 0/0/8992/9000/9280 0/0/8993/9000/9280 0/0/9280/9280/9280 PASS ok boringssl.googlesource.com/boringssl/ssl/test/runner 21.535s [539/540] cd /home/ubuntu/workplace/aws-lc && /usr/local/go/bin/go test ./ssl/test/runner/...al/go/bin/go run util/all_tests.go -build-dir /home/ubuntu/workplace/aws-lc/test_build_di ok boringssl.googlesource.com/boringssl/ssl/test/runner/hpke 0.082s ok boringssl.googlesource.com/boringssl/util/ar 0.004s crypto/crypto_test [shard 6/8] crypto/crypto_test [shard 5/8] crypto/crypto_test [shard 7/8] crypto/crypto_test --gtest_filter=Crypto.OnDemandIntegrityTest (custom environment) crypto/crypto_test [shard 4/8] crypto/crypto_test [shard 8/8] crypto/crypto_test --gtest_also_run_disabled_tests --gtest_filter=RSATest.DISABLED_BlindingCacheConcurrency crypto/crypto_test [shard 2/8] crypto/crypto_test [shard 1/8] crypto/urandom_test crypto/crypto_test --fork_unsafe_buffering --gtest_filter=RandTest.*:-RandTest.Fork crypto/crypto_test --gtest_filter=RandTest.* (custom environment) crypto/crypto_test --gtest_filter=ForkDetect.* (custom environment) crypto/urandom_test (custom environment) ssl/ssl_test [shard 1/8] ssl/ssl_test [shard 2/8] crypto/urandom_test (custom environment) ssl/ssl_test [shard 3/8] ssl/ssl_test [shard 4/8] ssl/ssl_test [shard 6/8] ssl/ssl_test [shard 5/8] ssl/ssl_test [shard 7/8] crypto/mem_test crypto/mem_set_test crypto/dynamic_loading_test ssl/ssl_test [shard 8/8] ssl/integration_test crypto/crypto_test [shard 3/8] crypto/urandom_test (custom environment) crypto/urandom_test (custom environment) crypto/crypto_test --gtest_also_run_disabled_tests --gtest_filter=BNTest.DISABLED_WycheproofPrimality crypto/urandom_test (custom environment) All tests passed!As for your question, AWS-LC is not ABI stable or ABI compatible with OpenSSL. This means programs cannot directly swap out OpenSSL with AWS-LC without recompiling.
Alright good to know. I think I had set the Cmake c standard to 23 which is probably what caused these issues and not the clang version.
from aws-lc.
Related Issues (20)
- Android ignores the "-Wa, --noexecstack" flag so remove or suppress warnings. HOT 1
- Add soname HOT 7
- Licensing
- ignored-attributes warning
- Uninitialised variable in `ec_GFp_mont_batch_get_window` HOT 2
- Readme is not synchronised with `aws-lc-verification` HOT 1
- ssl_transfer_supported for client SSL connection
- Compiling with zig for x86_64-windows-gnu fails due to X509_NAME and wincrypt.h HOT 3
- Plans to replace code under the OpenSSL license? HOT 2
- Remove NASM requirement for windows builds HOT 3
- Failed to build AWS-LC on Ubuntu HOT 3
- AddressSanitizer SEGV when x509_name_ex_d2i() calls sk_STACK_OF_X509_NAME_ENTRY_pop_free() HOT 3
- redundant redeclaration of X509_OBJECT_new and X509_OBJECT_free HOT 2
- getrandom is not used on FreeBSD >= 12 HOT 1
- No release build on 32bit with gcc11+ HOT 2
- FIPS branch fips-2022-11-02 failed to build on AL2 aarch64 HOT 4
- QUIC support HOT 4
- Error during Cross-Compiling aws-iot-device-sdk-python-v2 with make HOT 4
- Packages for RPM and DEB HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-lc.