Giter Club home page Giter Club logo

Comments (4)

groverlalit avatar groverlalit commented on July 26, 2024

Thanks for bringing this to our attention. CfCT use stack sets to deploy the stacks. It would be great if we can review the errors you observed in the CFN events when deployed via stack sets.
Assumption: These issues are decoupled from Control Tower setup and CfCT. We may be able to set the CFN parameters to avoid specific issues.

If you prefer, you can open a support case to make it easy to share details from the CfCT manifest file and other details.

from network-orchestration-for-aws-transit-gateway.

randyspainhower avatar randyspainhower commented on July 26, 2024

so it would fail in the step function state machine for cfct in the deploying master account. the first error we got was related to the ListofCustomCidrBlocks pattern. it didn't matter if I had spaces or not after the comma it with error either way:
"RetryDeleteFlag": false,
"us-west-2": "Parameter 'ListOfCustomCidrBlocks' must match pattern (^$|^(([0-9]{1,3}\.){3}[0-9]{1,3}\/\d{1,2})(, (([0-9]{1,3}\.){3}[0-9]{1,3}\/\d{1,2}))$)",
"us-east-2": "Parameter 'ListOfCustomCidrBlocks' must match pattern (^$|^(([0-9]{1,3}\.){3}[0-9]{1,3}\/\d{1,2})(, (([0-9]{1,3}\.){3}[0-9]{1,3}\/\d{1,2}))
$)",
"OperationStatus": "FAILED"
}

I was able to get past that by commenting out the pattern requirement in the template. Then it would error at the service catalog app registry (I removed the request id and token id):
"us-west-2": "ResourceLogicalId:Application, ResourceType:AWS::ServiceCatalogAppRegistry::Application, ResourceStatusReason:Resource handler returned message: "'%VERSION%' is not a valid value for TagValue - it contains illegal characters (Service: ServiceCatalogAppRegistry, Status Code: 400, Request ID: ***)" (RequestToken: ***, HandlerErrorCode: InvalidRequest).",
"us-east-2": "ResourceLogicalId:Application, ResourceType:AWS::ServiceCatalogAppRegistry::Application, ResourceStatusReason:Resource handler returned message: "'%VERSION%' is not a valid value for TagValue - it contains illegal characters (Service: ServiceCatalogAppRegistry, Status Code: 400, Request ID: ***)" (RequestToken: ***, HandlerErrorCode: InvalidRequest)."
}

I commented that out and then it errored at the ResourceLogicalId:TgwPeeringLambdaFunction:
"OperationStatus": "FAILED",
"us-west-2": "ResourceLogicalId:TgwPeeringLambdaFunction, ResourceType:AWS::Lambda::Function, ResourceStatusReason:Properties validation failed for resource TgwPeeringLambdaFunction with message:\n#/Code/S3Bucket: failed validation constraint for keyword [pattern].",
"us-east-2": "ResourceLogicalId:TgwPeeringLambdaFunction, ResourceType:AWS::Lambda::Function, ResourceStatusReason:Properties validation failed for resource TgwPeeringLambdaFunction with message:\n#/Code/S3Bucket: failed validation constraint for keyword [pattern]."
}

I can open a support case if thats the best way. The old 2.0.0 template was pretty similar besides the new resources added in the v3.3.1 template.

from network-orchestration-for-aws-transit-gateway.

groverlalit avatar groverlalit commented on July 26, 2024

Hi @randyspainhower,
Thanks for providing details on your experience.

I am not aware if any customization was made to the STNO stack but it seems that the stack in the GitHub repo is being used to upgrade the version. The reason is that the GitHub stack has %VERSION% and S3Key (use Mapping) and also refers to other variables.
If the stack was customized then you need to use the Build steps to replace the variables with the values you provide.

You will not find these variables in the hub stack template that we host in our managed bucket. Implementation Guide Template Page.

In reference to ListOfCustomCidrBlocks parameter. The implementation guide defines it as required parameter. The reason we don't add default value of 0.0.0.0/1,128.0.0.0/1 to avoid internet to access APIs by default.

from network-orchestration-for-aws-transit-gateway.

groverlalit avatar groverlalit commented on July 26, 2024

Resolving this issue. Please reopen if you have any questions. Thanks.

from network-orchestration-for-aws-transit-gateway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.